From: Andrew Morton <akpm@linux-foundation.org>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: linux-mm@kvack.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, joe.jin@oracle.com
Subject: Re: [PATCH 1/1] mm: slub: fix corrupted freechain in deactivate_slab()
Date: Sat, 18 Apr 2020 13:04:05 -0700 [thread overview]
Message-ID: <20200418130405.b1cc0a2d23cbe30d632a3ec7@linux-foundation.org> (raw)
In-Reply-To: <d9ebb540-b3ec-a29a-1d7a-2f5762010b53@oracle.com>
On Fri, 17 Apr 2020 18:56:51 -0700 Dongli Zhang <dongli.zhang@oracle.com> wrote:
> > @@ -2096,6 +2097,7 @@ static void deactivate_slab(struct kmem_
> > slab_fix(s, "Isolate corrupted freechain");
> > break;
> > }
> > +#endif
> >
> > do {
> > prior = page->freelist;
> >
> > But it's a bit ugly. How about this?
>
> Sorry that I did not realize check_valid_pointer() requires CONFIG_SLAB_DEBUG.
>
> Yes, it is much better to encapsulate it into freelist_corrupted() and just
> return false when CONFIG_SLAB_DEBUG is not involved. The check_object() has
> similar implementation.
>
> Should I resend with your "Signed-off-by" or you would just fix it when applying?
That's OK. I'll fold the patches together and update the changelog
before sending the patch in to Linus.
prev parent reply other threads:[~2020-04-18 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 3:14 [PATCH 1/1] mm: slub: fix corrupted freechain in deactivate_slab() Dongli Zhang
2020-04-12 22:20 ` Dongli Zhang
2020-04-18 1:12 ` Andrew Morton
2020-04-18 1:56 ` Dongli Zhang
2020-04-18 20:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418130405.b1cc0a2d23cbe30d632a3ec7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dongli.zhang@oracle.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).