From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06FB1C38A30 for ; Sun, 19 Apr 2020 15:59:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A626121841 for ; Sun, 19 Apr 2020 15:59:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=oneplus.com header.i=@oneplus.com header.b="E2TaNkG0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A626121841 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=oneplus.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EAC358E0005; Sun, 19 Apr 2020 11:59:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5BA08E0003; Sun, 19 Apr 2020 11:59:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D710B8E0005; Sun, 19 Apr 2020 11:59:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id BF3E68E0003 for ; Sun, 19 Apr 2020 11:59:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 712C6180ACF8F for ; Sun, 19 Apr 2020 15:59:13 +0000 (UTC) X-FDA: 76725063786.22.cars54_8aa008ca12d2a X-HE-Tag: cars54_8aa008ca12d2a X-Filterd-Recvd-Size: 9163 Received: from APC01-HK2-obe.outbound.protection.outlook.com (mail-eopbgr1300104.outbound.protection.outlook.com [40.107.130.104]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Apr 2020 15:59:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZxjDw5q2xa5fBozu1VGrFUtZjis41cvE9w2JmBblt2p53scy3g70iW8UxPzeiy81qc30WX4hilryCuTajqMQ+PCBaKsAO1GWI3WJIZ78QS7nP9H8oV/yOmvW5yC2q9defG9lnfPf0q8D2yMLFogB2d5pglzSbmpGsqdLXX51VBHFdTxWCL+JcBt3pwLgCNdrO3p7A9lHOAM6XzKVRqkounIuxHL6hj0sUkVR1RNqUSlfFm5kplPbpYm8lOp3wRIOMu19Jg+J6N2XcVvC0OtzEW1yz1bezYKrEbDGlGMbLrUVytQmh7D4OiaSL2mAINMTXHqxUv+N4I9XRMsarThARA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7caYK5YVs13qvwqyqIZFSSuocK+u5/bOASdcjIn0WAI=; b=P9bnZ7gseB0RmzQ1wrc+uFtmuTYCiiynwDWtIpDYuXLdzJ5WN2KgqKeotwCa8GgCqJNi4wIIr3YKPETUSzigsoui4ZqXvqGWlw6SRIAwMs8ia/9wBoL5MwMnxV+bMfu8nIKcVmin83xFvRI9ktoVQq+iXXJ7iEoQlS0kK6FVsv+JyqBNisnEoi+pFMSZwZZh5A52eIkwnfjQzmVYLQDL/MlLQjq/n1JgQAuYhiSy47k9OVwC6q3opu1jeEjD9MWgNBSyy2hE4AWcwkdWjdTE73CKogPuycqYaD5cfWx5ByhB2NjPKGDqlU6/mlkuotv7Hs0TQNLKIF0dQl3jBrCOyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oneplus.com; dmarc=pass action=none header.from=oneplus.com; dkim=pass header.d=oneplus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oneplus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7caYK5YVs13qvwqyqIZFSSuocK+u5/bOASdcjIn0WAI=; b=E2TaNkG06cXZlscKwFZDY60DnytDwlOmhcjS3OitaIXvjb2+ikb1n8J0l/9SJGtTLUw+7WtSNov2/jPBW1Qy+O45gKS1i+WwNLhk5n6aEqgpKuGw56DW5nVs7/43jtKG5uLFJCX0Iizuaqx7nDnUUtHXhNYrybiurMegDneqGpc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=prathu.baronia@oneplus.com; Received: from SG2PR04MB3093.apcprd04.prod.outlook.com (2603:1096:4:6d::11) by SG2PR04MB2875.apcprd04.prod.outlook.com (2603:1096:4:21::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Sun, 19 Apr 2020 15:59:06 +0000 Received: from SG2PR04MB3093.apcprd04.prod.outlook.com ([fe80::140:687e:956d:8070]) by SG2PR04MB3093.apcprd04.prod.outlook.com ([fe80::140:687e:956d:8070%6]) with mapi id 15.20.2921.027; Sun, 19 Apr 2020 15:59:06 +0000 Date: Sun, 19 Apr 2020 21:28:57 +0530 From: Prathu Baronia To: "Huang, Ying" Cc: alexander.duyck@gmail.com, chintan.pandya@oneplus.com, mhocko@suse.com, akpm@linux-foundation.com, linux-mm@kvack.org, gregkh@linuxfoundation.com, gthelen@google.com, jack@suse.cz, ken.lin@oneplus.com, gasine.xu@oneplus.com Subject: Re: [PATCH v2] mm: Optimized hugepage zeroing & copying from user Message-ID: <20200419155856.dtwxomdkyujljdfi@oneplus.com> References: <20200414153829.GA15230@oneplus.com> <87r1wpzavo.fsf@yhuang-dev.intel.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87r1wpzavo.fsf@yhuang-dev.intel.com> User-Agent: NeoMutt/20171215 X-ClientProxiedBy: HK0PR03CA0100.apcprd03.prod.outlook.com (2603:1096:203:b0::16) To SG2PR04MB3093.apcprd04.prod.outlook.com (2603:1096:4:6d::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from oneplus.com (183.83.136.195) by HK0PR03CA0100.apcprd03.prod.outlook.com (2603:1096:203:b0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Sun, 19 Apr 2020 15:59:04 +0000 X-Originating-IP: [183.83.136.195] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b45378a-60b1-4940-1a7a-08d7e47a96d9 X-MS-TrafficTypeDiagnostic: SG2PR04MB2875:|SG2PR04MB2875: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 0378F1E47A X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR04MB3093.apcprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(136003)(376002)(396003)(39860400002)(366004)(346002)(5660300002)(66476007)(66556008)(6916009)(52116002)(2906002)(44832011)(4326008)(7696005)(66946007)(36756003)(2616005)(956004)(478600001)(3716004)(6666004)(8936002)(8676002)(26005)(81156014)(316002)(86362001)(186003)(8886007)(55016002)(1076003)(16526019)(107886003);DIR:OUT;SFP:1102; Received-SPF: None (protection.outlook.com: oneplus.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kkPZTAeDWnQDpks6pfJJ7ZKbU5E5eh2kQ5I+Dm6dW8NcqrgtvB1Udj7jm1BmVxLC+X6yVujxPxHzMS2rUn2w1S8tpn+ah3j+yN8fPhxmjLJJcttx19oGwEJAq5z892ms+Gna86JiYAdaYP7eapVCaYYtGg8lhgsBTP3S5uCMg9khmK6m4HTx0HvTjRtV+hjJG/VKzy6DbzHuR2ERzKax4u5loCQBr9CjU7PFOq9UUuAqJkh9N5EM7UvKkngxv8ZvKntiDDq3I58H9H9Qh3+duFx4TODUN2xzbsC0Sa9Mz1xkV+Ay6hBKQKQQip2gCBQQCJrGypkBg0zphExZKD4AnuJoKoDCyZsEkoIv6VH1te2s/eCV7wl54T0ZKAp6Ws8P71Ot27jMHGc85kwBrmiIRyNNQp4fTzffil2V72deyl/8iNMwkxFLmkZZ2xyDI3z3 X-MS-Exchange-AntiSpam-MessageData: 7Y96I2TlONVDGorprTQZVE3p/JZacHOFo1jD1vIyH/xpNYiqI85Gnpgvkz4JQTSxzQcSoRkWlYDYiT12LjM/pXHy+ZMXkLzTq/3tqKi9LYjPT9m2EGgvAhJ3dKpcebHUT4dQ2nLam57Pstpr2JjNow== X-OriginatorOrg: oneplus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b45378a-60b1-4940-1a7a-08d7e47a96d9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2020 15:59:06.5537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0423909d-296c-463e-ab5c-e5853a518df8 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 71GpqfZl5V5+GL/AcjQkNINk66AC7Go6hYVvB4PlcfLhKPnvYCWuMD0fgh1M7n4tAnf/qdk94sznEgN17gY2oh7pTfoP8hlEI9IH22Au49U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR04MB2875 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The 04/15/2020 11:27, Huang, Ying wrote: > > Can you describe your test? > We profile the clear_huge_page() using ftrace while parallely force triggering it by a simple userspace test code which allocates 100MB of anon memory and traverses through it in loop. > > You have tested the chunk sizes 4KB and 2MB, can you test some values in > between? For example 32KB or 64KB? Maybe there's a sweet point with > some smaller granularity and good performance. Based on your advise I tried chunk sizes of 4KB, 8KB, 16KB, 32KB and 64KB on arm64 and x86_64 by copying the kernel memset implementation for both the archs. ------------------------------------------------------------------------------- Results(the sample size is 100 for each and the values are in us):- ------------------------------------------------------------------------------- ARM64(CPU0 & 6 on and set at max frequency, DDR set to performance governor):- ------------------------------------------------------------------------------- Chunk Size = 4KB ----------------- Oneshot Mean : 3402.06 Stddev : 72.6576 Forward Mean : 3408.04 Stddev : 72.976 Reverse Mean : 17699.3 Stddev : 132.875 ----------------- Chunk Size = 8KB ----------------- Oneshot Mean : 3398.64 Stddev : 80.6334 Forward Mean : 3391.58 Stddev : 65.9063 Reverse Mean : 13909.2 Stddev : 194.324 ----------------- Chunk Size = 16KB ----------------- Oneshot Mean : 3393.57 Stddev : 72.2485 Forward Mean : 3404.69 Stddev : 84.4705 Reverse Mean : 9278.65 Stddev : 217.725 ----------------- Chunk Size = 32KB ----------------- Oneshot Mean : 3425.7 Stddev : 129.156 Forward Mean : 3402.07 Stddev : 82.6713 Reverse Mean : 6831.43 Stddev : 184.807 ----------------- Chunk Size = 64KB ----------------- Oneshot Mean : 3398.72 Stddev : 77.9703 Forward Mean : 3413.52 Stddev : 173.121 Reverse Mean : 5542.84 Stddev : 197.017 --------------------------------------------- x86_64(Only CPU0 on and set to max frequency) --------------------------------------------- Chunk Size = 4KB ----------------- Oneshot Mean : 6752.59 Stddev : 298.988 Forward Mean : 6873.6 Stddev : 325.607 Reverse Mean : 6722.88 Stddev : 365.837 ----------------- Chunk Size = 8KB ----------------- Oneshot Mean : 6848.57 Stddev : 955.312 Forward Mean : 7012.24 Stddev : 1377.27 Reverse Mean : 6688.83 Stddev : 589.935 ----------------- Chunk Size = 16KB ----------------- Oneshot Mean : 6846.87 Stddev : 546.173 Forward Mean : 6785.26 Stddev : 248.022 Reverse Mean : 6613.33 Stddev : 350.003 ----------------- Chunk Size = 32KB ----------------- Oneshot Mean : 6862.19 Stddev : 870.524 Forward Mean : 6826.3 Stddev : 870.023 Reverse Mean : 6747.69 Stddev : 1047.5 ----------------- Chunk Size = 64KB ----------------- Oneshot Mean : 6806.9 Stddev : 609.112 Forward Mean : 6774.53 Stddev : 311.954 Reverse Mean : 6553.47 Stddev : 293.52 -- Prathu Baronia OnePlus RnD