From: Hillf Danton <hdanton@sina.com>
To: Dan Schatzberg <schatzberg.dan@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/4] loop: Use worker per cgroup instead of kworker
Date: Tue, 21 Apr 2020 10:48:45 +0800 [thread overview]
Message-ID: <20200421024845.6948-1-hdanton@sina.com> (raw)
In-Reply-To: <20200420223936.6773-1-schatzberg.dan@gmail.com>
On Mon, 20 Apr 2020 18:39:29 -0400 Dan Schatzberg wrote:
>
> @@ -1140,8 +1215,17 @@ static int __loop_clr_fd(struct loop_device *lo, bool release)
> blk_mq_freeze_queue(lo->lo_queue);
>
> spin_lock_irq(&lo->lo_lock);
> + destroy_workqueue(lo->workqueue);
Destruct it out of atomic context.
> lo->lo_backing_file = NULL;
> + list_for_each_entry_safe(worker, pos, &lo->idle_worker_list,
> + idle_list) {
> + list_del(&worker->idle_list);
> + rb_erase(&worker->rb_node, &lo->worker_tree);
> + css_put(worker->css);
> + kfree(worker);
> + }
> spin_unlock_irq(&lo->lo_lock);
next prev parent reply other threads:[~2020-04-21 2:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 22:39 [PATCH 0/4] Charge loop device i/o to issuing cgroup Dan Schatzberg
2020-04-20 22:39 ` [PATCH 1/4] loop: Use worker per cgroup instead of kworker Dan Schatzberg
2020-04-20 22:39 ` [PATCH 2/4] mm: support nesting memalloc_use_memcg() Dan Schatzberg
2020-04-21 0:43 ` Shakeel Butt
2020-04-22 1:13 ` Roman Gushchin
2020-04-20 22:39 ` [PATCH 3/4] mm: Charge active memcg when no mm is set Dan Schatzberg
2020-04-20 22:39 ` [PATCH 4/4] loop: Charge i/o to mem and blk cg Dan Schatzberg
2020-04-21 2:48 ` Hillf Danton [this message]
2020-04-21 13:55 ` [PATCH 1/4] loop: Use worker per cgroup instead of kworker Dan Schatzberg
[not found] ` <20200421033337.13208-1-hdanton@sina.com>
2020-04-21 13:57 ` [PATCH 4/4] loop: Charge i/o to mem and blk cg Dan Schatzberg
2020-05-28 13:54 [PATCH v6 0/4] Charge loop device i/o to issuing cgroup Dan Schatzberg
2020-05-28 13:54 ` [PATCH 1/4] loop: Use worker per cgroup instead of kworker Dan Schatzberg
2020-08-24 15:35 [PATCH v7 0/4] Charge loop device i/o to issuing cgroup Dan Schatzberg
2020-08-24 15:35 ` [PATCH 1/4] loop: Use worker per cgroup instead of kworker Dan Schatzberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421024845.6948-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schatzberg.dan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).