From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68E70C2BA19 for ; Tue, 21 Apr 2020 09:36:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 29827206E9 for ; Tue, 21 Apr 2020 09:36:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=oneplus.com header.i=@oneplus.com header.b="CjZpkxkX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29827206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=oneplus.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BA1AD8E0005; Tue, 21 Apr 2020 05:36:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2B358E0003; Tue, 21 Apr 2020 05:36:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CC298E0005; Tue, 21 Apr 2020 05:36:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 81DD58E0003 for ; Tue, 21 Apr 2020 05:36:33 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4667199BF for ; Tue, 21 Apr 2020 09:36:33 +0000 (UTC) X-FDA: 76731357066.24.body97_73520c4f5fb2f X-HE-Tag: body97_73520c4f5fb2f X-Filterd-Recvd-Size: 7097 Received: from KOR01-PS2-obe.outbound.protection.outlook.com (mail-eopbgr1280107.outbound.protection.outlook.com [40.107.128.107]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 09:36:32 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R82fYQl23WaLJPD1k0b9872IDQfGlSSIKyVBSeSjvqAtk97MAwUbKkN/pAJWvErzNY6LYsP3lFmPcBA+FX8mz9MrSVocAgEBq6saNlRrIYXlVkOcKs8bWAwIkbGYiVHyYPcyikA7zgcvoce7ueAUrJrIYg0yGTXkndz28ChE0SpJD3ytv0wom7oeSwP+x11xCAQ/Vv6QHzbC/emrupOIdNqEKpVvxlWcuCC3EYGf9z9T6q/YvrOD2nunIKsP25I0ufPm7YoODhTakF9HMq8tuTdRlaZti1OQG53B4c+XPvmYjVOk/QxOCEMSifZfqcl/NqMOmVo5OU+ZuBYtUNldMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/QrkvPDzmK0XgkhUYanlaT9/lPNEpUTq548J3TyCy6k=; b=NuH1NSkTnORg4ESq6een8ozUnWCGicAf+VmXTr5lT/3ZhskgzWySzVIgBCilge7RSaKg0Pp1/zymXOSpr0fcPg/fxOqSIy1cQNlxtoo0s4CE49SWuaJC9+S/Vj0DEOuI0e6kSs+npBrYvKmydJ/DAGAwQq8+N/2cHntz8vnfRmOcRz0F4dpgs+zD9j8DAn0Orbc8Uuj1lr9u+J5RQCknXEuriEoY5XADO7BHT0FlH1fs3U6xd8Azf22l7B8p/AHw2myyhbiivF80S/TodDj91D0FWxNoWbDPGMg97KNnxoxOkcPUyWM1ATn1Yw7VQMJ5lDiHIYeIYKPqv/NXpOOv0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oneplus.com; dmarc=pass action=none header.from=oneplus.com; dkim=pass header.d=oneplus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oneplus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/QrkvPDzmK0XgkhUYanlaT9/lPNEpUTq548J3TyCy6k=; b=CjZpkxkXXy8sMLYjKB2f5UCdXLoPXrnRykvgyPORJdc71Bg1yWORFlgNSp8TIyFltKfpq2JOa5cJl933PYPSSvInowjgEAgHwedsSvctegFE5SH8uqrOs9soaaiprIcGANMSM/EG5PX9J31HRrCgLA6euxGLCnu6sRCCFMB7rjc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=prathu.baronia@oneplus.com; Received: from SL2PR04MB3098.apcprd04.prod.outlook.com (2603:1096:100:35::9) by SL2PR04MB3164.apcprd04.prod.outlook.com (2603:1096:100:39::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 09:36:29 +0000 Received: from SL2PR04MB3098.apcprd04.prod.outlook.com ([fe80::405a:4f1c:7913:2e1d]) by SL2PR04MB3098.apcprd04.prod.outlook.com ([fe80::405a:4f1c:7913:2e1d%7]) with mapi id 15.20.2921.027; Tue, 21 Apr 2020 09:36:29 +0000 Date: Tue, 21 Apr 2020 15:06:21 +0530 From: Prathu Baronia To: catalin.marinas@arm.com Cc: alexander.duyck@gmail.com, chintan.pandya@oneplus.com, mhocko@suse.com, akpm@linux-foundation.org, linux-mm@kvack.org, gregkh@linuxfoundation.com, gthelen@google.com, jack@suse.cz, ken.lin@oneplus.com, gasine.xu@oneplus.com, ying.huang@intel.com, mark.rutland@arm.com, will@kernel.org Subject: Re: [PATCH v2] mm: Optimized hugepage zeroing & copying from user Message-ID: <20200421093621.3fuptvf2qbyfzwfz@oneplus.com> References: <20200414153829.GA15230@oneplus.com> <87r1wpzavo.fsf@yhuang-dev.intel.com> <20200419155856.dtwxomdkyujljdfi@oneplus.com> <87k12bt3ff.fsf@yhuang-dev.intel.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87k12bt3ff.fsf@yhuang-dev.intel.com> User-Agent: NeoMutt/20171215 X-ClientProxiedBy: PN1PR0101CA0004.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::14) To SL2PR04MB3098.apcprd04.prod.outlook.com (2603:1096:100:35::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from oneplus.com (183.83.136.195) by PN1PR0101CA0004.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Tue, 21 Apr 2020 09:36:26 +0000 X-Originating-IP: [183.83.136.195] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 391845cd-e464-4d69-85da-08d7e5d77844 X-MS-TrafficTypeDiagnostic: SL2PR04MB3164:|SL2PR04MB3164: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 038002787A X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR04MB3098.apcprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(5660300002)(81156014)(6916009)(8936002)(956004)(6666004)(186003)(2616005)(8676002)(2906002)(4744005)(66946007)(66556008)(66476007)(8886007)(16526019)(36756003)(26005)(316002)(7696005)(52116002)(86362001)(7416002)(1076003)(55016002)(4326008)(478600001)(44832011);DIR:OUT;SFP:1102; Received-SPF: None (protection.outlook.com: oneplus.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2doX6xtdUqEEnp1eCJI8x5JhtkXYQSKuU3ZNGJqCZi40zovHqLY3swrMQUPXW8XkxWsvzhaEF/8w+Vs4fl0o0AM1Fnxi/i5TxX+vQEsAdEhWZKzQ4jIkaY7wC136zyd5Da4x2O6BeSj4Nj6XvlwgQUyjAuzRDQ8Bf0Rz/mfBM5DgfJX6K7RQFleV6EdOmLnZivhGHweBt3043NxPZS3grjL0TkP/8FgtE2ddgWr8eItnD1YuPKoCE/6t6412lcav4COJuEYq24sQ9fcROj3MF7NMj8uQMh+5KWcRoi45PH492pzSeFgxI4wmETJSDLhUOyGU0poT09qA7o87mmKQhxSR0O6vaWUZQ3IihQpg8Ie39uJkp2bNbq3BV2tzvPftFybJp6YArTnwOT+GE+oLxxfgVPb2yPb70NQ0BK/d3Vbiw6/3Y7F23y+lM9HbaXYq X-MS-Exchange-AntiSpam-MessageData: aLGhC234hOskwEA1EVgSJVqQ/MP4nr+pkYSqFqwmhkM3cuIXqYN+PTb0XLx7drksOxX4mB4nI6DiLxGgGHseZPsthVR+EKyZiaalELBOdJ5IbWMsqy54NtG2V3tQ5qBff/hotWjvvubVf0px6OlLSQ== X-OriginatorOrg: oneplus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 391845cd-e464-4d69-85da-08d7e5d77844 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2020 09:36:29.8038 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0423909d-296c-463e-ab5c-e5853a518df8 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LSgpb0Ij0ZulXBd3Fg/tJiftW0z8z9Esi/CUYfxrAsh0ZjiW8TLcr5akSG0YPGCL6UHr5gRtO2ZXQ38m7XhsnW/xQHq3uLKHbzyIn0aa/ZM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR04MB3164 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: With below v2 patch we observe a significantly(~65%) improved zeroing time for hugepages. We profiled the clear_huge_page() using ftrace on Qualcomm's SM8150 platform under controlled conditions(i.e. only CPU0 and 6 turned on and set to max frequency, and DDR set to performance governor). The existing method uses a reverse traversal of a section of a hugepage which based on our series of experiments proves slower than a oneshot(v2) approach on ARM64.(more details in mail thread) We didn't see any benefit on x86 so v2 probably won't find any place in the main memory.c code. We are currently thinking of making this optimization ARM64 specific for better performance by placing this in arch/arm64/mm/memory.c(to be created) file. We would really appreciate if you can share your opinion on this. -- Prathu Baronia OnePlus RnD