linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Ignatov <rdna@fb.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Kees Cook <keescook@chromium.org>,
	Iurii Zaikin <yzaikin@google.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-fsdevel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<bpf@vger.kernel.org>
Subject: Re: [PATCH 1/5] bpf-cgroup: remove unused exports
Date: Wed, 22 Apr 2020 16:39:08 -0700	[thread overview]
Message-ID: <20200422233908.GA6764@rdna-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200421171539.288622-2-hch@lst.de>

Christoph Hellwig <hch@lst.de> [Tue, 2020-04-21 10:17 -0700]:
> Except for a few of the networking hooks called from modular ipv4 or
> ipv6 code, all of hooks are just called from guaranteed to be built-in
> code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

I checked it as well it see same thing:

- __cgroup_bpf_check_dev_permission is called in
  security/device_cgroup.c under CONFIG_CGROUP_DEVICE;

- __cgroup_bpf_run_filter_sysctl is called in fs/proc/proc_sysctl.c
  under CONFIG_PROC_SYSCTL;

- __cgroup_bpf_run_filter_[gs]etsockopt is called in net/socket.c under
  CONFIG_NET;

All three configs are bool-s so LGTM.

Acked-by: Andrey Ignatov <rdna@fb.com>

-- 
Andrey Ignatov


  reply	other threads:[~2020-04-22 23:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 17:15 pass kernel pointers to the sysctl ->proc_handler method v2 Christoph Hellwig
2020-04-21 17:15 ` [PATCH 1/5] bpf-cgroup: remove unused exports Christoph Hellwig
2020-04-22 23:39   ` Andrey Ignatov [this message]
2020-04-21 17:15 ` [PATCH 2/5] mm: remove watermark_boost_factor_sysctl_handler Christoph Hellwig
2020-04-21 19:31   ` David Rientjes
2020-04-21 17:15 ` [PATCH 3/5] sysctl: remove all extern declaration from sysctl.c Christoph Hellwig
2020-04-22 10:30   ` Vlastimil Babka
2020-04-22 17:24     ` Christoph Hellwig
2020-04-21 17:15 ` [PATCH 4/5] sysctl: avoid forward declarations Christoph Hellwig
2020-04-21 17:15 ` [PATCH 5/5] sysctl: pass kernel pointers to ->proc_handler Christoph Hellwig
2020-04-21 19:16   ` Al Viro
2020-04-22  2:46     ` Al Viro
2020-04-22  6:09       ` Christoph Hellwig
2020-04-21 19:23   ` Andrey Ignatov
2020-04-22 17:22     ` Christoph Hellwig
2020-04-22 23:40       ` Andrey Ignatov
2020-04-24  6:43 pass kernel pointers to the sysctl ->proc_handler method v3 Christoph Hellwig
2020-04-24  6:43 ` [PATCH 1/5] bpf-cgroup: remove unused exports Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422233908.GA6764@rdna-mbp.dhcp.thefacebook.com \
    --to=rdna@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=hch@lst.de \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).