From: Feng Tang <feng.tang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>,
Mel Gorman <mgorman@suse.de>, Kees Cook <keescook@chromium.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Iurii Zaikin <yzaikin@google.com>,
"Kleen, Andi" <andi.kleen@intel.com>,
"Chen, Tim C" <tim.c.chen@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mm/util.c: make vm_memory_committed() more accurate
Date: Fri, 15 May 2020 21:01:07 +0800 [thread overview]
Message-ID: <20200515130107.GG69177@shbuild999.sh.intel.com> (raw)
In-Reply-To: <20200515090440.GN29153@dhcp22.suse.cz>
On Fri, May 15, 2020 at 05:04:40PM +0800, Michal Hocko wrote:
> On Fri 15-05-20 16:11:09, Feng Tang wrote:
> > On Fri, May 15, 2020 at 03:23:07PM +0800, Michal Hocko wrote:
> > > On Fri 08-05-20 15:25:16, Feng Tang wrote:
> > > > percpu_counter_sum_positive() will provide more accurate info.
> > >
> > > Why do we need that?
> >
> > This is a preparation for patch 3/3, which will enlarge the batch size
> > of percpu-counter 'vm_committed_as'. Andi Kleen concerned that may
> > hurt the accuracy for those readers (currently only /proc/meminfo
> > and hyperV balloon drivers for status check)
> >
> > As in worst case, the deviation could be 'batch * nr_cpus', and
> > with patch 3/3, that could be totalram_pages/16.
>
> This information belongs to the changelog.
Will add it in v3, thanks
- Feng
next prev parent reply other threads:[~2020-05-15 13:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 7:25 [PATCH 0/3] make vm_committed_as_batch aware of vm overcommit policy Feng Tang
2020-05-08 7:25 ` [PATCH 1/3] proc/meminfo: avoid open coded reading of vm_committed_as Feng Tang
2020-05-15 7:22 ` Michal Hocko
2020-05-08 7:25 ` [PATCH 2/3] mm/util.c: make vm_memory_committed() more accurate Feng Tang
2020-05-15 7:23 ` Michal Hocko
2020-05-15 8:11 ` Feng Tang
2020-05-15 9:04 ` Michal Hocko
2020-05-15 13:01 ` Feng Tang [this message]
2020-05-08 7:25 ` [PATCH 3/3] mm: adjust vm_committed_as_batch according to vm overcommit policy Feng Tang
2020-05-08 11:24 ` Matthew Wilcox
2020-05-08 12:33 ` Feng Tang
2020-05-15 7:41 ` Michal Hocko
2020-05-15 8:02 ` Feng Tang
2020-05-15 9:08 ` Michal Hocko
2020-05-15 11:26 ` Feng Tang
2020-05-15 7:44 ` Michal Hocko
2020-05-15 8:38 ` Feng Tang
[not found] ` <20200521212726.GC6367@ovpn-112-192.phx2.redhat.com>
[not found] ` <20200526181459.GD991@lca.pw>
2020-05-27 1:14 ` [PATCH 0/3] make vm_committed_as_batch aware of " Andi Kleen
2020-05-27 1:43 ` Feng Tang
2020-05-27 1:46 ` Feng Tang
2020-05-27 2:25 ` Qian Cai
2020-05-27 10:46 ` Feng Tang
2020-05-27 12:05 ` Qian Cai
2020-05-27 13:33 ` Feng Tang
2020-05-27 15:42 ` Qian Cai
2020-05-28 14:18 ` Qian Cai
2020-05-28 15:10 ` Feng Tang
2020-05-28 15:21 ` Kleen, Andi
2020-05-29 15:43 ` Feng Tang
2020-05-29 15:50 ` Andi Kleen
2020-05-29 16:04 ` Feng Tang
2020-05-28 15:48 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515130107.GG69177@shbuild999.sh.intel.com \
--to=feng.tang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=tim.c.chen@intel.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).