From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23CC4C433E0 for ; Fri, 15 May 2020 13:39:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC31F20657 for ; Fri, 15 May 2020 13:39:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bThR5Xdc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC31F20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 901B780052; Fri, 15 May 2020 09:39:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DABD80050; Fri, 15 May 2020 09:39:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79F9180052; Fri, 15 May 2020 09:39:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 625A080050 for ; Fri, 15 May 2020 09:39:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1DF72181AC553 for ; Fri, 15 May 2020 13:39:53 +0000 (UTC) X-FDA: 76819061466.23.eye79_907d72e82932a X-HE-Tag: eye79_907d72e82932a X-Filterd-Recvd-Size: 2555 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 May 2020 13:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=7jF/5Wz0vEdYXDOMS0hCwx2KuSkqA3em8Ujbgxg5dVM=; b=bThR5XdcGlFQIv9J5sxkcNpxLe 3bVHB29orPrx+KmFcA/Ab8Ls5Trsf8Y1fG/Oug3dqYaKmpXnUi3RLY8q4THZGctwPj5rk/VYg1BNc ZbE9OKHL9jgbu+6GmTAVBhDy0SjKKxTrm9vEK8L0Dl3xYMd8ob8x0ZTXWIkFGEtecGDTbh0JXRqBL NNz3YIiJW8Kzm5bL+garMuDv5MSov9vdW9w/zAzdAWb23oRmQejaUzni2VOFkwtZKan+8QBAsyFjf T+TAH6E0gtEfk9LHFkQvOECH4MPoGGvVo32a93kRagAi3pufRGPbC9XVq2Hkw1YJokt7seva3rOU5 TckdIrOg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZaD0-0005jB-4C; Fri, 15 May 2020 13:17:02 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 24/36] mm: Remove page fault assumption of compound page size Date: Fri, 15 May 2020 06:16:44 -0700 Message-Id: <20200515131656.12890-25-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200515131656.12890-1-willy@infradead.org> References: <20200515131656.12890-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" A compound page in the page cache will not necessarily be of PMD size, so check explicitly. Signed-off-by: Matthew Wilcox (Oracle) --- mm/memory.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index f703fe8c8346..d68ce428ddd2 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3549,13 +3549,14 @@ static vm_fault_t do_set_pmd(struct vm_fault *vmf= , struct page *page) unsigned long haddr =3D vmf->address & HPAGE_PMD_MASK; pmd_t entry; int i; - vm_fault_t ret; + vm_fault_t ret =3D VM_FAULT_FALLBACK; =20 if (!transhuge_vma_suitable(vma, haddr)) - return VM_FAULT_FALLBACK; + return ret; =20 - ret =3D VM_FAULT_FALLBACK; page =3D compound_head(page); + if (page_order(page) !=3D HPAGE_PMD_ORDER) + return ret; =20 /* * Archs like ppc64 need additonal space to store information --=20 2.26.2