From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D2AC433E0 for ; Sat, 16 May 2020 03:20:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45C922074A for ; Sat, 16 May 2020 03:20:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45C922074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4053B80008; Fri, 15 May 2020 23:20:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B9BE80005; Fri, 15 May 2020 23:20:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00FE980008; Fri, 15 May 2020 23:20:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id DD1B780005 for ; Fri, 15 May 2020 23:20:08 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AB5648248047 for ; Sat, 16 May 2020 03:20:08 +0000 (UTC) X-FDA: 76821128496.04.blow32_1e54288cf1d25 X-HE-Tag: blow32_1e54288cf1d25 X-Filterd-Recvd-Size: 3579 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 May 2020 03:20:08 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id s20so1696539plp.6 for ; Fri, 15 May 2020 20:20:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WSjrRs+0uw9ZlSZjuW3x7w+Qi8+kmil3SD7+oVGrims=; b=rpXWKjMCrhURKraUEcbL9pYcKMGlHWUAnXIDpmUJEIEfqE7FU6MssyHU3tbhFmm7nu o9x47CO0mbzMrr24yAFA2iCOk3dvk9uhVSnmV82KzNGvdniNMBb5w5oiok15tLyWwUvB g744/W80Q6S4lr/f+ZmFJOzz3fNCNBJt3HSPmzd+e6EduL/APkNrDa7R9GNKzgQsvmEv DZtzMDlvK0lGxUGHxeWMPVSyOvU4OARlozh9kAuSiylNJIt05ISHUSFp5/l0Pnl5h6E8 Q5M+4blTqTGvgLIUagYkhqGUbLCCGIXuRQ8wbUBfgLTxzdNAy429YyO5hhPqtfac3nuE 9c+A== X-Gm-Message-State: AOAM530ElTeFUS0g85aL1Kbfo3F7bQw7t/DCzpFgn0JPOkF6APDu7X1r dsIYKpS7awbmJ/Rb1sI740s= X-Google-Smtp-Source: ABdhPJzX3emfY2u5XlGWmWnMHz1FoWzaUTuwWxyn8o3ueiTdT13lL7oD1fI78RNo5dxjkInTLInT+A== X-Received: by 2002:a17:90a:1912:: with SMTP id 18mr6556766pjg.115.1589599207438; Fri, 15 May 2020 20:20:07 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id t22sm2578636pjs.1.2020.05.15.20.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 20:20:04 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id E0FF742309; Sat, 16 May 2020 03:19:59 +0000 (UTC) From: Luis Chamberlain To: axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org Cc: mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH v5 7/7] loop: be paranoid on exit and prevent new additions / removals Date: Sat, 16 May 2020 03:19:56 +0000 Message-Id: <20200516031956.2605-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200516031956.2605-1-mcgrof@kernel.org> References: <20200516031956.2605-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Be pedantic on removal as well and hold the mutex. This should prevent uses of addition while we exit. Reviewed-by: Ming Lei Signed-off-by: Luis Chamberlain --- drivers/block/loop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 14372df0f354..54fbcbd930de 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -2333,6 +2333,8 @@ static void __exit loop_exit(void) =20 range =3D max_loop ? max_loop << part_shift : 1UL << MINORBITS; =20 + mutex_lock(&loop_ctl_mutex); + idr_for_each(&loop_index_idr, &loop_exit_cb, NULL); idr_destroy(&loop_index_idr); =20 @@ -2340,6 +2342,8 @@ static void __exit loop_exit(void) unregister_blkdev(LOOP_MAJOR, "loop"); =20 misc_deregister(&loop_misc); + + mutex_unlock(&loop_ctl_mutex); } =20 module_init(loop_init); --=20 2.26.2