From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 204C6C433DF for ; Fri, 22 May 2020 05:57:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C6B5B20757 for ; Fri, 22 May 2020 05:57:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="IB55IcEi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6B5B20757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 54B7C80009; Fri, 22 May 2020 01:57:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5226680007; Fri, 22 May 2020 01:57:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4382280009; Fri, 22 May 2020 01:57:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 29AAB80007 for ; Fri, 22 May 2020 01:57:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DAE7845DA for ; Fri, 22 May 2020 05:57:22 +0000 (UTC) X-FDA: 76843297524.20.balls07_61d533aab500 X-HE-Tag: balls07_61d533aab500 X-Filterd-Recvd-Size: 6344 Received: from mail26.static.mailgun.info (mail26.static.mailgun.info [104.130.122.26]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 May 2020 05:57:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590127042; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=wxYTDj1XX4heEChza4HPVrwYprGUE8YzD1J8/xWHYNM=; b=IB55IcEiy0wsDhl4LGL8Cv/y7L4iFG7XypPj8D7B+QsbZYrMRZ8OO1KKEa5IkzK46ng/F+ME EKcFhmZw+xeHpay9ZSc+U0pEurggmXLU4IB/Lv7WOIoDjsxu/SC/gUy5FXUj/ndH01OGZ1Wd Fih7rQ1wYBxvme0/c3cwmx+Q3bw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5ec769bd9d4cf4d3efb21a2b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 22 May 2020 05:57:17 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6A3BFC433C9; Fri, 22 May 2020 05:57:17 +0000 (UTC) Received: from pdaly-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: pdaly) by smtp.codeaurora.org (Postfix) with ESMTPSA id 32E51C433C6; Fri, 22 May 2020 05:57:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 32E51C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pdaly@codeaurora.org Date: Thu, 21 May 2020 22:57:10 -0700 From: Patrick Daly To: Catalin Marinas Cc: Will Deacon , linux-arch@vger.kernel.org, Vladimir Murzin , Szabolcs Nagy , Andrey Konovalov , Kevin Brodsky , linux-mm@kvack.org, Vincenzo Frascino , Peter Collingbourne , Dave P Martin , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 24/26] arm64: mte: Introduce early param to disable MTE support Message-ID: <20200522055710.GA25791@pdaly-linux.qualcomm.com> References: <20200515171612.1020-1-catalin.marinas@arm.com> <20200515171612.1020-25-catalin.marinas@arm.com> <20200518113103.GA32394@willie-the-truck> <20200518172054.GL9862@gaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518172054.GL9862@gaia> User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 18, 2020 at 06:20:55PM +0100, Catalin Marinas wrote: > On Mon, May 18, 2020 at 12:31:03PM +0100, Will Deacon wrote: > > On Mon, May 18, 2020 at 12:26:30PM +0100, Vladimir Murzin wrote: > > > On 5/15/20 6:16 PM, Catalin Marinas wrote: > > > > For performance analysis it may be desirable to disable MTE altogether > > > > via an early param. Introduce arm64.mte_disable and, if true, filter out > > > > the sanitised ID_AA64PFR1_EL1.MTE field to avoid exposing the HWCAP to > > > > user. > > > > > > > > Signed-off-by: Catalin Marinas > > > > Cc: Will Deacon > > > > --- > > > > > > > > Notes: > > > > New in v4. > > > > > > > > Documentation/admin-guide/kernel-parameters.txt | 4 ++++ > > > > arch/arm64/kernel/cpufeature.c | 11 +++++++++++ > > > > 2 files changed, 15 insertions(+) > > > > > > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > > > > index f2a93c8679e8..7436e7462b85 100644 > > > > --- a/Documentation/admin-guide/kernel-parameters.txt > > > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > > > @@ -373,6 +373,10 @@ > > > > arcrimi= [HW,NET] ARCnet - "RIM I" (entirely mem-mapped) cards > > > > Format: ,, > > > > > > > > + arm64.mte_disable= > > > > + [ARM64] Disable Linux support for the Memory > > > > + Tagging Extension (both user and in-kernel). > > > > + > > > > > > Should it really to take parameter (on/off/true/false)? It may lead to expectation > > > that arm64.mte_disable=false should enable MT and, yes, double negatives make it > > > look ugly, so if we do need parameter, can it be arm64.mte=on/off/true/false? > > > > I don't think "performance analysis" is a good justification for this > > parameter tbh. We don't tend to add these options for other architectural > > features, and I don't see why MTE is any different in this regard. > > There is an expectation of performance impact with MTE enabled, > especially if it's running in synchronous mode. For the in-kernel MTE, > we could add a parameter which sets sync vs async at boot time rather > than a big disable knob. It won't affect user space however. > > The other 'justification' is if your hardware has weird unexpected > behaviour but I'd like this handled via errata workarounds. > > I'll let the people who asked for this to chip in ;). I agree with you > that we rarely add these (and I rejected a similar option a few weeks > ago on the AMU patchset). We've been looking into other ways this on/off behavior could be achieved. The "arm,armv8.5-memtag" DT flag already provides what we want - meaning that this flag could be removed if the system did not support MTE. I did see your remark on "arm64: mte: Check the DT memory nodes for MTE support" questioning whether it was the right approach - is this still the case? --Patrick -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project