From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3160C433E1 for ; Tue, 26 May 2020 16:02:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C79B20721 for ; Tue, 26 May 2020 16:02:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="AZvUVlJq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C79B20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 26123800B6; Tue, 26 May 2020 12:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EA9480010; Tue, 26 May 2020 12:02:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D949800B6; Tue, 26 May 2020 12:02:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id E63A180010 for ; Tue, 26 May 2020 12:02:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A3EBC181AC9C6 for ; Tue, 26 May 2020 16:02:06 +0000 (UTC) X-FDA: 76859336652.01.pan13_86b649379a044 X-HE-Tag: pan13_86b649379a044 X-Filterd-Recvd-Size: 3714 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 May 2020 16:02:05 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id r16so862267qvm.6 for ; Tue, 26 May 2020 09:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RsZ3nQfGjW40v4ckRRp9241TQQ4YCE7GdfX8IPCvDyE=; b=AZvUVlJqEqbAPtDWEcV8xLSKNrSwwqm27o4j1nKpKyNIvP//3xF9TBUmSqeioWu+ox GgUtzLzzkJzvIbm87q0XvHko4QXlFaYxgKgfCZ53z4iBOhQnGqODmLbw626evo9klZtu c7PoTVabRQKKhf5nWGB1E7GcRx+eMZZcPz81NaE8FAVR20U3lqHBNcCpwjcPFS5ErJ+8 6XZEtI7fjLtnGewlpV2uHO14tWYN0wa4KnFXX+ibs43sGR8LaHz0R1Bm+9wCm93w5gpq u4epjiy5ZZpl+TZKm6frdFVstFQ04kgG6wE7yggabAskwiesK6ye0FxlnjiklEHIwV5l thfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RsZ3nQfGjW40v4ckRRp9241TQQ4YCE7GdfX8IPCvDyE=; b=KNO1Igq4ZcwUdNX89r+XxChcewtlurdDx//NHN8evk9dg08OFGbV0ZYIQXkU3pIVW8 1pj4ZBwb+mxEp4xUfb6pi59Jtv6yM5WTCDEwxuzE1Gn1WdacIoAHO/ONoIyPIzE6S2hR WSuGz3NgQV/UzhTfCA5/SsCx8yIEp/3gcWeKa+cazkB/b1UIfCKIB9lhVWPq38QPiJTW c9UpRbKX5oZQMl/EJ13rKUSusCDHMN3ryQsD+hRaG/+sHORRBguzYKoTYQOAxtNHEqD7 C79kYYUSm7Tas188mSW7ddGnu51hmM58kV6Gw6ilYAEQxlUDGKFVkpVR5m1p/anVhLBd RPjg== X-Gm-Message-State: AOAM533t2XpHQVimU5CrBvvU1O4TtnEM4HOeJxeSe3nF8hNyb+WqI6Oj E38oUePORIDOq2EZ3GvZd62RcA== X-Google-Smtp-Source: ABdhPJzhXcKDUYQ8+zI3NmJftxHzdTRDdvli5ewQjK6oPrSCn55dFt7LvsFzmcLbWioE/ZJdmqLuIA== X-Received: by 2002:a0c:b354:: with SMTP id a20mr20923201qvf.205.1590508924821; Tue, 26 May 2020 09:02:04 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:8152]) by smtp.gmail.com with ESMTPSA id q34sm58103qtd.89.2020.05.26.09.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 09:02:04 -0700 (PDT) Date: Tue, 26 May 2020 12:01:40 -0400 From: Johannes Weiner To: Hugh Dickins Cc: Andrew Morton , Song Liu , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm,thp: stop leaking unreleased file pages Message-ID: <20200526160140.GC850116@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 23, 2020 at 06:50:15PM -0700, Hugh Dickins wrote: > When collapse_file() calls try_to_release_page(), it has already > isolated the page: so if releasing buffers happens to fail (as it > sometimes does), remember to putback_lru_page(): otherwise that page is > left unreclaimable and unfreeable, and the file extent uncollapsible. Oof, I could imagine that was painful to debug (unless you already suspected file THP due to a targeted test or similar). Kudos. > Signed-off-by: Hugh Dickins > Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") > Cc: stable@vger.kernel.org # v5.4+ Acked-by: Johannes Weiner