From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F57C433E0 for ; Wed, 27 May 2020 08:03:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 215B220723 for ; Wed, 27 May 2020 08:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 215B220723 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 58B2A800B6; Wed, 27 May 2020 04:03:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5152E80010; Wed, 27 May 2020 04:03:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DD3A800B6; Wed, 27 May 2020 04:03:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id 2EE0180010 for ; Wed, 27 May 2020 04:03:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 034962476 for ; Wed, 27 May 2020 08:03:35 +0000 (UTC) X-FDA: 76861759590.27.cats25_3e0ff9526d50 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id D58243D663 for ; Wed, 27 May 2020 08:03:34 +0000 (UTC) X-HE-Tag: cats25_3e0ff9526d50 X-Filterd-Recvd-Size: 2854 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 08:03:34 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jdr1v-0007iQ-00; Wed, 27 May 2020 10:03:15 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 338BAC0458; Wed, 27 May 2020 09:10:46 +0200 (CEST) Date: Wed, 27 May 2020 09:10:46 +0200 From: Thomas Bogendoerfer To: maobibo Cc: Andrew Morton , Jiaxun Yang , Huacai Chen , Paul Burton , Dmitry Korotin , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Stafford Horne , Steven Price , Anshuman Khandual , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , Sergei Shtylyov , "Maciej W. Rozycki" , linux-mm@kvack.org, David Hildenbrand Subject: Re: [PATCH v6 3/4] mm/memory.c: Add memory read privilege on page fault handling Message-ID: <20200527071046.GA8600@alpha.franken.de> References: <1590375160-6997-1-git-send-email-maobibo@loongson.cn> <1590375160-6997-3-git-send-email-maobibo@loongson.cn> <20200525144413.8c13559ec87616aa2c77af41@linux-foundation.org> <4ca3c5b8-f695-c011-7e00-ef884a1c3d84@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ca3c5b8-f695-c011-7e00-ef884a1c3d84@loongson.cn> User-Agent: Mutt/1.5.23 (2014-03-12) X-Rspamd-Queue-Id: D58243D663 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 27, 2020 at 09:05:41AM +0800, maobibo wrote: > > > On 05/26/2020 05:44 AM, Andrew Morton wrote: > > On Mon, 25 May 2020 10:52:39 +0800 Bibo Mao wrote: > > > >> Here add pte_sw_mkyoung function to make page readable on MIPS > >> platform during page fault handling. This patch improves page > >> fault latency about 10% on my MIPS machine with lmbench > >> lat_pagefault case. > >> > >> It is noop function on other arches, there is no negative > >> influence on those architectures. > > > > Acked-by: Andrew Morton > > > > Should I take these, or would the mips tree be preferred? I'm OK > > either way, but probably the MIPS tree would be better? > Thanks for reviewing again and again. > This patch is based on mips-next, maybe MIPS tree will be better. I'll take your next version then. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]