From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68CF9C433E1 for ; Wed, 27 May 2020 20:46:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CE072084C for ; Wed, 27 May 2020 20:46:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NO0SQ8+G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CE072084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0EFC8001A; Wed, 27 May 2020 16:46:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBF7680010; Wed, 27 May 2020 16:46:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD6D08001A; Wed, 27 May 2020 16:46:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 96D6080010 for ; Wed, 27 May 2020 16:46:53 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8DFB77DC8E for ; Wed, 27 May 2020 20:46:52 +0000 (UTC) X-FDA: 76863683064.12.cause14_3bf65529ad62a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 6B7AF182BFD80 for ; Wed, 27 May 2020 20:46:52 +0000 (UTC) X-HE-Tag: cause14_3bf65529ad62a X-Filterd-Recvd-Size: 3097 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 20:46:51 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A40DF20835; Wed, 27 May 2020 20:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590612411; bh=WtewfCOjGK26oPHbewPKO/Ed9S5SuwHAhFqHb/iW9lI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NO0SQ8+GOeQNww2TBIOhZ3ZJW+IHvsP/vDuNS/adxh1+oPqQk5DDLFkJzMHP16SeD haki2yvy9WB+YElCIlr8hWG110jeYwuA0PmIYUQfa1umaWAdHakBpokJrnU+vrMiHN AqtAQIhm7u7Zu/mXSsJhv6nTrkx5Q5NqHu7d9k2g= Date: Wed, 27 May 2020 13:46:50 -0700 From: Andrew Morton To: Johannes Weiner Cc: Shakeel Butt , Mel Gorman , Roman Gushchin , Michal Hocko , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages Message-Id: <20200527134650.18b3fb3f0be85bb73037da20@linux-foundation.org> In-Reply-To: <20200527194148.GA47905@cmpxchg.org> References: <20200527182958.252402-1-shakeelb@google.com> <20200527194148.GA47905@cmpxchg.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6B7AF182BFD80 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 May 2020 15:41:48 -0400 Johannes Weiner wrote: > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > > From: Johannes Weiner > > > > Currently, THP are counted as single pages until they are split right > > before being swapped out. However, at that point the VM is already in > > the middle of reclaim, and adjusting the LRU balance then is useless. > > > > Always account THP by the number of basepages, and remove the fixup > > from the splitting path. > > > > Signed-off-by: Johannes Weiner > > Signed-off-by: Shakeel Butt > > This is now already in mm as part of the "mm: balance LRU lists based > on relative thrashing" series that I sent out last week and where it > was originally from. Yup. I hope [1/3] and [2/3] weren't urgent? Due to a horrid merge mismatchmishmashmess I've staged them behind lots of other things, notably thp/khugepaged improvements and CoW semantics http://lkml.kernel.org/r/20200416160026.16538-1-kirill.shutemov@linux.intel.com and mm: memcontrol: charge swapin pages on instantiation http://lkml.kernel.org/r/20200508183105.225460-1-hannes@cmpxchg.org and mm: balance LRU lists based on relative thrashing http://lkml.kernel.org/r/20200520232525.798933-1-hannes@cmpxchg.org