From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AF4C433E1 for ; Wed, 27 May 2020 16:03:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B64B120776 for ; Wed, 27 May 2020 16:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="FAkcrvKP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B64B120776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63728800B7; Wed, 27 May 2020 12:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E73A80010; Wed, 27 May 2020 12:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AE80800B7; Wed, 27 May 2020 12:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 319DA80010 for ; Wed, 27 May 2020 12:03:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EAB6BE6E9D for ; Wed, 27 May 2020 16:03:25 +0000 (UTC) X-FDA: 76862968770.21.leaf60_2c0afe026d53 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id E75311854A7FB for ; Wed, 27 May 2020 16:03:24 +0000 (UTC) X-HE-Tag: leaf60_2c0afe026d53 X-Filterd-Recvd-Size: 3929 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 16:03:24 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id g7so848549qvx.11 for ; Wed, 27 May 2020 09:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=S4XAF2qs5g4AY/r0EWrS8+9mLHbgcJOtXMG15PYfY1M=; b=FAkcrvKPhwXHPzhdsTR4NIhbFqwfLMvAV5bGTRBFGbczDHZC/aQDPVNA9PY7cGrlvI OAU7sMfEHvFrbqT7CvtkuJGTkLTQG5KPLvLc06tbn9wyvDUbjiyyqowgDNO9WndwvoJj X2dl1qZDNUOZqVESipiKNZd2Z60Nw52ZyxG0kUa5w+Kb9fsoxQn99KBAnvXQXuidqHXF g8B5P2fMOTarggI1cwoQW6OJquoa9Iej9VuFDR2ehmtvCwzE99l5fAoHQpqyCpeiAEEr Af1ivrgSbwVp3LHhcKFdtzo1qHJKVNeAaLsKpBMc9QZNWJkGiTDvSPU22BKqJthweSfF Xblw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S4XAF2qs5g4AY/r0EWrS8+9mLHbgcJOtXMG15PYfY1M=; b=AYP/SmLnL4H719Uxa3PH+TllEVr/JZd5No+7riiqMHQud73DjnKrRb1Bgb/4Lb8cKE Q/3vSo4j24dCTjz7z1zBMO4+0qRbn4rlnxSaj2YTV+ybCb9jKj++Vt6vrlBmlJl1qL9+ mDPqDB4pIZCyUxUflzNmOCN4nzaqfNuuIoWsWIuOXxLHYrSB43nXjGauScGtcp4HAtf/ 7xgUDmPD8IoGzsacV4fO01I6s32WeYVgcHmTWB3mKpt0RS5MPo6HhZvj0GXrRKt0KZPu e2pjlIVEwZjSE6sdhSwm/yJWQ6/UZtFu84RkVdERKQRXerUuQEQKcVQgBrY0U72n1VBN /7yg== X-Gm-Message-State: AOAM530WOxIkgz1FyBx9R+TR1C95IaOEcICTbP2jMy8RpQoUXspvSCJI EcFRZYRKefmRWfARFHgfuHpkLA== X-Google-Smtp-Source: ABdhPJyGGNRt6GbiZDvAAJR7JhnDFJNuzQwWePJEhdbGDeVQFHSsv2y//UkvfCBcqxVwmEGqiS8tHA== X-Received: by 2002:a0c:f486:: with SMTP id i6mr24701658qvm.190.1590595402656; Wed, 27 May 2020 09:03:22 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:2535]) by smtp.gmail.com with ESMTPSA id g66sm2485148qkb.122.2020.05.27.09.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 09:03:22 -0700 (PDT) Date: Wed, 27 May 2020 12:02:57 -0400 From: Johannes Weiner To: Jens Axboe Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH 04/12] mm: add support for async page locking Message-ID: <20200527160257.GB42293@cmpxchg.org> References: <20200526195123.29053-1-axboe@kernel.dk> <20200526195123.29053-5-axboe@kernel.dk> <20200526215925.GC6781@cmpxchg.org> <152529a5-adb4-fd7b-52ac-967500c011c9@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152529a5-adb4-fd7b-52ac-967500c011c9@kernel.dk> X-Rspamd-Queue-Id: E75311854A7FB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 26, 2020 at 04:01:07PM -0600, Jens Axboe wrote: > On 5/26/20 3:59 PM, Johannes Weiner wrote: > > On Tue, May 26, 2020 at 01:51:15PM -0600, Jens Axboe wrote: > >> Normally waiting for a page to become unlocked, or locking the page, > >> requires waiting for IO to complete. Add support for lock_page_async() > >> and wait_on_page_locked_async(), which are callback based instead. This > > > > wait_on_page_locked_async() is actually in the next patch, requiring > > some back and forth to review. I wonder if this and the next patch > > could be merged to have the new API and callers introduced together? > > I'm fine with that, if that is preferable. Don't feel strongly about > that at all, just tried to do it as piecemeal as possible to make > it easier to review. Not worth sending a new iteration over, IMO.