From: Johannes Weiner <hannes@cmpxchg.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: Mel Gorman <mgorman@suse.de>, Roman Gushchin <guro@fb.com>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@surriel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages
Date: Wed, 27 May 2020 15:41:48 -0400 [thread overview]
Message-ID: <20200527194148.GA47905@cmpxchg.org> (raw)
In-Reply-To: <20200527182958.252402-1-shakeelb@google.com>
On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote:
> From: Johannes Weiner <hannes@cmpxchg.org>
>
> Currently, THP are counted as single pages until they are split right
> before being swapped out. However, at that point the VM is already in
> the middle of reclaim, and adjusting the LRU balance then is useless.
>
> Always account THP by the number of basepages, and remove the fixup
> from the splitting path.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
This is now already in mm as part of the "mm: balance LRU lists based
on relative thrashing" series that I sent out last week and where it
was originally from.
next prev parent reply other threads:[~2020-05-27 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 18:29 [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages Shakeel Butt
2020-05-27 19:41 ` Johannes Weiner [this message]
2020-05-27 19:46 ` Shakeel Butt
2020-05-27 20:46 ` Andrew Morton
2020-05-27 21:35 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527194148.GA47905@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=riel@surriel.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).