From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D167C433E0 for ; Thu, 28 May 2020 05:20:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0EC06214D8 for ; Thu, 28 May 2020 05:20:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dc2rjKUP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EC06214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ADADF800BA; Thu, 28 May 2020 01:20:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A640480010; Thu, 28 May 2020 01:20:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99F15800BA; Thu, 28 May 2020 01:20:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 8181A80010 for ; Thu, 28 May 2020 01:20:57 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 48ABF824556B for ; Thu, 28 May 2020 05:20:57 +0000 (UTC) X-FDA: 76864978554.16.mint18_25627b8b3885b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 2D5E5100E6903 for ; Thu, 28 May 2020 05:20:57 +0000 (UTC) X-HE-Tag: mint18_25627b8b3885b X-Filterd-Recvd-Size: 3124 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 May 2020 05:20:56 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D207021475; Thu, 28 May 2020 05:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590643256; bh=DcdeEt7izu+ERwD3T5Fr1gSIWkt8XYvUZM2fQw48jHY=; h=Date:From:To:Subject:In-Reply-To:From; b=dc2rjKUPn+tjPtvOf+F25C4m+T5LUxQZIQCX7E4phK75ionZOpHltZUfbH3PPVsyk IvEeBw5dBv30TnNOMQxTrpRN7N2oP3aHuUwtU6HHvr9OQelv/VboHxo0G981Vxrhoj y98BXhnI3zRPGcCzvafBlSl6fG7T5dpUNW5X3Hgg= Date: Wed, 27 May 2020 22:20:55 -0700 From: Andrew Morton To: akpm@linux-foundation.org, arnd@arndb.de, linux-mm@kvack.org, linux@roeck-us.net, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 5/5] include/asm-generic/topology.h: guard cpumask_of_node() macro argument Message-ID: <20200528052055.nbIbqxl2c%akpm@linux-foundation.org> In-Reply-To: <20200527222015.62ba8592af63dae12ab58ffe@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: 2D5E5100E6903 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann Subject: include/asm-generic/topology.h: guard cpumask_of_node() macro argument drivers/hwmon/amd_energy.c:195:15: error: invalid operands to binary expression ('void' and 'int') (channel - data->nr_cpus)); ~~~~~~~~~^~~~~~~~~~~~~~~~~ include/asm-generic/topology.h:51:42: note: expanded from macro 'cpumask_of_node' #define cpumask_of_node(node) ((void)node, cpu_online_mask) ^~~~ include/linux/cpumask.h:618:72: note: expanded from macro 'cpumask_first_and' #define cpumask_first_and(src1p, src2p) cpumask_next_and(-1, (src1p), (src2p)) ^~~~~ Link: http://lkml.kernel.org/r/20200527134623.930247-1-arnd@arndb.de Fixes: f0b848ce6fe9 ("cpumask: Introduce cpumask_of_{node,pcibus} to replace {node,pcibus}_to_cpumask") Fixes: 8abee9566b7e ("hwmon: Add amd_energy driver to report energy counters") Signed-off-by: Arnd Bergmann Acked-by: Guenter Roeck Signed-off-by: Andrew Morton --- include/asm-generic/topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/asm-generic/topology.h~cpumask-guard-cpumask_of_node-macro-argument +++ a/include/asm-generic/topology.h @@ -48,7 +48,7 @@ #ifdef CONFIG_NEED_MULTIPLE_NODES #define cpumask_of_node(node) ((node) == 0 ? cpu_online_mask : cpu_none_mask) #else - #define cpumask_of_node(node) ((void)node, cpu_online_mask) + #define cpumask_of_node(node) ((void)(node), cpu_online_mask) #endif #endif #ifndef pcibus_to_node _