From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE723C433DF for ; Thu, 28 May 2020 14:44:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 959E420814 for ; Thu, 28 May 2020 14:44:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 959E420814 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A1788001A; Thu, 28 May 2020 10:44:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1526080010; Thu, 28 May 2020 10:44:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 067C28001A; Thu, 28 May 2020 10:44:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id E3C4E80010 for ; Thu, 28 May 2020 10:44:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 976FFAF8A for ; Thu, 28 May 2020 14:44:15 +0000 (UTC) X-FDA: 76866398070.22.horse19_8065c8272727 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 5CF5A1802972B for ; Thu, 28 May 2020 14:44:15 +0000 (UTC) X-HE-Tag: horse19_8065c8272727 X-Filterd-Recvd-Size: 3951 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 May 2020 14:44:15 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id r15so3442241wmh.5 for ; Thu, 28 May 2020 07:44:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d5CG+dZkizz2gd8XiI325VVyArlyR5Hw+X1ko//Nh1s=; b=jVrqm2qxDZfUscdM/zdOpuQzQ2jGHLW+8zJsit9CzgKbVj4SQUfwlZvH7JCcGvoj8A 2l8qlTE89z1XMx+QsTxzMHA2jfSo+psWmd6cEIxu6rMYELYIMvDo20ZQbtRqzxcBMoLd qJiXpd6wnIodFIoQO2Km9/5Mkklz7Zf37PUhbXozdjoYE35foSu9vDrG1E+43//lgkTx tuAoJ3EG4kIfso6UNognzwoENQoikwCchQS7+8u7II1a+FW00YIkAvNFxpsgrdPQ/wsp 191fw664+T4LcbCXDLrc0lZMcyaJWBhVPPc7fZZbdQJdcz8t9KKZk+KrbvnovNMm0Szd jFww== X-Gm-Message-State: AOAM530ZPYt0/hf4MM92JvQ1q5gyKci7ZIhmOl+EWi0uDDbSeLnJGJLy uq2yQDGOd866aY9aHTV5/iE= X-Google-Smtp-Source: ABdhPJzmRJnwJPbIosz6Q7UNmwC1yBhbcmyboMCn2GR+vzfNInCeARHRg7d/ZCmhsoSoGd7gjwUK/g== X-Received: by 2002:a1c:2cd7:: with SMTP id s206mr3564565wms.109.1590677053923; Thu, 28 May 2020 07:44:13 -0700 (PDT) Received: from localhost (ip-37-188-185-40.eurotel.cz. [37.188.185.40]) by smtp.gmail.com with ESMTPSA id a10sm6398675wmf.46.2020.05.28.07.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 07:44:12 -0700 (PDT) Date: Thu, 28 May 2020 16:44:10 +0200 From: Michal Hocko To: Zefan Li Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , Cgroups , linux-mm@kvack.org, Roman Gushchin , Shakeel Butt Subject: Re: [PATCH v3] memcg: Fix memcg_kmem_bypass() for remote memcg charging Message-ID: <20200528144410.GE27484@dhcp22.suse.cz> References: <20200513090502.GV29153@dhcp22.suse.cz> <76f71776-d049-7407-8574-86b6e9d80704@huawei.com> <20200513112905.GX29153@dhcp22.suse.cz> <1d202a12-26fe-0012-ea14-f025ddcd044a@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d202a12-26fe-0012-ea14-f025ddcd044a@huawei.com> X-Rspamd-Queue-Id: 5CF5A1802972B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 26-05-20 09:25:25, Li Zefan wrote: > While trying to use remote memcg charging in an out-of-tree kernel module > I found it's not working, because the current thread is a workqueue thread. > > As we will probably encounter this issue in the future as the users of > memalloc_use_memcg() grow, and it's nothing wrong for this usage, it's > better we fix it now. > > Acked-by: Johannes Weiner > Signed-off-by: Zefan Li Acked-by: Michal Hocko > --- > > v3: bypass __GFP_ACCOUNT allocations in interrupt contexts. > > --- > mm/memcontrol.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index a3b97f1..3c7717a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2802,7 +2802,12 @@ static void memcg_schedule_kmem_cache_create(struct mem_cgroup *memcg, > > static inline bool memcg_kmem_bypass(void) > { > - if (in_interrupt() || !current->mm || (current->flags & PF_KTHREAD)) > + if (in_interrupt()) > + return true; > + > + /* Allow remote memcg charging in kthread contexts. */ > + if ((!current->mm || (current->flags & PF_KTHREAD)) && > + !current->active_memcg) > return true; > return false; > } > -- > 2.7.4 -- Michal Hocko SUSE Labs