From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E95C433DF for ; Tue, 9 Jun 2020 12:43:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8AB8B207C3 for ; Tue, 9 Jun 2020 12:43:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AB8B207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 184DA6B0002; Tue, 9 Jun 2020 08:43:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 110096B0005; Tue, 9 Jun 2020 08:43:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F182E6B0006; Tue, 9 Jun 2020 08:43:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id D6EF26B0002 for ; Tue, 9 Jun 2020 08:43:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 805108015357 for ; Tue, 9 Jun 2020 12:43:48 +0000 (UTC) X-FDA: 76909640136.13.idea28_090395e26dc2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 535BC18140B8A for ; Tue, 9 Jun 2020 12:43:48 +0000 (UTC) X-HE-Tag: idea28_090395e26dc2 X-Filterd-Recvd-Size: 3612 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Jun 2020 12:43:47 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id dr13so3003490ejc.3 for ; Tue, 09 Jun 2020 05:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t3GQNmWtf4ksIggwptv0txsHLVgsuiaz0p09us+yUC0=; b=bYqAhc7LU5KyTQt6Nmk3Y+YNFEueKFhKZ3kM5IhET6qD7mc0hCcK3FArmMy7YIu9KJ gmRBIDrLN7o/p/AZUkGjP9B1t4tts2rTzKVQUdz5BfsEIakiy6Da0zUDOzZI2pk836lq iQbFxL8Yh/XYCQ17AAznPgw/Y9HZENJP8khr9yHirwHxpDl6u3WeKI9aUF5ZknqUbl+E qnX+vI+6nb26SjkiSljiz54dWcUzXbCSLLu8Xv9ohycamdjlZuder8+tUvjrdOrHTGYz B0/7ob4VeMwmfYIJtabdv4nlmUoN0wG69vs6IeFPNDe44npvcN5c3MtouXsPTMjENiNx om1Q== X-Gm-Message-State: AOAM530KYxhTNqHgeA6XKyc+t4QEvKmRTXtVzJESOgJv5/GcSavtB/oq FRqoMcpVf5CY1tDRAwqXy/I= X-Google-Smtp-Source: ABdhPJzrhhabnTeUtVY91t7kfFr3pxKvQaWZW7X9nXWAtIKEyVK75iUHEyP3Zo7mM/2HyIVcn8BNOA== X-Received: by 2002:a17:906:7c5a:: with SMTP id g26mr25499817ejp.200.1591706626955; Tue, 09 Jun 2020 05:43:46 -0700 (PDT) Received: from localhost (ip-37-188-174-195.eurotel.cz. [37.188.174.195]) by smtp.gmail.com with ESMTPSA id k23sm954411ejk.114.2020.06.09.05.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 05:43:45 -0700 (PDT) Date: Tue, 9 Jun 2020 14:43:44 +0200 From: Michal Hocko To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Subject: Re: [PATCH v2 01/12] mm/page_isolation: prefer the node of the source page Message-ID: <20200609124344.GC22623@dhcp22.suse.cz> References: <1590561903-13186-1-git-send-email-iamjoonsoo.kim@lge.com> <1590561903-13186-2-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1590561903-13186-2-git-send-email-iamjoonsoo.kim@lge.com> X-Rspamd-Queue-Id: 535BC18140B8A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 27-05-20 15:44:52, Joonsoo Kim wrote: > From: Joonsoo Kim > > For locality, it's better to migrate the page to the same node > rather than the node of the current caller's cpu. > > Acked-by: Roman Gushchin > Signed-off-by: Joonsoo Kim Acked-by: Michal Hocko > --- > mm/page_isolation.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 2c11a38..7df89bd 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -300,5 +300,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, > > struct page *alloc_migrate_target(struct page *page, unsigned long private) > { > - return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]); > + int nid = page_to_nid(page); > + > + return new_page_nodemask(page, nid, &node_states[N_MEMORY]); > } > -- > 2.7.4 -- Michal Hocko SUSE Labs