From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B2DC433E0 for ; Tue, 9 Jun 2020 13:27:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 02ECE2078D for ; Tue, 9 Jun 2020 13:27:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02ECE2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 93E696B0008; Tue, 9 Jun 2020 09:27:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 914206B000A; Tue, 9 Jun 2020 09:27:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 851B66B000C; Tue, 9 Jun 2020 09:27:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 6BE206B0008 for ; Tue, 9 Jun 2020 09:27:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 24FBE181B04B5 for ; Tue, 9 Jun 2020 13:27:09 +0000 (UTC) X-FDA: 76909749378.22.dog89_580c62226dc2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 8076318038E72 for ; Tue, 9 Jun 2020 13:26:32 +0000 (UTC) X-HE-Tag: dog89_580c62226dc2 X-Filterd-Recvd-Size: 3983 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Jun 2020 13:26:32 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id x93so16318036ede.9 for ; Tue, 09 Jun 2020 06:26:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=duYAHWPnEvooNTZ1VvjKgdBmlQUETGmu9dtBpelWVLQ=; b=WJs5zQHHdKlspzeGIA/Ta9+l48/Izfe71cRqI43GRR/u04WJezbSVKAbDYOCIybly7 //yJZpKUUfxV48a9AFfeMqfr1YfST1m9RN6aGBauAG2TmABv4QG9QoaoTUzgamU5HW7Z qhBIaUrd+fwavkD0pDlx4sA9eiABZhK8EtJMa26OgIgecbFjDEkpgoFh5uvgmvDslrRK 9dwNbiO9H4z0lAf4vKn1sxhVuUIRxXSBxzcnPFTpUk/T+SuzA1VwN3FnSqRa09BLcJ8r h2Jt+AP8lrr34Ra2/C1/oqQ/Hss5EVH4Rgoq7yIoGvT+4UaG0JDbYqZnSykPDquuYEce ivBA== X-Gm-Message-State: AOAM530vlOFJs4B5twl38Y4HnsqurlwCjSntALcOCiXFe0W4FTqpDbdN HRlWjB2Up9tdWjmoUDg1XcM= X-Google-Smtp-Source: ABdhPJwKZsdBUo7eIe9utwaZGbva4Y1XIQJsy0fQUCKprAIkQCxVi5jRVVgYBe67gwNiqtl6dJZCjg== X-Received: by 2002:a50:fd19:: with SMTP id i25mr26529489eds.248.1591709191061; Tue, 09 Jun 2020 06:26:31 -0700 (PDT) Received: from localhost (ip-37-188-174-195.eurotel.cz. [37.188.174.195]) by smtp.gmail.com with ESMTPSA id z15sm13602811ejw.8.2020.06.09.06.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 06:26:30 -0700 (PDT) Date: Tue, 9 Jun 2020 15:26:29 +0200 From: Michal Hocko To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Subject: Re: [PATCH v2 04/12] mm/hugetlb: use provided ac->gfp_mask for allocation Message-ID: <20200609132629.GF22623@dhcp22.suse.cz> References: <1590561903-13186-1-git-send-email-iamjoonsoo.kim@lge.com> <1590561903-13186-5-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1590561903-13186-5-git-send-email-iamjoonsoo.kim@lge.com> X-Rspamd-Queue-Id: 8076318038E72 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 27-05-20 15:44:55, Joonsoo Kim wrote: > From: Joonsoo Kim > > gfp_mask handling on alloc_huge_page_(node|nodemask) is > slightly changed, from ASSIGN to OR. It's safe since caller of these > functions doesn't pass extra gfp_mask except htlb_alloc_mask(). > > This is a preparation step for following patches. This patch on its own doesn't make much sense to me. Should it be folded in the patch which uses that? > Signed-off-by: Joonsoo Kim > --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 453ba94..dabe460 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1985,7 +1985,7 @@ struct page *alloc_huge_page_node(struct hstate *h, > { > struct page *page = NULL; > > - ac->gfp_mask = htlb_alloc_mask(h); > + ac->gfp_mask |= htlb_alloc_mask(h); > if (ac->nid != NUMA_NO_NODE) > ac->gfp_mask |= __GFP_THISNODE; > > @@ -2004,7 +2004,7 @@ struct page *alloc_huge_page_node(struct hstate *h, > struct page *alloc_huge_page_nodemask(struct hstate *h, > struct alloc_control *ac) > { > - ac->gfp_mask = htlb_alloc_mask(h); > + ac->gfp_mask |= htlb_alloc_mask(h); > > spin_lock(&hugetlb_lock); > if (h->free_huge_pages - h->resv_huge_pages > 0) { > -- > 2.7.4 > -- Michal Hocko SUSE Labs