From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35382C433DF for ; Thu, 23 Jul 2020 10:19:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 001AF2065F for ; Thu, 23 Jul 2020 10:19:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 001AF2065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A15AD6B0005; Thu, 23 Jul 2020 06:19:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C63F6B0006; Thu, 23 Jul 2020 06:19:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DC256B0007; Thu, 23 Jul 2020 06:19:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 792F36B0005 for ; Thu, 23 Jul 2020 06:19:52 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3BE27E4BC0 for ; Thu, 23 Jul 2020 10:19:52 +0000 (UTC) X-FDA: 77068944624.21.mint47_3907c7e26f3d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 16670180442C4 for ; Thu, 23 Jul 2020 10:19:52 +0000 (UTC) X-HE-Tag: mint47_3907c7e26f3d X-Filterd-Recvd-Size: 2212 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Jul 2020 10:19:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 38A75ACDF; Thu, 23 Jul 2020 10:19:58 +0000 (UTC) Date: Thu, 23 Jul 2020 12:19:47 +0200 From: Oscar Salvador To: HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+j44CA55u05LmfKQ==?= Cc: akpm@linux-foundation.org, Michal Hocko , linux-mm@kvack.org, mike.kravetz@oracle.com, david@redhat.com, aneesh.kumar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, Oscar Salvador Subject: Re: [PATCH v4 12/15] mm,hwpoison: Rework soft offline for in-use pages Message-ID: <20200723101942.GA19826@linux> References: <20200716123810.25292-1-osalvador@suse.de> <20200716123810.25292-13-osalvador@suse.de> <3b2231bf69133bb7bb8936c74b4e9c9f@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b2231bf69133bb7bb8936c74b4e9c9f@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 16670180442C4 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 22, 2020 at 10:08:59AM +0200, osalvador@suse.de wrote: > On 2020-07-20 10:27, osalvador@suse.de wrote: > > > This means that some hugepages are dissolved, but the others not, > > > maybe which is not desirable. > > > I'll dig this more later but just let me share at first. > > > > > > A few minor comment below ... > > > > > > Uhm, weird. > > > > I will be taking a look today. > > After some digging up I __think__ I found the problem. > I will try to fix it up and I will be running tests. I found the problem. I re-ran the tests again with small and large memory and the stats look correct this time. After some more testing, I also fixed a list corruption that was happening due to the same problem. I am creating a git branch so you can re-run your tests on it as well. -- Oscar Salvador SUSE L3