From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0067C43461 for ; Tue, 15 Sep 2020 07:41:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F1CA21D1B for ; Tue, 15 Sep 2020 07:41:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="OFD9dxLB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F1CA21D1B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A90A4900029; Tue, 15 Sep 2020 03:41:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CC9A90001D; Tue, 15 Sep 2020 03:41:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86E54900029; Tue, 15 Sep 2020 03:41:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 6822790001D for ; Tue, 15 Sep 2020 03:41:06 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 24FDF1E09 for ; Tue, 15 Sep 2020 07:41:06 +0000 (UTC) X-FDA: 77264499732.29.screw86_0b0bfcc2710f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id E7554180868E3 for ; Tue, 15 Sep 2020 07:41:05 +0000 (UTC) X-HE-Tag: screw86_0b0bfcc2710f X-Filterd-Recvd-Size: 3025 Received: from smtp-fw-9101.amazon.com (smtp-fw-9101.amazon.com [207.171.184.25]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 07:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1600155666; x=1631691666; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=8vYKHYEY7YWUiFcM9tp7k2LE6G8tu9bx7TFoqAR61bM=; b=OFD9dxLBHVMrUh+zwHzqTfLkCOxqi5DzSIgLCSTl1gprRNHBc6BgUGgM Lc5ALRAr+yUF1fvmOTpz36WHRNk0Wzh/NbqCDSIoKM2fty2jCFvTQo19/ EUhjOUXVATATaw+hRjBgmV1SMWKBeXpmf0Yjyjy9y5RLdqcuhQmCPQEuu o=; X-IronPort-AV: E=Sophos;i="5.76,429,1592870400"; d="scan'208";a="68047920" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9101.sea19.amazon.com with ESMTP; 15 Sep 2020 07:41:04 +0000 Received: from EX13D31EUA004.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com (Postfix) with ESMTPS id 376A4A2532; Tue, 15 Sep 2020 07:41:02 +0000 (UTC) Received: from u3f2cd687b01c55.ant.amazon.com (10.43.161.34) by EX13D31EUA004.ant.amazon.com (10.43.165.161) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Sep 2020 07:40:58 +0000 From: SeongJae Park To: "Matthew Wilcox (Oracle)" CC: , Andrew Morton , "Kirill A . Shutemov" , Huang Ying Subject: Re: [PATCH 11/11] mm/vmscan: Allow arbitrary sized pages to be paged out Date: Tue, 15 Sep 2020 09:40:45 +0200 Message-ID: <20200915074045.17570-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200908195539.25896-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.161.34] X-ClientProxiedBy: EX13D43UWC004.ant.amazon.com (10.43.162.42) To EX13D31EUA004.ant.amazon.com (10.43.165.161) X-Rspamd-Queue-Id: E7554180868E3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 8 Sep 2020 20:55:38 +0100 "Matthew Wilcox (Oracle)" wrote: > Remove the assumption that a compound page has HPAGE_PMD_NR pins from > the page cache. > > Signed-off-by: Matthew Wilcox (Oracle) > Cc: Huang Ying > --- > mm/vmscan.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 99e1796eb833..91b787fff71a 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -722,8 +722,7 @@ static inline int is_page_cache_freeable(struct page *page) > * that isolated the page, the page cache and optional buffer > * heads at page->private. > */ > - int page_cache_pins = PageTransHuge(page) && PageSwapCache(page) ? > - HPAGE_PMD_NR : 1; > + int page_cache_pins = thp_nr_pages(page); Is it ok to remove the PageSwapCache() check? Thanks, SeongJae Park