From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8122BC433E2 for ; Wed, 16 Sep 2020 06:10:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0586221D7D for ; Wed, 16 Sep 2020 06:10:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="JZyJvMh9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0586221D7D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 76BCF6B0037; Wed, 16 Sep 2020 02:10:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7416A6B0055; Wed, 16 Sep 2020 02:10:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 657E56B005A; Wed, 16 Sep 2020 02:10:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 507FB6B0037 for ; Wed, 16 Sep 2020 02:10:15 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 11673180AD807 for ; Wed, 16 Sep 2020 06:10:15 +0000 (UTC) X-FDA: 77267899590.17.spade07_5015f3e27117 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id D0D2F180D0181 for ; Wed, 16 Sep 2020 06:10:14 +0000 (UTC) X-HE-Tag: spade07_5015f3e27117 X-Filterd-Recvd-Size: 3445 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 06:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1600236614; x=1631772614; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=09ON+YclDgvPxAMmY+4k/8rk1yeK8j17tY/MErb1Sfo=; b=JZyJvMh9CT87Y1Y+M0ownPjlPBExmRn2ocVy6Fc42cRRiqFxqzFVLJcn C++bGr9oxbpJW5nIaZF1V0cq47L7SP+2lPgp06WzMtqJXh3Zmz8sZY8NM 5a8wb+S+L+FcBAcoVe63gRRF5XVTYpssNcFKLy23iXjTYM5jmov85n3x8 c=; X-IronPort-AV: E=Sophos;i="5.76,431,1592870400"; d="scan'208";a="54249386" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1e-17c49630.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 16 Sep 2020 06:10:13 +0000 Received: from EX13D31EUA004.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-1e-17c49630.us-east-1.amazon.com (Postfix) with ESMTPS id B496AA1C0A; Wed, 16 Sep 2020 06:10:12 +0000 (UTC) Received: from u3f2cd687b01c55.ant.amazon.com (10.43.161.71) by EX13D31EUA004.ant.amazon.com (10.43.165.161) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Sep 2020 06:10:09 +0000 From: SeongJae Park To: "Huang, Ying" CC: Matthew Wilcox , SeongJae Park , , Andrew Morton , "Kirill A . Shutemov" Subject: Re: [PATCH 11/11] mm/vmscan: Allow arbitrary sized pages to be paged out Date: Wed, 16 Sep 2020 08:09:51 +0200 Message-ID: <20200916060951.31023-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <87363its79.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.161.71] X-ClientProxiedBy: EX13D25UWB002.ant.amazon.com (10.43.161.44) To EX13D31EUA004.ant.amazon.com (10.43.165.161) X-Rspamd-Queue-Id: D0D2F180D0181 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 16 Sep 2020 09:40:10 +0800 "Huang\, Ying" wrote: > Matthew Wilcox writes: > > > On Tue, Sep 15, 2020 at 09:40:45AM +0200, SeongJae Park wrote: > >> On Tue, 8 Sep 2020 20:55:38 +0100 "Matthew Wilcox (Oracle)" wrote: > >> > Remove the assumption that a compound page has HPAGE_PMD_NR pins from > >> > the page cache. > >> > > >> > Signed-off-by: Matthew Wilcox (Oracle) > >> > Cc: Huang Ying > > > >> > - int page_cache_pins = PageTransHuge(page) && PageSwapCache(page) ? > >> > - HPAGE_PMD_NR : 1; > >> > + int page_cache_pins = thp_nr_pages(page); > >> > >> Is it ok to remove the PageSwapCache() check? > > > > I think so? My understanding is that it was added in commit bd4c82c22c36 > > to catch shmem pages, but there was really no reason to only do this for > > shmem pages. > > The original implementation is to write out Anonymous THP (not shmem). > The code should work after the changing, because now any THP except > normal Anonymous THP in swap cache will be split during reclaiming > already. Thanks for the kind explanation :) > > Acked-by: "Huang, Ying" Reviewed-by: SeongJae Park Thanks, SeongJae Park