From: Hui Su <sh_def@163.com>
To: lizefan@huawei.com, tj@kernel.org, hannes@cmpxchg.org,
akpm@linux-foundation.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c
Date: Sat, 26 Sep 2020 00:06:50 +0800 [thread overview]
Message-ID: <20200925160650.GA42847@rlk> (raw)
1. the cpuset.c has been moved from kernel/cpuset.c to
kernel/cgroup/cpuset.c long time ago, but the comment is stale,
so we update it.
2. get_page_from_freelist() may alloc many pages according to
order, we may use pages for better.
Signed-off-by: Hui Su <sh_def@163.com>
---
kernel/cgroup/cpuset.c | 2 +-
mm/mempolicy.c | 2 +-
mm/page_alloc.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 642415b8c3c9..1d3011c1aab6 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -1,5 +1,5 @@
/*
- * kernel/cpuset.c
+ * kernel/cgroup/cpuset.c
*
* Processor and Memory placement constraints for sets of tasks.
*
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index eddbe4e56c73..ac59b049b16c 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -2295,7 +2295,7 @@ int vma_dup_policy(struct vm_area_struct *src, struct vm_area_struct *dst)
* rebinds the mempolicy its copying by calling mpol_rebind_policy()
* with the mems_allowed returned by cpuset_mems_allowed(). This
* keeps mempolicies cpuset relative after its cpuset moves. See
- * further kernel/cpuset.c update_nodemask().
+ * further kernel/cgroup/cpuset.c update_nodemask().
*
* current's mempolicy may be rebinded by the other task(the task that changes
* cpuset's mems), so we needn't do rebind work for current task.
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index fab5e97dc9ca..1e3c7493e1cb 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3709,7 +3709,7 @@ static inline unsigned int current_alloc_flags(gfp_t gfp_mask,
/*
* get_page_from_freelist goes through the zonelist trying to allocate
- * a page.
+ * pages.
*/
static struct page *
get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
@@ -3723,7 +3723,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
retry:
/*
* Scan zonelist, looking for a zone with enough free.
- * See also __cpuset_node_allowed() comment in kernel/cpuset.c.
+ * See also __cpuset_node_allowed() comment in kernel/cgroup/cpuset.c.
*/
no_fallback = alloc_flags & ALLOC_NOFRAGMENT;
z = ac->preferred_zoneref;
--
2.25.1
next reply other threads:[~2020-09-25 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 16:06 Hui Su [this message]
2020-10-01 12:27 ` [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c David Hildenbrand
2020-10-01 16:17 ` Joe Perches
2020-10-08 12:33 ` Hui Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925160650.GA42847@rlk \
--to=sh_def@163.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).