From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30269C43457 for ; Fri, 9 Oct 2020 10:57:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 66E0B222C4 for ; Fri, 9 Oct 2020 10:57:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LDySZdo8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66E0B222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A9CE96B005D; Fri, 9 Oct 2020 06:57:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4CE96B006C; Fri, 9 Oct 2020 06:57:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91649900002; Fri, 9 Oct 2020 06:57:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 65FFE6B005D for ; Fri, 9 Oct 2020 06:57:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F34C0181AE869 for ; Fri, 9 Oct 2020 10:57:19 +0000 (UTC) X-FDA: 77352085398.04.horse83_3415eed271e0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id D428A8008410 for ; Fri, 9 Oct 2020 10:57:19 +0000 (UTC) X-HE-Tag: horse83_3415eed271e0 X-Filterd-Recvd-Size: 4394 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Fri, 9 Oct 2020 10:57:19 +0000 (UTC) Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B50922277; Fri, 9 Oct 2020 10:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602241038; bh=kHOFqclHrdBBz1Ryt/WeaTaY4X02dr3AcOscUBLI+pU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LDySZdo8ogOvvFAvfoOvwcvjxWeR1WwNSfI9D3bnjZKGkyyun/LM2tvFaBCG2rEo6 nVoZ0deBG7KOCK5o+s/18boeFzFxdFlCSaBF1AkNBr4eEngIikwngVuVjouAM14YHd XY8m3BRogYTEIV0Cm2EMOXkh5ALWcoubP/dOjosw= Date: Fri, 9 Oct 2020 12:58:03 +0200 From: Greg Kroah-Hartman To: Daniel Vetter Cc: DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Vetter , Jason Gunthorpe , Kees Cook , Dan Williams , Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , Jan Kara , Bjorn Helgaas , linux-pci@vger.kernel.org, "Rafael J. Wysocki" , Christian Brauner , "David S. Miller" , Michael Ellerman , Sourabh Jain , Mauro Carvalho Chehab , Nayna Jain Subject: Re: [PATCH v2 15/17] sysfs: Support zapping of binary attr mmaps Message-ID: <20201009105803.GA505688@kroah.com> References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-16-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20201009075934.3509076-16-daniel.vetter@ffwll.ch> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 09, 2020 at 09:59:32AM +0200, Daniel Vetter wrote: > We want to be able to revoke pci mmaps so that the same access rules > applies as for /dev/kmem. Revoke support for devmem was added in > 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims the > region"). >=20 > The simplest way to achieve this is by having the same filp->f_mapping > for all mappings, so that unmap_mapping_range can find them all, no > matter through which file they've been created. Since this must be set > at open time we need sysfs support for this. >=20 > Add an optional mapping parameter bin_attr, which is only consulted > when there's also an mmap callback, since without mmap support > allowing to adjust the ->f_mapping makes no sense. >=20 > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Kees Cook > Cc: Dan Williams > Cc: Andrew Morton > Cc: John Hubbard > Cc: J=E9r=F4me Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc: linux-mm@kvack.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Christian Brauner > Cc: "David S. Miller" > Cc: Michael Ellerman > Cc: Sourabh Jain > Cc: Daniel Vetter > Cc: Mauro Carvalho Chehab > Cc: Nayna Jain > --- > fs/sysfs/file.c | 11 +++++++++++ > include/linux/sysfs.h | 2 ++ > 2 files changed, 13 insertions(+) Reviewed-by: Greg Kroah-Hartman