From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81478C2D0A3 for ; Fri, 6 Nov 2020 18:24:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E4155208FE for ; Fri, 6 Nov 2020 18:24:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4155208FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3C6EF6B005D; Fri, 6 Nov 2020 13:24:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3777A6B0068; Fri, 6 Nov 2020 13:24:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 218B86B006C; Fri, 6 Nov 2020 13:24:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id E82B96B005D for ; Fri, 6 Nov 2020 13:24:13 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7D8E63629 for ; Fri, 6 Nov 2020 18:24:13 +0000 (UTC) X-FDA: 77454817986.02.grain93_070c987272d4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 6107310097AA3 for ; Fri, 6 Nov 2020 18:24:13 +0000 (UTC) X-HE-Tag: grain93_070c987272d4 X-Filterd-Recvd-Size: 3140 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 18:24:11 +0000 (UTC) IronPort-SDR: 6Qx0TqgA0lK6fKcRS6mtNuXVjCyFFe7MKGoW4Ewnh87HnnnRv6f/CyAFfw1JjGl1oUU04Ffck5 1g+V3/r2ParQ== X-IronPort-AV: E=McAfee;i="6000,8403,9797"; a="156582927" X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="156582927" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 10:24:09 -0800 IronPort-SDR: Kp6DFPqEfo2PjMsWFbyMNabIjKMmRlMsXXBJYEc2XgfImDO+fPrUARSHD0E8dveJMl+91XYvXh TYN12/ObkSMg== X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="539937984" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 10:24:09 -0800 Date: Fri, 6 Nov 2020 10:24:09 -0800 From: Ira Weiny To: Alex Shi Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked Message-ID: <20201106182409.GC3976735@iweiny-DESK2.sc.intel.com> References: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.11.1 (2018-12-01) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 06, 2020 at 07:24:55PM +0800, Alex Shi wrote: > Otherwise it cause gcc warning: > ^~~~~~~~~~~~~~~ > ../mm/filemap.c:830:14: warning: no previous prototype for > =E2=80=98__add_to_page_cache_locked=E2=80=99 [-Wmissing-prototypes] > noinline int __add_to_page_cache_locked(struct page *page, > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > Does this affect the use in: kernel/bpf/verifier.c|11478| BTF_ID(func, __add_to_page_cache_locked) = =20 ? It does not look like that calls the function but I'm not sure what BTF_I= D does? Ira >=20 > Signed-off-by: Alex Shi > Cc: Andrew Morton =20 > Cc: linux-mm@kvack.org=20 > Cc: linux-kernel@vger.kernel.org=20 > --- > mm/filemap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mm/filemap.c b/mm/filemap.c > index d90614f501da..249cf489f5df 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -827,7 +827,7 @@ int replace_page_cache_page(struct page *old, struc= t page *new, gfp_t gfp_mask) > } > EXPORT_SYMBOL_GPL(replace_page_cache_page); > =20 > -noinline int __add_to_page_cache_locked(struct page *page, > +static noinline int __add_to_page_cache_locked(struct page *page, > struct address_space *mapping, > pgoff_t offset, gfp_t gfp, > void **shadowp) > --=20 > 1.8.3.1 >=20