From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 830B9C5519F for ; Fri, 20 Nov 2020 15:09:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB1B822226 for ; Fri, 20 Nov 2020 15:09:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="i5O7Fp/E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB1B822226 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2A1516B0036; Fri, 20 Nov 2020 10:09:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 229676B005C; Fri, 20 Nov 2020 10:09:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB856B005D; Fri, 20 Nov 2020 10:09:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id C27FB6B0036 for ; Fri, 20 Nov 2020 10:09:39 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 03A6B3645 for ; Fri, 20 Nov 2020 15:09:37 +0000 (UTC) X-FDA: 77505130836.07.copy19_240b5562734c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id C14E818002076 for ; Fri, 20 Nov 2020 15:09:37 +0000 (UTC) X-HE-Tag: copy19_240b5562734c X-Filterd-Recvd-Size: 3579 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Nov 2020 15:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SvuJ0Yggw//XkE7jbGBD/osU1sxNXLlG/4aodz1frU0=; b=i5O7Fp/EzeqJzhjLWGIElPmQE/ lX22PPAxwrgL7qVXXRChT3Wzz6uMgwRJf1wrw6hPIPPwWgUGomuSA5LXlzWXyO0eD72K6Bu7LBWAH vWieSG3s+8IDY+sP+yM152D9xUq/6stV2+kOtdnlRHc31APiS21EGTKMzJ0t/Cy7GdVjKg3qncgUL uG3xzJtcxMCrg0ZanzTbKZaokfCguuXV0KOD55UzzhG0e/BwFkHF3XSAlNb0u4sMT9vOn1mofe17S LdjVM/3IpRTNx/Tcc9hCD69lAZa4dWrh1ynzGAfFW98MdufJvI9sL255Xf5NpiG0s2E8I3M0p13gA i42K6Q2w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg82V-00018B-N2; Fri, 20 Nov 2020 15:09:32 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E133B300B22; Fri, 20 Nov 2020 16:09:30 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id CCE04201B4C48; Fri, 20 Nov 2020 16:09:30 +0100 (CET) Date: Fri, 20 Nov 2020 16:09:30 +0100 From: Peter Zijlstra To: Will Deacon Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Catalin Marinas , Yu Zhao , Minchan Kim , Linus Torvalds , Anshuman Khandual , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/6] mm: proc: Invalidate TLB after clearing soft-dirty page state Message-ID: <20201120150930.GC3092@hirez.programming.kicks-ass.net> References: <20201120143557.6715-1-will@kernel.org> <20201120143557.6715-5-will@kernel.org> <20201120150023.GH3040@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201120150023.GH3040@hirez.programming.kicks-ass.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 20, 2020 at 04:00:23PM +0100, Peter Zijlstra wrote: > If you look at __tlb_remove_tlb_entry() ... you'll also find we can probably do this ... :-) diff --git a/arch/sparc/include/asm/tlb_64.h b/arch/sparc/include/asm/tlb_64.h index e841cae544c2..779a5a0f0608 100644 --- a/arch/sparc/include/asm/tlb_64.h +++ b/arch/sparc/include/asm/tlb_64.h @@ -24,7 +24,6 @@ void flush_tlb_pending(void); #define tlb_start_vma(tlb, vma) do { } while (0) #define tlb_end_vma(tlb, vma) do { } while (0) -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) #define tlb_flush(tlb) flush_tlb_pending() /* diff --git a/arch/x86/include/asm/tlb.h b/arch/x86/include/asm/tlb.h index 820082bd6880..1bfe979bb9bc 100644 --- a/arch/x86/include/asm/tlb.h +++ b/arch/x86/include/asm/tlb.h @@ -4,7 +4,6 @@ #define tlb_start_vma(tlb, vma) do { } while (0) #define tlb_end_vma(tlb, vma) do { } while (0) -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) #define tlb_flush tlb_flush static inline void tlb_flush(struct mmu_gather *tlb);