From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10537C2D0E4 for ; Mon, 23 Nov 2020 16:48:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75A252080A for ; Mon, 23 Nov 2020 16:48:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eZkzFwIb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75A252080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D338A6B00BB; Mon, 23 Nov 2020 11:48:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBA626B00BE; Mon, 23 Nov 2020 11:48:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B82976B00BF; Mon, 23 Nov 2020 11:48:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 87CD76B00BB for ; Mon, 23 Nov 2020 11:48:52 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2E4D91EE6 for ; Mon, 23 Nov 2020 16:48:52 +0000 (UTC) X-FDA: 77516267304.28.cream53_0d0f50427367 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id E8B916D67 for ; Mon, 23 Nov 2020 16:48:51 +0000 (UTC) X-HE-Tag: cream53_0d0f50427367 X-Filterd-Recvd-Size: 2698 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Nov 2020 16:48:51 +0000 (UTC) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82EA520717; Mon, 23 Nov 2020 16:48:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606150130; bh=ARuPgpdEJcSeF2gm4TH6D3zIPUtJVSXUazCL6eofvtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eZkzFwIbcGWn1pF2cCwkM9QWKaWhbBLfrlR5scjzuLzYN7EuBE9PNsmCz/sd62Bd2 ol1J06dGh4Gnthl8GuICOurG5vhJZhQ+lnmvTBWlDQz0s3desFT3sncQu1b7JunKpc LArLadFWviiaTBFBU7BuAPj9MaR2PIgD/mDK5zTE= Date: Mon, 23 Nov 2020 16:48:45 +0000 From: Will Deacon To: Linus Torvalds Cc: Linux Kernel Mailing List , Android Kernel Team , Catalin Marinas , Yu Zhao , Minchan Kim , Peter Zijlstra , Anshuman Khandual , Linux-MM , Linux ARM Subject: Re: [PATCH 3/6] tlb: mmu_gather: Remove unused start/end arguments from tlb_finish_mmu() Message-ID: <20201123164844.GB11494@willie-the-truck> References: <20201120143557.6715-1-will@kernel.org> <20201120143557.6715-4-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 20, 2020 at 09:20:43AM -0800, Linus Torvalds wrote: > On Fri, Nov 20, 2020 at 6:36 AM Will Deacon wrote: > > > > tlb_finish_mmu() takes two confusing and unused 'start'/'end' address > > arguments. Remove them. > > Ack, but please add the history to it. > > Those arguments were used, up until 7a30df49f63a ("mm: mmu_gather: > remove __tlb_reset_range() for force flush"). > > And the thing is, using a range flush in theory might be better, but > for simplicity it's now doing a "fullmm" one, which is why those > arguments no longer matter. > > (And I think we track the range better now too, which may be another > reason they aren't needed) Yes, thanks for digging that up. I'll add it to the commit message in v2. Will