From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9374EC433FE for ; Mon, 7 Dec 2020 08:16:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C3163229C6 for ; Mon, 7 Dec 2020 08:16:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3163229C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 04E768D0002; Mon, 7 Dec 2020 03:16:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F41EC8D0001; Mon, 7 Dec 2020 03:15:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E30418D0002; Mon, 7 Dec 2020 03:15:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id C943F8D0001 for ; Mon, 7 Dec 2020 03:15:59 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 80BB8181AEF1D for ; Mon, 7 Dec 2020 08:15:59 +0000 (UTC) X-FDA: 77565778038.03.chain61_1110f6a273dc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 5FED928A4E9 for ; Mon, 7 Dec 2020 08:15:59 +0000 (UTC) X-HE-Tag: chain61_1110f6a273dc X-Filterd-Recvd-Size: 4075 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Dec 2020 08:15:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1ADF6AC9A; Mon, 7 Dec 2020 08:15:57 +0000 (UTC) Received: by lion.mk-sys.cz (Postfix, from userid 1000) id BE771603C1; Mon, 7 Dec 2020 09:15:56 +0100 (CET) Date: Mon, 7 Dec 2020 09:15:56 +0100 From: Michal Kubecek To: Alex Shi Cc: Andrew Morton , Souptick Joarder , Linux-MM , linux-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Josef Bacik Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked Message-ID: <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> References: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> <20201110115037.f6a53faec8d65782ab65d8b4@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 12, 2020 at 08:18:57AM +0800, Alex Shi wrote: >=20 >=20 > =E5=9C=A8 2020/11/11 =E4=B8=8A=E5=8D=883:50, Andrew Morton =E5=86=99=E9= =81=93: > > On Tue, 10 Nov 2020 08:39:24 +0530 Souptick Joarder wrote: > >=20 > >> On Fri, Nov 6, 2020 at 4:55 PM Alex Shi = wrote: > >>> > >>> Otherwise it cause gcc warning: > >>> ^~~~~~~~~~~~~~~ > >>> ../mm/filemap.c:830:14: warning: no previous prototype for > >>> =E2=80=98__add_to_page_cache_locked=E2=80=99 [-Wmissing-prototypes] > >>> noinline int __add_to_page_cache_locked(struct page *page, > >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~ > >> > >> Is CONFIG_DEBUG_INFO_BTF enabled in your .config ? > >=20 > > hm, yes. >=20 > When the config enabled, compiling looks good untill pahole tool > used to get BTF info, but I still failed on a right version pahole > > 1.16. Sorry. >=20 > >=20 > >>> > >>> Signed-off-by: Alex Shi > >>> Cc: Andrew Morton > >>> Cc: linux-mm@kvack.org > >>> Cc: linux-kernel@vger.kernel.org > >>> --- > >>> mm/filemap.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/mm/filemap.c b/mm/filemap.c > >>> index d90614f501da..249cf489f5df 100644 > >>> --- a/mm/filemap.c > >>> +++ b/mm/filemap.c > >>> @@ -827,7 +827,7 @@ int replace_page_cache_page(struct page *old, s= truct page *new, gfp_t gfp_mask) > >>> } > >>> EXPORT_SYMBOL_GPL(replace_page_cache_page); > >>> > >>> -noinline int __add_to_page_cache_locked(struct page *page, > >>> +static noinline int __add_to_page_cache_locked(struct page *page, > >>> struct address_space *mappi= ng, > >>> pgoff_t offset, gfp_t gfp, > >>> void **shadowp) > >=20 > > It's unclear to me whether BTF_ID() requires that the target symbol b= e > > non-static. It doesn't actually reference the symbol: > >=20 > > #define BTF_ID(prefix, name) \ > > __BTF_ID(__ID(__BTF_ID__##prefix##__##name##__)) > >=20 >=20 > The above usage make me thought BTF don't require the symbol, though > the symbol still exist in vmlinux with 'static'. >=20 > So any comments of this, Alexei?=20 It's probably more complicated: our v5.10-rc7 builds with CONFIG_DEBUG_INFO_BTF=3Dy fail on ppc64 and ppc64le with BTFIDS vmlinux FAILED unresolved symbol __add_to_page_cache_locked but succeed on x86_64, i586, aarch64 and s390x. So far I don't see why this should depend on architecture. Michal