From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A95C433FE for ; Mon, 7 Dec 2020 22:10:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 691B62395A for ; Mon, 7 Dec 2020 22:10:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 691B62395A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED0198D0005; Mon, 7 Dec 2020 17:10:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E59808D0003; Mon, 7 Dec 2020 17:10:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6D578D0005; Mon, 7 Dec 2020 17:10:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id B805D8D0003 for ; Mon, 7 Dec 2020 17:10:03 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7E8C31EE6 for ; Mon, 7 Dec 2020 22:10:03 +0000 (UTC) X-FDA: 77567879886.12.cord25_0f13134273e1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 39F0918000CBE for ; Mon, 7 Dec 2020 22:10:03 +0000 (UTC) X-HE-Tag: cord25_0f13134273e1 X-Filterd-Recvd-Size: 4240 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Dec 2020 22:10:02 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id c137so19860456ybf.21 for ; Mon, 07 Dec 2020 14:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=LIYHOEA3PKvDsVgiHjdmx9YU9pD0AIzqmU7pPjIkHgc=; b=SRTEYO3VD9UFrTY1qt4R0yH0vlwmlgziaRTQfYygwrkX8kNy7mRB36+gr8+gx+Ricp unh2OtzCqK8zJ12qwX0VbKP47DHd2l5cNXg5czCIaRSCXooTf2YEDoSXbqQ3h/VgumY9 FKd4BDr6z736sF2hKk7wVbbtazgFcPIRnawoMSv7YOJuwyk3Z9lq9hLVSSvURNR27/4E 7O8NNEbrDsxteqTwKomQvvq4EtDvjydc4r8eEXOzrjwT43RPCrjc+DYqdrVaI49TVzlA AHEsg3t1+MQQWc1iU5nj8IZlaumfDnRrGpQowv3JHTuT/VPTz37aoVPM+KDxF+sGmCx5 0GCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=LIYHOEA3PKvDsVgiHjdmx9YU9pD0AIzqmU7pPjIkHgc=; b=CEVTgLqAma8VzXHTaeg7rRpLOZ288zMA+0E7M8trdZcaS+T6+YSoHakGwGD96FChOm YDGP+jFG5Ek7fcoKJ0jYf+Bay4n8+sg1yzOw917Sp9BXSnhhRELAa31wubLn55+8WUCQ VvJQ4vheT6GC0BIp0yxq3RTs0PHxrxICdIUkUjhsRg7kbsubi/HCHVK+Hu8QXXv/8gYB 74h0QMG1CwzBYlLCvmini34gz6xE/oumeVOFoDT0ZkyTWxRtm0BJ+gvwt7m9f2nHJY9b uADRZT5XwHpj2XM6kA5x6tax4hn6lp//UddTOTfnoQHzZrUNd1RORVo98l5bGlvOB3AL J4vw== X-Gm-Message-State: AOAM530w2A3jTNb//NsRuBdDRQ0OQJCxTxdgjlcX/4GQ0pbHktkeft+P 3Bb6gc9CzZrhc4B8wCFn6RfUG+Ru/vQ= X-Google-Smtp-Source: ABdhPJz7hXUtem/Ga7wk+XyAE/X9Oz3SO0UGGwnI81ZSyCjKlfiQlsGQVEWWGqaa80fwndrDIlmsA8Z7ciQ= X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:7220:84ff:fe09:2d90]) (user=yuzhao job=sendgmr) by 2002:a25:2485:: with SMTP id k127mr13179519ybk.315.1607379001691; Mon, 07 Dec 2020 14:10:01 -0800 (PST) Date: Mon, 7 Dec 2020 15:09:39 -0700 In-Reply-To: <20201207220949.830352-1-yuzhao@google.com> Message-Id: <20201207220949.830352-2-yuzhao@google.com> Mime-Version: 1.0 References: <20201207220949.830352-1-yuzhao@google.com> X-Mailer: git-send-email 2.29.2.576.ga3fc446d84-goog Subject: [PATCH 01/11] mm: use add_page_to_lru_list() From: Yu Zhao To: Andrew Morton , Hugh Dickins , Alex Shi Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yu Zhao Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There is add_page_to_lru_list(), and move_pages_to_lru() should reuse it, not duplicate it. Signed-off-by: Yu Zhao --- mm/vmscan.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 469016222cdb..a174594e40f8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1821,7 +1821,6 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, int nr_pages, nr_moved = 0; LIST_HEAD(pages_to_free); struct page *page; - enum lru_list lru; while (!list_empty(list)) { page = lru_to_page(list); @@ -1866,11 +1865,8 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, * inhibits memcg migration). */ VM_BUG_ON_PAGE(!lruvec_holds_page_lru_lock(page, lruvec), page); - lru = page_lru(page); + add_page_to_lru_list(page, lruvec, page_lru(page)); nr_pages = thp_nr_pages(page); - - update_lru_size(lruvec, lru, page_zonenum(page), nr_pages); - list_add(&page->lru, &lruvec->lists[lru]); nr_moved += nr_pages; if (PageActive(page)) workingset_age_nonresident(lruvec, nr_pages); -- 2.29.2.576.ga3fc446d84-goog