From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F31F4C433FE for ; Tue, 8 Dec 2020 15:10:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EA3723A75 for ; Tue, 8 Dec 2020 15:10:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EA3723A75 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=uniroma2.it Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 797A66B005D; Tue, 8 Dec 2020 10:10:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F9A16B0068; Tue, 8 Dec 2020 10:10:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EACC6B006C; Tue, 8 Dec 2020 10:10:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 432A56B005D for ; Tue, 8 Dec 2020 10:10:21 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F0780181AEF1A for ; Tue, 8 Dec 2020 15:10:20 +0000 (UTC) X-FDA: 77570451000.08.flesh36_07135d2273e8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id C4C011819E76C for ; Tue, 8 Dec 2020 15:10:20 +0000 (UTC) X-HE-Tag: flesh36_07135d2273e8 X-Filterd-Recvd-Size: 6428 Received: from smtp.uniroma2.it (smtp.uniroma2.it [160.80.6.22]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 15:10:19 +0000 (UTC) Received: from smtpauth-2019-1.uniroma2.it (smtpauth-2019-1.uniroma2.it [160.80.5.46]) by smtp-2015.uniroma2.it (8.14.4/8.14.4/Debian-8) with ESMTP id 0B8F9qkf015724; Tue, 8 Dec 2020 16:09:57 +0100 Received: from lubuntu-18.04 (unknown [160.80.103.126]) by smtpauth-2019-1.uniroma2.it (Postfix) with ESMTPSA id A7BF7120CDF; Tue, 8 Dec 2020 16:09:48 +0100 (CET) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=uniroma2.it; s=ed201904; t=1607440188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2q6OZOtGSBoEE0nYNQxdGW0eXF7buVs9/UjGbP8sn3E=; b=XI/cXizvRXkrm949rlj+jjiVhl5qPiHJl8CExnoccHNtQXudLjHO4BaOeeQhkKLic0hCmi 2x+84GCLuqJQpKDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniroma2.it; s=rsa201904; t=1607440188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2q6OZOtGSBoEE0nYNQxdGW0eXF7buVs9/UjGbP8sn3E=; b=XFKEdjjT3vgWmaGCJ07VwrtH37UOeD4aETyhytG30D70u4PrZnsykNujfQLpdPL78xcVKm Mh6YX9lG6pbHxbt1hYogbv/gXxe1OmDQ5RhN8OUBDSzdZGLZe25EJuLGLX2br2W48Rzr6Y 5X6bdW8tZjzAJ9pX0Vf20nh46Ize0zJFm+9Qer5saZ1WsAR20GGiG8uHWJ+7NSUFo+61HF YVBRFCXWcCwjBGh75eOIzWpbNSVrRDvp+5Ct7KnhKLkF4/mCjxriClZ4S3ZlTdojebYkwy hC4PzJsI2EFsRpT+h6Ssqj1D5bNjVFp2oXjCdpwccDtCIQkkrovad9LdcnZJGQ== Date: Tue, 8 Dec 2020 16:09:48 +0100 From: Andrea Mayer To: kernel test robot Cc: Andrea Mayer , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Jakub Kicinski , David Ahern Subject: Re: [linux-next:master 10573/11438] drivers/net/vrf.c:1447:9: error: implicit declaration of function 'vrf_add_mac_header_if_unset' Message-Id: <20201208160948.ba953242c88f3a235bb67331@uniroma2.it> In-Reply-To: <202012081443.f0ebzTGh-lkp@intel.com> References: <202012081443.f0ebzTGh-lkp@intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.100.0 at smtp-2015 X-Virus-Status: Clean X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 8 Dec 2020 14:35:45 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 15ac8fdb74403772780be1a8c4f7c1eff1040fc4 > commit: 048939088220278b8ee5bbf3769fd2f803ca9e3e [10573/11438] vrf: add mac header for tunneled packets when sniffer is attached > config: arm-randconfig-r033-20201208 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project a2f922140f5380571fb74179f2bf622b3b925697) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm cross compiling tool for clang build > # apt-get install binutils-arm-linux-gnueabi > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=048939088220278b8ee5bbf3769fd2f803ca9e3e > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 048939088220278b8ee5bbf3769fd2f803ca9e3e > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > >> drivers/net/vrf.c:1447:9: error: implicit declaration of function 'vrf_add_mac_header_if_unset' [-Werror,-Wimplicit-function-declaration] > err = vrf_add_mac_header_if_unset(skb, vrf_dev, ETH_P_IP); > ^ > 1 error generated. > > vim +/vrf_add_mac_header_if_unset +1447 drivers/net/vrf.c > > 1423 > 1424 static struct sk_buff *vrf_ip_rcv(struct net_device *vrf_dev, > 1425 struct sk_buff *skb) > 1426 { > 1427 skb->dev = vrf_dev; > 1428 skb->skb_iif = vrf_dev->ifindex; > 1429 IPCB(skb)->flags |= IPSKB_L3SLAVE; > 1430 > 1431 if (ipv4_is_multicast(ip_hdr(skb)->daddr)) > 1432 goto out; > 1433 > 1434 /* loopback traffic; do not push through packet taps again. > 1435 * Reset pkt_type for upper layers to process skb > 1436 */ > 1437 if (skb->pkt_type == PACKET_LOOPBACK) { > 1438 skb->pkt_type = PACKET_HOST; > 1439 goto out; > 1440 } > 1441 > 1442 vrf_rx_stats(vrf_dev, skb->len); > 1443 > 1444 if (!list_empty(&vrf_dev->ptype_all)) { > 1445 int err; > 1446 > > 1447 err = vrf_add_mac_header_if_unset(skb, vrf_dev, ETH_P_IP); > 1448 if (likely(!err)) { > 1449 skb_push(skb, skb->mac_len); > 1450 dev_queue_xmit_nit(skb, vrf_dev); > 1451 skb_pull(skb, skb->mac_len); > 1452 } > 1453 } > 1454 > 1455 skb = vrf_rcv_nfhook(NFPROTO_IPV4, NF_INET_PRE_ROUTING, skb, vrf_dev); > 1456 out: > 1457 return skb; > 1458 } > 1459 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Hi all, The vrf_add_mac_header_if_unset() is wrongly defined within a conditional compilation block which depends on the CONFIG_IPV6 macro. Therefore, when the CONFIG_IPV6 is not set, the function vrf_add_mac_header_if_unset() is missing and the build process stops reporting the error. The problem is easily solved by moving the function vrf_add_mac_header_if_unset() out of the conditional block. Shortly I will send the fix patch directly to "net-next". Sorry for the inconvenience, thank you all. Andrea