From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC50C433FE for ; Wed, 9 Dec 2020 15:08:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5A66523AC4 for ; Wed, 9 Dec 2020 15:08:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A66523AC4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B57E6B00F4; Wed, 9 Dec 2020 10:08:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98B886B00F7; Wed, 9 Dec 2020 10:08:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A0BA6B00F8; Wed, 9 Dec 2020 10:08:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 7294C6B00F4 for ; Wed, 9 Dec 2020 10:08:43 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 356CE824999B for ; Wed, 9 Dec 2020 15:08:43 +0000 (UTC) X-FDA: 77574075726.05.fall49_3401441273f0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 1E2A01826B6A6 for ; Wed, 9 Dec 2020 15:08:43 +0000 (UTC) X-HE-Tag: fall49_3401441273f0 X-Filterd-Recvd-Size: 3036 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Dec 2020 15:08:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KmfM0dz9aaWaeZPra6pVjVS4g9ep1l744z/4R96Ui3M=; b=fKfdu1e6Ef5Bpq8BX9sCBr+tUY M4m9JESfmi+ue+BUSliO/MnXrGCgke/bHGWZAminabL+uWeZpoYPeUESXedSSW6ZYg5G2t6QGAwfQ UGGGVW0ubs7ikPD74DUhssG/PYrOUtoPU6imLXFH4klaVVqblTH8W32f7bM2KIwnmTbUPdgx3ku8L H4Zi3RtjNol5wuHqTHF+vY9IXtZ5cyexGKG3QIRezCDMdfzj6j9qzQZAQxikeBw/IDZdBcF5TYL8I p0d3USXWXkdaEAjeaLxSrg6OYxEffWrEj3efEqKLGBPp01AUvk95tFgAeFS07cDh8Z+eMLXptis4T oNeMutpw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kn14s-0005Hf-Kd; Wed, 09 Dec 2020 15:08:26 +0000 Date: Wed, 9 Dec 2020 15:08:26 +0000 From: Matthew Wilcox To: Stanislaw Gruszka Cc: Alexei Starovoitov , Michal Kubecek , Justin Forbes , bpf , Alex Shi , Andrew Morton , Souptick Joarder , Linux-MM , LKML , Alexei Starovoitov , Daniel Borkmann , Josef Bacik Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked Message-ID: <20201209150826.GP7338@casper.infradead.org> References: <20201110115037.f6a53faec8d65782ab65d8b4@linux-foundation.org> <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> <20201207225351.2liywqaxxtuezzw3@lion.mk-sys.cz> <20201209144628.GA3474@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201209144628.GA3474@wp.pl> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 09, 2020 at 03:46:28PM +0100, Stanislaw Gruszka wrote: > At this point of release cycle we should probably go with revert, > but I think the main problem is that BPF and ERROR_INJECTION use > function that is not intended to be used externally. For external users > add_to_page_cache_lru() and add_to_page_cache_locked() are exported > and I think those should be used (see the patch below). FWIW, I intend to do some consolidation/renaming in this area. I trust that will not be a problem?