From: Michal Hocko <mhocko@suse.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
adobriyan@gmail.com, akpm@linux-foundation.org,
hannes@cmpxchg.org, vdavydov.dev@gmail.com, hughd@google.com,
shakeelb@google.com, guro@fb.com, samitolvanen@google.com,
feng.tang@intel.com, neilb@suse.de, iamjoonsoo.kim@lge.com,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH v3 2/7] mm: memcontrol: convert NR_ANON_THPS account to pages
Date: Tue, 15 Dec 2020 14:30:38 +0100 [thread overview]
Message-ID: <20201215133038.GO32193@dhcp22.suse.cz> (raw)
In-Reply-To: <20201208041847.72122-3-songmuchun@bytedance.com>
On Tue 08-12-20 12:18:42, Muchun Song wrote:
> The unit of NR_ANON_THPS is HPAGE_PMD_NR. Convert the NR_ANON_THPS
> account to pages.
This changelog could benefit from some improvements. First of all you
should be clear about the motivation. I believe the previous feedback
was also to explicitly mention what effect this has on the pcp
accounting flushing.
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> drivers/base/node.c | 3 +--
> fs/proc/meminfo.c | 2 +-
> mm/huge_memory.c | 3 ++-
> mm/memcontrol.c | 20 ++++++--------------
> mm/page_alloc.c | 2 +-
> mm/rmap.c | 7 ++++---
> 6 files changed, 15 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 04f71c7bc3f8..ec35cb567940 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -461,8 +461,7 @@ static ssize_t node_read_meminfo(struct device *dev,
> nid, K(sunreclaimable)
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> ,
> - nid, K(node_page_state(pgdat, NR_ANON_THPS) *
> - HPAGE_PMD_NR),
> + nid, K(node_page_state(pgdat, NR_ANON_THPS)),
> nid, K(node_page_state(pgdat, NR_SHMEM_THPS) *
> HPAGE_PMD_NR),
> nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) *
> diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
> index d6fc74619625..a635c8a84ddf 100644
> --- a/fs/proc/meminfo.c
> +++ b/fs/proc/meminfo.c
> @@ -129,7 +129,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> show_val_kb(m, "AnonHugePages: ",
> - global_node_page_state(NR_ANON_THPS) * HPAGE_PMD_NR);
> + global_node_page_state(NR_ANON_THPS));
> show_val_kb(m, "ShmemHugePages: ",
> global_node_page_state(NR_SHMEM_THPS) * HPAGE_PMD_NR);
> show_val_kb(m, "ShmemPmdMapped: ",
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 10dd3cae5f53..66ec454120de 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -2178,7 +2178,8 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> lock_page_memcg(page);
> if (atomic_add_negative(-1, compound_mapcount_ptr(page))) {
> /* Last compound_mapcount is gone. */
> - __dec_lruvec_page_state(page, NR_ANON_THPS);
> + __mod_lruvec_page_state(page, NR_ANON_THPS,
> + -HPAGE_PMD_NR);
> if (TestClearPageDoubleMap(page)) {
> /* No need in mapcount reference anymore */
> for (i = 0; i < HPAGE_PMD_NR; i++)
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 8818bf64d6fe..b18e25a5cdf3 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1532,7 +1532,7 @@ static struct memory_stat memory_stats[] = {
> * on some architectures, the macro of HPAGE_PMD_SIZE is not
> * constant(e.g. powerpc).
> */
> - { "anon_thp", 0, NR_ANON_THPS },
> + { "anon_thp", PAGE_SIZE, NR_ANON_THPS },
> { "file_thp", 0, NR_FILE_THPS },
> { "shmem_thp", 0, NR_SHMEM_THPS },
> #endif
> @@ -1565,8 +1565,7 @@ static int __init memory_stats_init(void)
>
> for (i = 0; i < ARRAY_SIZE(memory_stats); i++) {
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> - if (memory_stats[i].idx == NR_ANON_THPS ||
> - memory_stats[i].idx == NR_FILE_THPS ||
> + if (memory_stats[i].idx == NR_FILE_THPS ||
> memory_stats[i].idx == NR_SHMEM_THPS)
> memory_stats[i].ratio = HPAGE_PMD_SIZE;
> #endif
> @@ -4088,10 +4087,6 @@ static int memcg_stat_show(struct seq_file *m, void *v)
> if (memcg1_stats[i] == MEMCG_SWAP && !do_memsw_account())
> continue;
> nr = memcg_page_state_local(memcg, memcg1_stats[i]);
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> - if (memcg1_stats[i] == NR_ANON_THPS)
> - nr *= HPAGE_PMD_NR;
> -#endif
> seq_printf(m, "%s %lu\n", memcg1_stat_names[i], nr * PAGE_SIZE);
> }
>
> @@ -4122,10 +4117,6 @@ static int memcg_stat_show(struct seq_file *m, void *v)
> if (memcg1_stats[i] == MEMCG_SWAP && !do_memsw_account())
> continue;
> nr = memcg_page_state(memcg, memcg1_stats[i]);
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> - if (memcg1_stats[i] == NR_ANON_THPS)
> - nr *= HPAGE_PMD_NR;
> -#endif
> seq_printf(m, "total_%s %llu\n", memcg1_stat_names[i],
> (u64)nr * PAGE_SIZE);
> }
> @@ -5653,10 +5644,11 @@ static int mem_cgroup_move_account(struct page *page,
> __mod_lruvec_state(from_vec, NR_ANON_MAPPED, -nr_pages);
> __mod_lruvec_state(to_vec, NR_ANON_MAPPED, nr_pages);
> if (PageTransHuge(page)) {
> - __dec_lruvec_state(from_vec, NR_ANON_THPS);
> - __inc_lruvec_state(to_vec, NR_ANON_THPS);
> + __mod_lruvec_state(from_vec, NR_ANON_THPS,
> + -nr_pages);
> + __mod_lruvec_state(to_vec, NR_ANON_THPS,
> + nr_pages);
> }
> -
> }
> } else {
> __mod_lruvec_state(from_vec, NR_FILE_PAGES, -nr_pages);
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 469e28f95ce7..1700f52b7869 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5580,7 +5580,7 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask)
> K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR),
> K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
> * HPAGE_PMD_NR),
> - K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR),
> + K(node_page_state(pgdat, NR_ANON_THPS)),
> #endif
> K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
> node_page_state(pgdat, NR_KERNEL_STACK_KB),
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 08c56aaf72eb..f59e92e26b61 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1144,7 +1144,8 @@ void do_page_add_anon_rmap(struct page *page,
> * disabled.
> */
> if (compound)
> - __inc_lruvec_page_state(page, NR_ANON_THPS);
> + __mod_lruvec_page_state(page, NR_ANON_THPS,
> + HPAGE_PMD_NR);
> __mod_lruvec_page_state(page, NR_ANON_MAPPED, nr);
> }
>
> @@ -1186,7 +1187,7 @@ void page_add_new_anon_rmap(struct page *page,
> if (hpage_pincount_available(page))
> atomic_set(compound_pincount_ptr(page), 0);
>
> - __inc_lruvec_page_state(page, NR_ANON_THPS);
> + __mod_lruvec_page_state(page, NR_ANON_THPS, HPAGE_PMD_NR);
> } else {
> /* Anon THP always mapped first with PMD */
> VM_BUG_ON_PAGE(PageTransCompound(page), page);
> @@ -1292,7 +1293,7 @@ static void page_remove_anon_compound_rmap(struct page *page)
> if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE))
> return;
>
> - __dec_lruvec_page_state(page, NR_ANON_THPS);
> + __mod_lruvec_page_state(page, NR_ANON_THPS, -HPAGE_PMD_NR);
>
> if (TestClearPageDoubleMap(page)) {
> /*
> --
> 2.11.0
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-12-15 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 4:18 [PATCH v3 0/7] Convert all THP vmstat counters to pages Muchun Song
2020-12-08 4:18 ` [PATCH v3 1/7] mm: memcontrol: fix NR_ANON_THPS account Muchun Song
2020-12-09 1:58 ` Roman Gushchin
2020-12-08 4:18 ` [PATCH v3 2/7] mm: memcontrol: convert NR_ANON_THPS account to pages Muchun Song
2020-12-15 13:30 ` Michal Hocko [this message]
2020-12-15 13:37 ` [External] " Muchun Song
2020-12-08 4:18 ` [PATCH v3 3/7] mm: memcontrol: convert NR_FILE_THPS " Muchun Song
2020-12-08 4:18 ` [PATCH v3 4/7] mm: memcontrol: convert NR_SHMEM_THPS " Muchun Song
2020-12-08 4:18 ` [PATCH v3 5/7] mm: memcontrol: convert NR_SHMEM_PMDMAPPED " Muchun Song
2020-12-08 4:18 ` [PATCH v3 6/7] mm: memcontrol: convert NR_FILE_PMDMAPPED " Muchun Song
2020-12-08 4:18 ` [PATCH v3 7/7] mm: memcontrol: make the slab calculation consistent Muchun Song
2020-12-08 7:20 ` Pankaj Gupta
2020-12-08 7:53 ` [External] " Muchun Song
2020-12-15 13:35 ` Michal Hocko
2020-12-15 16:21 ` [External] " Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215133038.GO32193@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=feng.tang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=samitolvanen@google.com \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).