From: Andrew Morton <akpm@linux-foundation.org>
To: kernel test robot <lkp@intel.com>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>,
Will Deacon <will.deacon@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Evgenii Stepanov <eugenis@google.com>
Subject: Re: [PATCH 10/11] kasan: fix bug detection via ksize for HW_TAGS mode
Date: Wed, 6 Jan 2021 16:02:50 -0800 [thread overview]
Message-ID: <20210106160250.24b79d8d119a7ff0a5414f3f@linux-foundation.org> (raw)
In-Reply-To: <202101060828.QFNIkNMv-lkp@intel.com>
On Wed, 6 Jan 2021 08:09:00 +0800 kernel test robot <lkp@intel.com> wrote:
> Hi Andrey,
> In file included from arch/x86/boot/compressed/cmdline.c:2:
> In file included from arch/x86/boot/compressed/misc.h:30:
> In file included from include/linux/acpi.h:14:
> In file included from include/linux/resource_ext.h:11:
> In file included from include/linux/slab.h:136:
> >> include/linux/kasan.h:314:77: warning: non-void function does not return a value [-Wreturn-type]
> static inline bool kasan_check_byte(const void *address, unsigned long ip) {}
> ^
> 1 warning generated.
>
This?
--- a/include/linux/kasan.h~kasan-fix-bug-detection-via-ksize-for-hw_tags-mode-fix
+++ a/include/linux/kasan.h
@@ -311,7 +311,10 @@ static inline void *kasan_krealloc(const
return (void *)object;
}
static inline void kasan_kfree_large(void *ptr, unsigned long ip) {}
-static inline bool kasan_check_byte(const void *address, unsigned long ip) {}
+static inline bool kasan_check_byte(const void *address, unsigned long ip)
+{
+ return true;
+}
#endif /* CONFIG_KASAN */
btw, "kasan_check_byte" isn't a good function name. Check for what?
Does it return true for a check which passed, or for a check which
failed? Something like "kasan_byte_valid" would be better - the name
explains the return value.
next prev parent reply other threads:[~2021-01-07 0:02 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 18:27 [PATCH 00/11] kasan: HW_TAGS tests support and fixes Andrey Konovalov
2021-01-05 18:27 ` [PATCH 01/11] kasan: prefix exported functions with kasan_ Andrey Konovalov
2021-01-12 7:38 ` Alexander Potapenko
2021-01-12 11:19 ` Marco Elver
2021-01-05 18:27 ` [PATCH 02/11] kasan: clarify HW_TAGS impact on TBI Andrey Konovalov
2021-01-12 7:40 ` Alexander Potapenko
2021-01-12 11:38 ` Marco Elver
2021-01-05 18:27 ` [PATCH 03/11] kasan: clean up comments in tests Andrey Konovalov
2021-01-12 7:53 ` Alexander Potapenko
2021-01-12 17:55 ` Andrey Konovalov
2021-01-12 13:07 ` Marco Elver
2021-01-05 18:27 ` [PATCH 04/11] kasan: add match-all tag tests Andrey Konovalov
2021-01-12 8:04 ` Alexander Potapenko
2021-01-12 18:10 ` Andrey Konovalov
2021-01-12 13:17 ` Marco Elver
2021-01-12 18:11 ` Andrey Konovalov
2021-01-05 18:27 ` [PATCH 05/11] kasan, arm64: allow using KUnit tests with HW_TAGS mode Andrey Konovalov
2021-01-12 19:01 ` Catalin Marinas
2021-01-15 13:11 ` Andrey Konovalov
2021-01-15 15:04 ` Vincenzo Frascino
2021-01-05 18:27 ` [PATCH 06/11] kasan: rename CONFIG_TEST_KASAN_MODULE Andrey Konovalov
2021-01-12 8:09 ` Alexander Potapenko
2021-01-12 18:26 ` Andrey Konovalov
2021-01-12 13:33 ` Marco Elver
2021-01-12 18:28 ` Andrey Konovalov
2021-01-05 18:27 ` [PATCH 07/11] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL Andrey Konovalov
2021-01-12 8:18 ` Alexander Potapenko
2021-01-12 19:50 ` Andrey Konovalov
2021-01-12 19:57 ` Andrey Konovalov
2021-01-12 13:34 ` Marco Elver
2021-01-05 18:27 ` [PATCH 08/11] kasan: adopt kmalloc_uaf2 test to HW_TAGS mode Andrey Konovalov
2021-01-12 8:25 ` Alexander Potapenko
2021-01-12 20:04 ` Andrey Konovalov
2021-01-12 13:39 ` Marco Elver
2021-01-12 20:05 ` Andrey Konovalov
2021-01-05 18:27 ` [PATCH 09/11] kasan: fix memory corruption in kasan_bitops_tags test Andrey Konovalov
2021-01-12 8:30 ` Alexander Potapenko
2021-01-12 20:06 ` Andrey Konovalov
2021-01-13 12:30 ` Alexander Potapenko
2021-01-12 13:55 ` Marco Elver
2021-01-05 18:27 ` [PATCH 10/11] kasan: fix bug detection via ksize for HW_TAGS mode Andrey Konovalov
2021-01-05 21:04 ` kernel test robot
2021-01-06 0:09 ` kernel test robot
2021-01-07 0:02 ` Andrew Morton [this message]
2021-01-07 1:59 ` Andrey Konovalov
2021-01-12 14:32 ` Marco Elver
2021-01-12 21:16 ` Andrey Konovalov
2021-01-12 22:54 ` Marco Elver
2021-01-05 18:27 ` [PATCH 11/11] kasan: add proper page allocator tests Andrey Konovalov
2021-01-12 8:57 ` Alexander Potapenko
2021-01-12 14:34 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106160250.24b79d8d119a7ff0a5414f3f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).