From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Alexander Lobakin <alobakin@pm.me>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
David Rientjes <rientjes@google.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Willem de Bruijn <willemb@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Dexuan Cui <decui@microsoft.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
Marco Elver <elver@google.com>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()
Date: Wed, 27 Jan 2021 13:47:26 -0800 [thread overview]
Message-ID: <20210127134726.00003605@intel.com> (raw)
In-Reply-To: <20210127201031.98544-4-alobakin@pm.me>
Alexander Lobakin wrote:
> A bunch of drivers test the page before reusing/recycling for two
> common conditions:
> - if a page was allocated under memory pressure (pfmemalloc page);
> - if a page was allocated at a distant memory node (to exclude
> slowdowns).
>
> Introduce and use a new common function for doing this and eliminate
> all functions-duplicates from drivers.
>
> Suggested-by: David Rientjes <rientjes@google.com>
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 10 ++--------
> drivers/net/ethernet/intel/fm10k/fm10k_main.c | 9 ++-------
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 15 +--------------
> drivers/net/ethernet/intel/iavf/iavf_txrx.c | 15 +--------------
> drivers/net/ethernet/intel/ice/ice_txrx.c | 11 +----------
> drivers/net/ethernet/intel/igb/igb_main.c | 7 +------
> drivers/net/ethernet/intel/igc/igc_main.c | 7 +------
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 7 +------
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 7 +------
> drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 7 +------
> include/linux/skbuff.h | 15 +++++++++++++++
> 11 files changed, 27 insertions(+), 83 deletions(-)
For the patch, and esp. for the Intel drivers:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2021-01-27 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 20:10 [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage Alexander Lobakin
2021-01-27 20:11 ` [PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument Alexander Lobakin
2021-01-28 22:44 ` David Rientjes
2021-01-30 2:30 ` Jakub Kicinski
2021-01-27 20:11 ` [PATCH v2 net-next 2/4] skbuff: constify skb_propagate_pfmemalloc() "page" argument Alexander Lobakin
2021-01-28 22:45 ` David Rientjes
2021-01-27 20:11 ` [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved() Alexander Lobakin
2021-01-27 21:47 ` Jesse Brandeburg [this message]
2021-01-28 22:48 ` David Rientjes
2021-01-30 2:39 ` Jakub Kicinski
2021-01-30 15:42 ` Alexander Lobakin
2021-01-30 19:07 ` Jakub Kicinski
2021-01-30 19:45 ` Alexander Lobakin
2021-01-30 21:23 ` John Hubbard
2021-01-27 20:11 ` [PATCH v2 net-next 4/4] net: page_pool: simplify page recycling condition tests Alexander Lobakin
2021-01-28 22:49 ` David Rientjes
2021-01-27 21:52 ` [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127134726.00003605@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alobakin@pm.me \
--cc=anthony.l.nguyen@intel.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=elver@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub@cloudflare.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=willemb@google.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).