From: Balbir Singh <bsingharora@gmail.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: corbet@lwn.net, mike.kravetz@oracle.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, paulmck@kernel.org,
mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com,
rdunlap@infradead.org, oneukum@suse.com,
anshuman.khandual@arm.com, jroedel@suse.de,
almasrymina@google.com, rientjes@google.com, willy@infradead.org,
osalvador@suse.de, mhocko@suse.com, song.bao.hua@hisilicon.com,
david@redhat.com, naoya.horiguchi@nec.com,
joao.m.martins@oracle.com, duanxiongchun@bytedance.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v17 5/9] mm: hugetlb: set the PageHWPoison to the raw error page
Date: Sun, 7 Mar 2021 19:18:57 +1100 [thread overview]
Message-ID: <20210307081857.GE1223287@balbir-desktop> (raw)
In-Reply-To: <20210225132130.26451-6-songmuchun@bytedance.com>
On Thu, Feb 25, 2021 at 09:21:26PM +0800, Muchun Song wrote:
> Because we reuse the first tail vmemmap page frame and remap it
> with read-only, we cannot set the PageHWPosion on some tail pages.
> So we can use the head[4].private (There are at least 128 struct
> page structures associated with the optimized HugeTLB page, so
> using head[4].private is safe) to record the real error page index
> and set the raw error page PageHWPoison later.
>
Does the hardcoding of 4 come from HUGETLB_CGROUP_MIN_ORDER, if so
do we need to hardcode 4? Also, I am not sure about the comment
on safety and 128 struct pages
Balbir
next prev parent reply other threads:[~2021-03-07 8:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 13:21 [PATCH v17 0/9] Free some vmemmap pages of HugeTLB page Muchun Song
2021-02-25 13:21 ` [PATCH v17 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c Muchun Song
2021-03-03 2:45 ` Singh, Balbir
2021-03-04 4:26 ` Balbir Singh
2021-03-04 5:50 ` [External] " Muchun Song
2021-02-25 13:21 ` [PATCH v17 2/9] mm: hugetlb: introduce a new config HUGETLB_PAGE_FREE_VMEMMAP Muchun Song
2021-03-04 5:06 ` Balbir Singh
2021-02-25 13:21 ` [PATCH v17 3/9] mm: hugetlb: free the vmemmap pages associated with each HugeTLB page Muchun Song
2021-03-04 23:50 ` Singh, Balbir
2021-03-05 4:41 ` [External] " Muchun Song
2021-02-25 13:21 ` [PATCH v17 4/9] mm: hugetlb: alloc " Muchun Song
2021-03-01 5:29 ` Muchun Song
2021-03-03 2:03 ` Mike Kravetz
2021-03-03 3:36 ` [External] " Muchun Song
2021-03-05 8:55 ` Balbir Singh
2021-03-05 9:30 ` [External] " Muchun Song
2021-02-25 13:21 ` [PATCH v17 5/9] mm: hugetlb: set the PageHWPoison to the raw error page Muchun Song
2021-03-07 8:18 ` Balbir Singh [this message]
2021-03-07 8:39 ` [External] " Muchun Song
2021-02-25 13:21 ` [PATCH v17 6/9] mm: hugetlb: add a kernel parameter hugetlb_free_vmemmap Muchun Song
2021-02-25 13:21 ` [PATCH v17 7/9] mm: hugetlb: introduce nr_free_vmemmap_pages in the struct hstate Muchun Song
2021-02-25 13:21 ` [PATCH v17 8/9] mm: hugetlb: gather discrete indexes of tail page Muchun Song
2021-02-25 13:21 ` [PATCH v17 9/9] mm: hugetlb: optimize the code with the help of the compiler Muchun Song
2021-03-04 3:14 ` [PATCH v17 0/9] Free some vmemmap pages of HugeTLB page Singh, Balbir
2021-03-04 3:36 ` [External] " Muchun Song
2021-03-04 4:25 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210307081857.GE1223287@balbir-desktop \
--to=bsingharora@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=anshuman.khandual@arm.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=hpa@zytor.com \
--cc=joao.m.martins@oracle.com \
--cc=jroedel@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=naoya.horiguchi@nec.com \
--cc=oneukum@suse.com \
--cc=osalvador@suse.de \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=song.bao.hua@hisilicon.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).