From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3080C433C1 for ; Fri, 19 Mar 2021 16:39:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7DA6161934 for ; Fri, 19 Mar 2021 16:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DA6161934 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E9B38D0012; Fri, 19 Mar 2021 12:39:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C0546B008C; Fri, 19 Mar 2021 12:39:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 060DE8D0012; Fri, 19 Mar 2021 12:39:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id DD46F6B008A for ; Fri, 19 Mar 2021 12:39:09 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 984613657 for ; Fri, 19 Mar 2021 16:39:09 +0000 (UTC) X-FDA: 77937183618.37.6A10DEA Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 801D3E0003AD for ; Fri, 19 Mar 2021 16:39:00 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id k4so3214770plk.5 for ; Fri, 19 Mar 2021 09:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j+pjxQiaXnPHaW0/aM9Ma4XbfsZ3VGpPRSn22gO/IJk=; b=hndwoIvTDp18phnZoOCAMilxvlnI5R4bA0e6iNMwiZ2EStHkNhhanShOAxQm/paJOL vrd258tkru/GarijoiTCdxlme4iCHlzw78VJjk6jR6gS8nQFoqbrbHcAY16uad1yuM4M Z7Cynrc7DTbGPAJ93R+Ee1nqRC89+tCS9In9PXNSX2XxHoD8v4I2VxZcrdxGwb/VLK6V e0OqJ087jjnsHeyWmUdjgEnRK+OAv+O7nGiG0gsoDo/HmZuzINONi8sptadFQnhycaeI huBd+7zO5WRDxnOHI+cNbxkvIv7NZSCUwhVxSqXR9nEH7q73J37fkqSpW2Ty+vFuYWUu 9WIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j+pjxQiaXnPHaW0/aM9Ma4XbfsZ3VGpPRSn22gO/IJk=; b=EbOlXNJi1+yBqffNsaN5ZEiFrGeoI5jyiCD2vVrfVASZjJXaIxFJ5TiC4xBowsPeiY U0tgdRoj7fm4R5OoHqiNgJwt11Z2gOP6tFbeGS6yYbUw9+xak8Bt9vhqsNpS54OTsvbx NYuhBgWgu1pDWVkp7QE/h/ABQxBZJIebARerg7KutS7S+x/D/rcqekaE9IQCkDsR8WbU KvHbZaybDcqzKNz7Y1pcd9TCeY1uTkyI5fKaqjo58fiqloXTXYKbcLisJdTQ5b98fElL JquScCHNzqNYlkfaRZmIGNvz0R31p3GksBaBho+GULZsbGtiCZpNFMTTmgF5nxgE4/JI pYOQ== X-Gm-Message-State: AOAM531YObyl6ZpdzvFvK/R1nIG0HK8LNTSNRNs70tqpmBIX0SZpTfhY ZZuLCz+G1xqLc/BK1jfR1W2GOg== X-Google-Smtp-Source: ABdhPJxixIQ1BHBaesp4TbWicJ28kV8dAw86Zj6b62FphQwkOH+vVTVeZmrTYVNMmK7JAPjxFw1sNg== X-Received: by 2002:a17:902:c48c:b029:e4:c093:593a with SMTP id n12-20020a170902c48cb02900e4c093593amr14951679plx.1.1616171934202; Fri, 19 Mar 2021 09:38:54 -0700 (PDT) Received: from localhost.bytedance.net ([139.177.225.231]) by smtp.gmail.com with ESMTPSA id z25sm5860239pfn.37.2021.03.19.09.38.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Mar 2021 09:38:53 -0700 (PDT) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, Muchun Song Subject: [PATCH v5 4/7] mm: memcontrol: change ug->dummy_page only if memcg changed Date: Sat, 20 Mar 2021 00:38:17 +0800 Message-Id: <20210319163821.20704-5-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210319163821.20704-1-songmuchun@bytedance.com> References: <20210319163821.20704-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 801D3E0003AD X-Stat-Signature: eu6sx9ow6y1xfcmiekjdbbfzkkx3jfap Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=mail-pl1-f172.google.com; client-ip=209.85.214.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616171940-172407 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Just like assignment to ug->memcg, we only need to update ug->dummy_page if memcg changed. So move it to there. This is a very small optimization. Signed-off-by: Muchun Song Acked-by: Johannes Weiner Reviewed-by: Shakeel Butt --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 9489c7fc1e04..8d28a5a2ee58 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -6854,6 +6854,7 @@ static void uncharge_page(struct page *page, struct= uncharge_gather *ug) uncharge_gather_clear(ug); } ug->memcg =3D page_memcg(page); + ug->dummy_page =3D page; =20 /* pairs with css_put in uncharge_batch */ css_get(&ug->memcg->css); @@ -6867,7 +6868,6 @@ static void uncharge_page(struct page *page, struct= uncharge_gather *ug) else ug->pgpgout++; =20 - ug->dummy_page =3D page; page->memcg_data =3D 0; css_put(&ug->memcg->css); } --=20 2.11.0