From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
joaodias@google.com, surenb@google.com, cgoldswo@codeaurora.org,
willy@infradead.org, mhocko@suse.com, david@redhat.com,
vbabka@suse.cz, linux-fsdevel@vger.kernel.org,
oliver.sang@intel.com
Subject: Re: [PATCH v4 3/3] mm: fs: Invalidate BH LRU during page migration
Date: Sat, 20 Mar 2021 09:32:49 -0700 [thread overview]
Message-ID: <20210320093249.2df740cd139449312211c452@linux-foundation.org> (raw)
In-Reply-To: <20210319175127.886124-3-minchan@kernel.org>
On Fri, 19 Mar 2021 10:51:27 -0700 Minchan Kim <minchan@kernel.org> wrote:
> Pages containing buffer_heads that are in one of the per-CPU
> buffer_head LRU caches will be pinned and thus cannot be migrated.
> This can prevent CMA allocations from succeeding, which are often used
> on platforms with co-processors (such as a DSP) that can only use
> physically contiguous memory. It can also prevent memory
> hot-unplugging from succeeding, which involves migrating at least
> MIN_MEMORY_BLOCK_SIZE bytes of memory, which ranges from 8 MiB to 1
> GiB based on the architecture in use.
>
> Correspondingly, invalidate the BH LRU caches before a migration
> starts and stop any buffer_head from being cached in the LRU caches,
> until migration has finished.
>
> Tested-by: Oliver Sang <oliver.sang@intel.com>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Signed-off-by: Chris Goldsworthy <cgoldswo@codeaurora.org>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
The signoff chain ordering might mean that Chris was the primary author, but
there is no From:him. Please clarify?
next prev parent reply other threads:[~2021-03-20 16:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 17:51 [PATCH v4 1/3] mm: disable LRU pagevec during the migration temporarily Minchan Kim
2021-03-19 17:51 ` [PATCH v4 2/3] mm: replace migrate_[prep|finish] with lru_cache_[disable|enable] Minchan Kim
2021-03-19 17:51 ` [PATCH v4 3/3] mm: fs: Invalidate BH LRU during page migration Minchan Kim
2021-03-20 16:32 ` Andrew Morton [this message]
2021-03-20 17:20 ` Minchan Kim
2021-03-20 19:54 ` Matthew Wilcox
2021-03-20 22:51 ` Chris Goldsworthy
2021-03-22 16:46 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210320093249.2df740cd139449312211c452@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgoldswo@codeaurora.org \
--cc=david@redhat.com \
--cc=joaodias@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=oliver.sang@intel.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).