From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36853C4338F for ; Tue, 27 Jul 2021 06:14:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC7AF60551 for ; Tue, 27 Jul 2021 06:14:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC7AF60551 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 33E978D0001; Tue, 27 Jul 2021 02:14:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EEAB6B005D; Tue, 27 Jul 2021 02:14:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DE628D0001; Tue, 27 Jul 2021 02:14:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id 0149E6B0036 for ; Tue, 27 Jul 2021 02:14:23 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B20888249980 for ; Tue, 27 Jul 2021 06:14:23 +0000 (UTC) X-FDA: 78407353206.38.0D6207B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 488A648C7 for ; Tue, 27 Jul 2021 06:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627366462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+foQI4ZSsPugMdNXFeoThHY1y2soLUHl8MsBlGsSC9w=; b=VZjIH65RteOPDJ1SiOkiLrEOe5j8tQazxSkThcqW2v5XzPVOYglXmdkZ2U5BZGcAz3tXDS XfG1O5fN1UNQoL54jOlOEJmeAO6IlrcvD/igP0SboxGMcqhHclg4RYxCRHEGlyuXyfJ9nT 5tuV+qaceJkoN5ypkAA6MjorwrQyCO4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-5jVv41_vN4Sao7o0MMzQKg-1; Tue, 27 Jul 2021 02:14:21 -0400 X-MC-Unique: 5jVv41_vN4Sao7o0MMzQKg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8806D100E420; Tue, 27 Jul 2021 06:14:19 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-195.bne.redhat.com [10.64.54.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60234687D5; Tue, 27 Jul 2021 06:14:13 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, gerald.schaefer@linux.ibm.com, aneesh.kumar@linux.ibm.com, christophe.leroy@csgroup.eu, cai@lca.pw, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com Subject: [PATCH v4 00/12] mm/debug_vm_pgtable: Enhancements Date: Tue, 27 Jul 2021 14:13:49 +0800 Message-Id: <20210727061401.592616-1-gshan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VZjIH65R; spf=none (imf22.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Stat-Signature: 6nz4195ig9e9a6ws7ys3135ni7e3daxb X-Rspamd-Queue-Id: 488A648C7 X-HE-Tag: 1627366463-811190 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There are couple of issues with current implementations and this series tries to resolve the issues: (a) All needed information are scattered in variables, passed to variou= s test functions. The code is organized in pretty much relaxed fashio= n. (b) The page isn't allocated from buddy during page table entry modifyi= ng tests. The page can be invalid, conflicting to the implementations of set_xxx_at() on ARM64. The target page is accessed so that the i= Cache can be flushed when execution permission is given on ARM64. Besides= , the target page can be unmapped and access to it causes kernel cras= h. "struct pgtable_debug_args" is introduced to address issue (a). For issue (b), the used page is allocated from buddy in page table entry modifying tests. The corresponding tets will be skipped if we fail to allocate the (huge) page. For other test cases, the original page around to kernel symbol (@start_kernel) is still used. The patches are organized as below. PATCH[2-10] could be combined to one patch, but it will make the review harder: PATCH[1] introduces "struct pgtable_debug_args" as place holder of all needed information. With it, the old and new implementation can coexist. PATCH[2-10] uses "struct pgtable_debug_args" in various test functions. PATCH[11] removes the unused code for old implementation. PATCH[12] fixes the issue of corrupted page flag for ARM64 Changelog =3D=3D=3D=3D=3D=3D=3D=3D=3D v4: * Determine the page allocation method according to MAX_ORDER (Anshuma= n) * Move existing comments to init_args() (Anshuma= n) * Code refactoring as suggested by Anshuman (Anshuma= n) * Improved commit log and add comments for flush_dcache_page() in PATCH[v4 12/12] (Anshuma= n) * Address misc comments (Anshuma= n) v3: * Fix the warning caused by allocating more pages than (1 << (MAX_ORDER - 1)) in init_args() (syzbot) * Fix build warning by dropping unused variables in separate patches (0-day) * Missed "WARN_ON(!pud_none(pud))" in pud_huge_tests() in PATCH[v2 09/12] (0-day) * Fix the subjects for PATCH[05/12] and PATCH[09/12] (Gavin) v2: * Rename struct vm_pgtable_debug to struct pgtable_debug_args. The parameter name to various test functions are renamed to "@args" (Anshuma= n) * Code changes as suggested by Anshuman (Anshuma= n) Gavin Shan (12): mm/debug_vm_pgtable: Introduce struct pgtable_debug_args mm/debug_vm_pgtable: Use struct pgtable_debug_args in basic tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in leaf and savewrite tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in protnone and devmap tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in soft_dirty and swap tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and thp tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PTE modifying tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PMD modifying tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PUD modifying tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PGD and P4D modifying tests mm/debug_vm_pgtable: Remove unused code mm/debug_vm_pgtable: Fix corrupted page flag mm/debug_vm_pgtable.c | 919 ++++++++++++++++++++++++++---------------- 1 file changed, 566 insertions(+), 353 deletions(-) --=20 2.23.0