From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3826C4320A for ; Thu, 29 Jul 2021 13:22:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5BF1A61019 for ; Thu, 29 Jul 2021 13:22:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5BF1A61019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CD9CA90000E; Thu, 29 Jul 2021 09:21:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 905AF8D0010; Thu, 29 Jul 2021 09:21:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30F018D0001; Thu, 29 Jul 2021 09:21:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id C80CC90000D for ; Thu, 29 Jul 2021 09:21:46 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 782D618432CD6 for ; Thu, 29 Jul 2021 13:21:46 +0000 (UTC) X-FDA: 78415687812.32.A1387AC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf01.hostedemail.com (Postfix) with ESMTP id 188B0500C4E6 for ; Thu, 29 Jul 2021 13:21:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EA589223DC; Thu, 29 Jul 2021 13:21:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1627564904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3cjwmH+h7UZgVKoLIxc11sR+eEh/ecP/VGvwRFBqOtQ=; b=RS2AZZ3GKGHTEIsTEdTEYsudOjTlIYo14TUkA0dNuxFKDzRppnpFFd9RMPfxe4pWdyY/05 8gH3sOJb5QKAsqECjm8y0e0P88ifGrqRUyxgyRVcwVM1l6teoGtE/fXX3Vi0U/Fxz19XTO GaSMXXMIUOJ/tsgOYrGpX0w+ClnNDSg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1627564904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3cjwmH+h7UZgVKoLIxc11sR+eEh/ecP/VGvwRFBqOtQ=; b=fBJtbTP1Ja/4JF1ggTG8CxVPGmyaAd80xH84isn04JzWeYdjP2H6/FsFMCnKvXLo7LkgS2 WTMc2r4kk1IcY8Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C113C13AE9; Thu, 29 Jul 2021 13:21:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CFugLmirAmF9AwAAMHmgww (envelope-from ); Thu, 29 Jul 2021 13:21:44 +0000 From: Vlastimil Babka To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Mike Galbraith , Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Jann Horn , Vlastimil Babka Subject: [PATCH v3 24/35] mm, slub: detach whole partial list at once in unfreeze_partials() Date: Thu, 29 Jul 2021 15:21:21 +0200 Message-Id: <20210729132132.19691-25-vbabka@suse.cz> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210729132132.19691-1-vbabka@suse.cz> References: <20210729132132.19691-1-vbabka@suse.cz> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 188B0500C4E6 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RS2AZZ3G; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fBJtbTP1; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: q5po75b7kgtdc3799s6thd65prdej7uf X-HE-Tag: 1627564905-521530 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Instead of iterating through the live percpu partial list, detach it from= the kmem_cache_cpu at once. This is simpler and will allow further optimizati= on. Signed-off-by: Vlastimil Babka --- mm/slub.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 1bde537a13b0..ede93f61651a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2341,16 +2341,20 @@ static void unfreeze_partials(struct kmem_cache *= s, { #ifdef CONFIG_SLUB_CPU_PARTIAL struct kmem_cache_node *n =3D NULL, *n2 =3D NULL; - struct page *page, *discard_page =3D NULL; + struct page *page, *partial_page, *discard_page =3D NULL; unsigned long flags; =20 local_irq_save(flags); =20 - while ((page =3D slub_percpu_partial(c))) { + partial_page =3D slub_percpu_partial(c); + c->partial =3D NULL; + + while (partial_page) { struct page new; struct page old; =20 - slub_set_percpu_partial(c, page); + page =3D partial_page; + partial_page =3D page->next; =20 n2 =3D get_node(s, page_to_nid(page)); if (n !=3D n2) { --=20 2.32.0