From: Andrew Morton <akpm@linux-foundation.org>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel@openvz.org,
"Uladzislau Rezki (Sony)" <urezki@gmail.com>
Subject: Re: [PATCH mm] vmalloc: back off when the current task is OOM-killed
Date: Tue, 21 Sep 2021 11:55:23 -0700 [thread overview]
Message-ID: <20210921115523.8606cea0b2f0a5ca4e79cbd0@linux-foundation.org> (raw)
In-Reply-To: <c9d43874-138e-54a9-3222-a08c269eeeb5@virtuozzo.com>
On Mon, 20 Sep 2021 13:59:35 +0300 Vasily Averin <vvs@virtuozzo.com> wrote:
> On 9/20/21 4:22 AM, Tetsuo Handa wrote:
> > On 2021/09/20 8:31, Andrew Morton wrote:
> >> On Fri, 17 Sep 2021 11:06:49 +0300 Vasily Averin <vvs@virtuozzo.com> wrote:
> >>
> >>> Huge vmalloc allocation on heavy loaded node can lead to a global
> >>> memory shortage. A task called vmalloc can have the worst badness
> >>> and be chosen by OOM-killer, however received fatal signal and
> >>> oom victim mark does not interrupt allocation cycle. Vmalloc will
> >>> continue allocating pages over and over again, exacerbating the crisis
> >>> and consuming the memory freed up by another killed tasks.
> >>>
> >>> This patch allows OOM-killer to break vmalloc cycle, makes OOM more
> >>> effective and avoid host panic.
> >>>
> >>> Unfortunately it is not 100% safe. Previous attempt to break vmalloc
> >>> cycle was reverted by commit b8c8a338f75e ("Revert "vmalloc: back off when
> >>> the current task is killed"") due to some vmalloc callers did not handled
> >>> failures properly. Found issues was resolved, however, there may
> >>> be other similar places.
> >>
> >> Well that was lame of us.
> >>
> >> I believe that at least one of the kernel testbots can utilize fault
> >> injection. If we were to wire up vmalloc (as we have done with slab
> >> and pagealloc) then this will help to locate such buggy vmalloc callers.
>
> Andrew, could you please clarify how we can do it?
> Do you mean we can use exsiting allocation fault injection infrastructure to trigger
> such kind of issues? Unfortunately I found no ways to reach this goal.
> It allows to emulate single faults with small probability, however it is not enough,
> we need to completely disable all vmalloc allocations.
I don't see why there's a problem? You're saying "there might still be
vmalloc() callers which don't correctly handle allocation failures",
yes?
I'm suggesting that we use fault injection to cause a small proportion
of vmalloc() calls to artificially fail, so such buggy callers will
eventually be found and fixed. Why does such a scheme require that
*all* vmalloc() calls fail?
next prev parent reply other threads:[~2021-09-21 18:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 12:39 [PATCH memcg] memcg: prohibit unconditional exceeding the limit of dying tasks Vasily Averin
2021-09-10 13:04 ` Tetsuo Handa
2021-09-10 13:20 ` Vasily Averin
2021-09-10 14:55 ` Michal Hocko
2021-09-13 8:29 ` Vasily Averin
2021-09-13 8:42 ` Michal Hocko
2021-09-17 8:06 ` [PATCH mm] vmalloc: back off when the current task is OOM-killed Vasily Averin
2021-09-19 23:31 ` Andrew Morton
2021-09-20 1:22 ` Tetsuo Handa
2021-09-20 10:59 ` Vasily Averin
2021-09-21 18:55 ` Andrew Morton [this message]
2021-09-22 6:18 ` Vasily Averin
2021-09-22 12:27 ` Michal Hocko
2021-09-23 6:49 ` Vasily Averin
2021-09-24 7:55 ` Michal Hocko
2021-09-27 9:36 ` Vasily Averin
2021-09-27 11:08 ` Michal Hocko
2021-10-05 13:52 ` [PATCH mm v2] " Vasily Averin
2021-10-05 14:00 ` Vasily Averin
2021-10-07 10:47 ` Michal Hocko
2021-10-07 19:55 ` Andrew Morton
2021-09-10 13:07 ` [PATCH memcg] memcg: prohibit unconditional exceeding the limit of dying tasks Vasily Averin
2021-09-13 7:51 ` Vasily Averin
2021-09-13 8:39 ` Michal Hocko
2021-09-13 9:37 ` Vasily Averin
2021-09-13 10:10 ` Michal Hocko
2021-09-13 8:53 ` Michal Hocko
2021-09-13 10:35 ` Vasily Averin
2021-09-13 10:55 ` Michal Hocko
2021-09-14 10:01 ` Vasily Averin
2021-09-14 10:10 ` [PATCH memcg v2] " Vasily Averin
2021-09-16 12:55 ` Michal Hocko
2021-10-05 13:52 ` [PATCH memcg v3] " Vasily Averin
2021-10-05 14:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921115523.8606cea0b2f0a5ca4e79cbd0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=urezki@gmail.com \
--cc=vdavydov.dev@gmail.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).