From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70884C433F5 for ; Wed, 6 Apr 2022 07:05:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F8896B0073; Wed, 6 Apr 2022 03:05:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A8A38D0001; Wed, 6 Apr 2022 03:05:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8B0D6B0075; Wed, 6 Apr 2022 03:05:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id DC1086B0073 for ; Wed, 6 Apr 2022 03:05:26 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B6C716186C for ; Wed, 6 Apr 2022 07:05:16 +0000 (UTC) X-FDA: 79325567832.05.092FAB5 Received: from mail1.bemta34.messagelabs.com (mail1.bemta34.messagelabs.com [195.245.231.4]) by imf15.hostedemail.com (Postfix) with ESMTP id 0BD7AA003E for ; Wed, 6 Apr 2022 07:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.com; s=170520fj; t=1649228714; i=@fujitsu.com; bh=05cGtA6yxrBEXr8TsKfNblRw+Bdby9YhP92PsT290U4=; h=Date:To:Cc:Subject:Message-ID:Reply-To:References:MIME-Version: Content-Type:In-Reply-To:From; b=BJDFFQHg7gw8WYACPIsS5IO7QZ2Et0/snRy0O1P7sPcx3klPBjnAcFB0x5vQmkc7B wdj7sgZsarcq07EkkN9Uk7cWaXRM4BHIkDNaIuDnoDW/xdWPN+yfeRQ0VLd0GPd0XX YqbordNSTrdttI2gAjHO+G0BfdXM58RE64W8BbUe7mviFWROX5XjUVwj2GTsNCRtCK 2WJ4V8hKwe8nmUuYA+n39zIapfnu0J3NGApl7UCEEBLyvU7tS2BrmjwMlFpa9b2hDX gUaY7GvBudukN14SBUkBadO1YF+sMHYk2wGdlkRTCLILZZ+pMjV2no6kK1JlP7i/NG hrGSl+X1ARJQg== X-Brightmail-Tracker: H4sIAAAAAAAAA1WSf1CTdRzH+T4bzx5hDz38iq9L8ljCH3ibDDW +ilh6lk8nFJfJJVfZgyy2GsjteThnXAdKKIcRKiTHVFDHrwFhB6OIOQ60BDwhGM6BFxWyGU4R kwqMX+1p54/+e3/u9fq8P/98CEFAPS4hlDpOqc1gNFLcR7h5E8HI6mITUqJcB19GDaPFOHowc gJDvQ3jOLLcP+WNxmx1QmRs+BFDg3/kY+jKtzcwZLm5GlnH60SovOJnHFnPb0cXLb1C9Evjkj f6YakYIPOhGhGaL1uHKmucInSksh2gY+fyBOiovQ1HRfXxqH2+TYTmnF9jyDjeiqH2e/0ilF8 9iaHavgoczZhKsFdD6aG+LLr54QkR3VKVQ3/+22GcLhmuBfRESzmgzWenMfryg+tC2jySi9MD Nfdw2vZ3noCe6rDh9HTzi4lksrc6I2Wf7kNv1dRoF5Y56KNrt1zGc8E8UQiWEQGUCcBbV94sB D7ubASwqMMkKASEe8iChp/EvCOkVkFLpRnwOYiSQqerD/C+gGoiYZfTIeL9QCoZLt6O5x2Sio Z/3jJgnv6X4BnbAs77JDVLwuq2CW8PyIZHf50Uehb8YW+5478soCLh8OIdjO8UUC/A2kWCj8u oJJh/XMobkFoB54wzOJ+D3fVNhl7AKzi1BrqKGI8SAW39zYJjIFD/TL/+mX790/6zQFAPNqZo 1WkqLp1Ra2SKqCiZQrFetjZGptggZz6VMXJllmy/kuVk0XJmPytXsqycPZC+V5Mqz1ByzcD9Q qlseGAbKDA+kl8CywlMGkz6KhJSAvxS9qUeUDGsao82S6NkL4EVBCGFZBxyM3+tMk2p+0itcT /iYwwJsTSIrNroxiSbyaSz6jQPugrCJCHkyAY3oHigysp4svb4ha0gVBJIAi8vrwBxplKbrub +z10ghADSQHIHXy9WZ3BP2l3uw5j78P1rb/CHOeYpkuRiOVWl7x8SfveXV2mR5OTzV3PqoheN 8ht3LNyuk9zUZwMLSQn2nG7ZBY2j9fXj4/Xh6J+Y0PeSaktax4Y6d4cFOZ7z//LgrtqvDm/2t W9dWnvb3L/tiNrwdkfbzTDCd94gjg5/95FjbO+gZtI+y5ozcZk43XrBOln9+2vFBZvW567Z9r 1f6qzuA8KkHzrTOXG3xfXJW3si49dl55zK18VVrPzm9FJB8kxZ07XEPMeA3frKF82dFysL5hq Dd6++a1ie0POwZ2DnaGwMN709Qp+4yh63My4WdkU4sod7ulc6TeLr3X51WxpLqKCwyK0maam1 qj6pbOGdEGdhiVl3Pu3jc0Nb9JxUyKoYRaRAyzL/Akr/LJA9BAAA X-Env-Sender: Alan.Robinson@fujitsu.com X-Msg-Ref: server-8.tower-548.messagelabs.com!1649228712!85085!1 X-Originating-IP: [62.60.8.97] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.85.5; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31866 invoked from network); 6 Apr 2022 07:05:12 -0000 Received: from unknown (HELO n03ukasimr01.n03.fujitsu.local) (62.60.8.97) by server-8.tower-548.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 6 Apr 2022 07:05:12 -0000 Received: from n03ukasimr01.n03.fujitsu.local (localhost [127.0.0.1]) by n03ukasimr01.n03.fujitsu.local (Postfix) with ESMTP id 3681F100190; Wed, 6 Apr 2022 08:05:12 +0100 (BST) Received: from nera.osd.abg.fsc.net (unknown [172.17.20.8]) by n03ukasimr01.n03.fujitsu.local (Postfix) with SMTP id 07836100181; Wed, 6 Apr 2022 08:05:10 +0100 (BST) Received: by nera.osd.abg.fsc.net (Postfix, from userid 5004) id B86E417478B; Wed, 6 Apr 2022 09:04:46 +0200 (CEST) Date: Wed, 6 Apr 2022 09:04:46 +0200 To: Christoph Hellwig Cc: Jens Axboe , "jfs-discussion@lists.sourceforge.net" , "linux-nvme@lists.infradead.org" , "virtualization@lists.linux-foundation.org" , "linux-mm@kvack.org" , "dm-devel@redhat.com" , "target-devel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "drbd-dev@lists.linbit.com" , "linux-s390@vger.kernel.org" , "linux-nilfs@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "cluster-devel@redhat.com" , "xen-devel@lists.xenproject.org" , "linux-ext4@vger.kernel.org" , "linux-um@lists.infradead.org" , "nbd@other.debian.org" , "linux-block@vger.kernel.org" , "linux-bcache@vger.kernel.org" , "ceph-devel@vger.kernel.org" , "linux-raid@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-xfs@vger.kernel.org" , "ocfs2-devel@oss.oracle.com" , "linux-fsdevel@vger.kernel.org" , "ntfs3@lists.linux.dev" , "linux-btrfs@vger.kernel.org" Subject: Re: [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show Message-ID: <20220406070446.GA1722@ts.fujitsu.com> Reply-To: Alan.Robinson@fujitsu.com Mail-Followup-To: Alan.Robinson@fujitsu.com, Christoph Hellwig , Jens Axboe , "jfs-discussion@lists.sourceforge.net" , "linux-nvme@lists.infradead.org" , "virtualization@lists.linux-foundation.org" , "linux-mm@kvack.org" , "dm-devel@redhat.com" , "target-devel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "drbd-dev@lists.linbit.com" , "linux-s390@vger.kernel.org" , "linux-nilfs@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "cluster-devel@redhat.com" , "xen-devel@lists.xenproject.org" , "linux-ext4@vger.kernel.org" , "linux-um@lists.infradead.org" , "nbd@other.debian.org" , "linux-block@vger.kernel.org" , "linux-bcache@vger.kernel.org" , "ceph-devel@vger.kernel.org" , "linux-raid@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-xfs@vger.kernel.org" , "ocfs2-devel@oss.oracle.com" , "linux-fsdevel@vger.kernel.org" , "ntfs3@lists.linux.dev" , "linux-btrfs@vger.kernel.org" References: <20220406060516.409838-1-hch@lst.de> <0b7ae3df301c4fdd8d37f773d8d1eb93@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b7ae3df301c4fdd8d37f773d8d1eb93@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM> X-sent-by-me: robin@sanpedro User-Agent: Mutt/1.9.3 (2018-01-21) From: Alan.Robinson@fujitsu.com (Alan Robinson) X-Virus-Scanned: ClamAV using ClamSMTP X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0BD7AA003E X-Stat-Signature: pbd55jpnf7nzse1eckms56g6mbdkdeu1 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b=BJDFFQHg; dmarc=pass (policy=none) header.from=fujitsu.com; spf=none (imf15.hostedemail.com: domain of Alan.Robinson@fujitsu.com has no SPF policy when checking 195.245.231.4) smtp.mailfrom=Alan.Robinson@fujitsu.com X-HE-Tag: 1649228715-844892 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christoph, On Wed, Apr 06, 2022 at 06:05:04AM +0000, Christoph Hellwig wrote: > From: Christoph Hellwig > Subject: [PATCH 15/27] block: use bdev_alignment_offset in > part_alignment_offset_show > > Replace the open coded offset calculation with the proper helper. > This is an ABI change in that the -1 for a misaligned partition is > properly propagated, which can be considered a bug fix and maches s/maches/matches/ > what is done on the whole device. > > Signed-off-by: Christoph Hellwig > --- > block/partitions/core.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/block/partitions/core.c b/block/partitions/core.c > index 2ef8dfa1e5c85..240b3fff521e4 100644 > --- a/block/partitions/core.c > +++ b/block/partitions/core.c > @@ -200,11 +200,7 @@ static ssize_t part_ro_show(struct device *dev, > static ssize_t part_alignment_offset_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct block_device *bdev = dev_to_bdev(dev); > - > - return sprintf(buf, "%u\n", > - queue_limit_alignment_offset(&bdev_get_queue(bdev)->limits, > - bdev->bd_start_sect)); > + return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev))); Should this now be %d instead of %u, there are one or two examples of both in the rest of the patch series. Alan