From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F00A6C433EF for ; Tue, 19 Jul 2022 14:13:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D84B6B0072; Tue, 19 Jul 2022 10:13:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 688D06B0073; Tue, 19 Jul 2022 10:13:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 551996B0074; Tue, 19 Jul 2022 10:13:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 456B36B0072 for ; Tue, 19 Jul 2022 10:13:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1C17740169 for ; Tue, 19 Jul 2022 14:13:48 +0000 (UTC) X-FDA: 79704042936.03.4DA1120 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf14.hostedemail.com (Postfix) with ESMTP id 8931B10009F for ; Tue, 19 Jul 2022 14:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658240026; x=1689776026; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=/UxCRrCRwzJ4X66ZQ0IeKBQtuQGxvYag5toGoeMRWuQ=; b=LiCdBARKFxFQfYOjJnLBcY1qw0aenmDIrc+hFBIvEaDoC6ViGj1Z0OAg +5wDZUdxjXtN57moZvYob1uINA64e0p6pyGQUe8AuntM85lX0HzB/c0o1 jW3SlUZHNWUDgauGA1DKSFO8v99z7PyQsTQveDoODl/PULUdilhavucP1 2mLThdXTo74GY7kBvA8S9OfTa2X+s4EKmwt/GTRqcoHYuWoXAK53/TaJV lOMug+tDgrXVvvOMr8XSevYGkgd1YvHBpAE/+2DrA6fsM7KQ61e9C/VUA d5DnPpMOcEVriOgdJEETL4kpOIl+PS5RZTkXYz5MT/M7wXKwcRtKUcCIx w==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="273334135" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="273334135" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 07:13:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="655776691" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by fmsmga008.fm.intel.com with ESMTP; 19 Jul 2022 07:13:34 -0700 Date: Tue, 19 Jul 2022 22:08:43 +0800 From: Chao Peng To: "Gupta, Pankaj" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Subject: Re: [PATCH v7 11/14] KVM: Register/unregister the guest private memory regions Message-ID: <20220719140843.GA84779@chaop.bj.intel.com> Reply-To: Chao Peng References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-12-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LiCdBARK; spf=none (imf14.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658240026; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SUp0IJK1MTDzDkEpHLjHH9qAwnOBJS4Zu5Or7K+TQ6Q=; b=HpyZ6Tg6jmEZ4WhxwMIQYlMMViCGjOug/osnkdwRj3wCBhuIxqBu3FZKHhli2LbknFG9L0 jp9RoE466vLhOHqF4uOqmN+RU/Pv9CK/Zx7zOzryYvdKUSv8eEEpdQ+K7j84PEifnajYnA 50T5KmmN/yAyd0wveQpGV6MFB0lQdpA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658240026; a=rsa-sha256; cv=none; b=VDD37TL4U0Y9n4xkCrN6pJFgoInOhi/kaqyXJMFBGwm4ZhIbzHf8TubfxgqG+uq9ny+0gW UdB1kSf5R8xVbeG95qXFnj0VM5nq6+sSolTADaZjprnn2g5+mqb8dz+2ZQode8miWazswQ YxIbyWG9MtBLUamN2baiNUdNuoHsyFM= X-Rspam-User: X-Rspamd-Queue-Id: 8931B10009F Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LiCdBARK; spf=none (imf14.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: xdsw4jsb6aw8uqtymztfn85h6e37s9zg X-Rspamd-Server: rspam07 X-HE-Tag: 1658240026-128807 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 19, 2022 at 10:00:23AM +0200, Gupta, Pankaj wrote: ... > > +bool __weak kvm_arch_private_mem_supported(struct kvm *kvm) > > +{ > > + return false; > > +} > > Does this function has to be overriden by SEV and TDX to support the private > regions? Yes it should be overridden by architectures which want to support it. > > > + > > static int check_memory_region_flags(const struct kvm_user_mem_region *mem) > > { > > u32 valid_flags = KVM_MEM_LOG_DIRTY_PAGES; > > @@ -4689,6 +4729,22 @@ static long kvm_vm_ioctl(struct file *filp, > > r = kvm_vm_ioctl_set_memory_region(kvm, &mem); > > break; > > } > > +#ifdef CONFIG_HAVE_KVM_PRIVATE_MEM > > + case KVM_MEMORY_ENCRYPT_REG_REGION: > > + case KVM_MEMORY_ENCRYPT_UNREG_REGION: { > > + struct kvm_enc_region region; > > + > > + if (!kvm_arch_private_mem_supported(kvm)) > > + goto arch_vm_ioctl; > > + > > + r = -EFAULT; > > + if (copy_from_user(®ion, argp, sizeof(region))) > > + goto out; > > + > > + r = kvm_vm_ioctl_set_encrypted_region(kvm, ioctl, ®ion); > > this is to store private region metadata not only the encrypted region? Correct. > > Also, seems same ioctl can be used to put other regions (e.g firmware, later > maybe DAX backend etc) into private memory? Possibly. Depends on what exactly the semantics is. If just want to set those regions as private current code already support that. Chao > > > + break; > > + } > > +#endif > > case KVM_GET_DIRTY_LOG: { > > struct kvm_dirty_log log; > > @@ -4842,6 +4898,7 @@ static long kvm_vm_ioctl(struct file *filp, > > r = kvm_vm_ioctl_get_stats_fd(kvm); > > break; > > default: > > +arch_vm_ioctl: > > r = kvm_arch_vm_ioctl(filp, ioctl, arg); > > } > > out: >