From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC6AC433EF for ; Tue, 19 Jul 2022 14:17:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E60C6B0072; Tue, 19 Jul 2022 10:17:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 096AF6B0074; Tue, 19 Jul 2022 10:17:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9FDE6B0075; Tue, 19 Jul 2022 10:17:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DB0D26B0072 for ; Tue, 19 Jul 2022 10:17:45 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BBB0F21274 for ; Tue, 19 Jul 2022 14:17:45 +0000 (UTC) X-FDA: 79704052890.28.1794D2E Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf05.hostedemail.com (Postfix) with ESMTP id 2112F100071 for ; Tue, 19 Jul 2022 14:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658240265; x=1689776265; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=uCiOnx7XhlhIdPTfR9PaYhGj+08ZCZ+aPucYOLw91eY=; b=RcL26P5ETx5Rb3i8XpOQLjSGhKkeNTJY3X2rGdMqerQMlHiJ4mP5qrtC q0lLeThEs1OfN3GfqR+cFPTDyLeBCc18SjEragk4pF7237WVxqpG+hYTp Eb6nTCKwiWklZ6EgUhkrWa+hXjqZ3HqcqEcBXvwdmmreFOrCGTwnQOlrq RCn0fI7Ya9KOoW2g3xCRb/aenNIbxgKgneQk59/H96A4+f/Tqd4b55oAs a907OQPPNsv6R/WUnskhgJ3ns3ptLIDLrtUCCig8WRmxonukKmoe3NBiy rkXQ07L5t76dNDC3w6M4JTz1EZ8IQZNlkpYIXaI5V/Tzu5Yy1kFRTw5sz A==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="287652878" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="287652878" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 07:17:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="655777767" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by fmsmga008.fm.intel.com with ESMTP; 19 Jul 2022 07:17:33 -0700 Date: Tue, 19 Jul 2022 22:12:43 +0800 From: Chao Peng To: "Gupta, Pankaj" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Subject: Re: [PATCH v7 13/14] KVM: Enable and expose KVM_MEM_PRIVATE Message-ID: <20220719141243.GB84779@chaop.bj.intel.com> Reply-To: Chao Peng References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-14-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658240265; a=rsa-sha256; cv=none; b=TbmF4KGTI7hvpVGchkd+T6B82d9LgBS2llEbDwlfBevgbM8pjS11JAp80vhKoi//GAXu9A 9k2cc/zA1fGNI+dFTIz202BCCxkjw33PaWh+x4sLX2qpk+6gl/aWsa2xRTjyxNl43afkwl ljDybx5zqefP3tMsNPBpUXEvGnGFZTM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RcL26P5E; spf=none (imf05.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658240265; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rwdeFKVPUuOBakf6ZqpYMe7Er/6fZBwzs6Z/OaKnR+A=; b=aBcRacb1acVH/WKibkGXScAtwkYjbFauxKhlzNc7Z8hMei4Q6l4+2Q/a3m+/N7nodjNy29 TlUAikkyK195GUAGbcIarhLH1pDlSahEza6uz1mEmqofKJTPsQB03hp/vFHLjP0B++0MZx woF+ioBLJa0JexLtBEmZk+MT8qf8JCc= X-Stat-Signature: pkcq3ktedgk4t61uuc5x7xuhbm1uom8i X-Rspamd-Queue-Id: 2112F100071 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RcL26P5E; spf=none (imf05.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1658240264-730900 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 19, 2022 at 11:55:24AM +0200, Gupta, Pankaj wrote: ... > > @@ -4712,12 +4813,10 @@ static long kvm_vm_ioctl(struct file *filp, > > (u32 __user *)(argp + offsetof(typeof(mem), flags)))) > > goto out; > > - if (flags & KVM_MEM_PRIVATE) { > > - r = -EINVAL; > > - goto out; > > - } > > - > > - size = sizeof(struct kvm_userspace_memory_region); > > + if (flags & KVM_MEM_PRIVATE) > > + size = sizeof(struct kvm_userspace_memory_region_ext); > > Not sure if we use kvm_userspace_memory_region_ext or kvm_user_mem_region, > just for readability. Somehow, but majorly for code maintainability, kvm_user_mem_region is designed to be the alias of kvm_userspace_memory_region_ext so in the code we can access the 'unpacked' fields using something like 'mem.usersapce_addr' instead of 'mem.region.userspace_addr'. Chao > > > + else > > + size = sizeof(struct kvm_userspace_memory_region); > > if (copy_from_user(&mem, argp, size)) > > goto out;