From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D30A8C00140 for ; Wed, 10 Aug 2022 08:24:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CBEA8E0002; Wed, 10 Aug 2022 04:24:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17ADB8E0001; Wed, 10 Aug 2022 04:24:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06ACB8E0002; Wed, 10 Aug 2022 04:24:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC9AF8E0001 for ; Wed, 10 Aug 2022 04:24:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BE8DDA10F0 for ; Wed, 10 Aug 2022 08:24:41 +0000 (UTC) X-FDA: 79782996762.18.AFEB77B Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf23.hostedemail.com (Postfix) with ESMTP id 17F86140162 for ; Wed, 10 Aug 2022 08:24:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660119881; x=1691655881; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=6kT9mTMxRWS6E11jw9PH26Anrkm3qIMlLthMQe7yaTk=; b=Pu64oNjqtVYbOtW0yOYHJ8LcHu5+iFCpTqGlYRJvGj8sr6WJu4yOKulU YN4VS6UpMULMFDmo9+LS0Cm8x3tHfbH6o/FawQjfAZyqlaJp71u94tJe+ XtxbiMiNAMjnF7wLf7gy+ssZUyWsaPmOs3gD8tzholYLKcTKqUiiF2osy aXaDWt+/0ssCfUZtCnVJ6V2OxAmENfh84D5BVc4yvshQ7cQj/rFHrT+CI +KmyG4iUniuxFjdUiNV/xtyprS3Zkn6T4Cne74eTIv/081d7MZu+pPzmN b3Zc3K8PoRDgiDXX844NkPgqvONtsb9u9jje2WVS5y5pcYzZeFCKp4+cF Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10434"; a="289784600" X-IronPort-AV: E=Sophos;i="5.93,226,1654585200"; d="scan'208";a="289784600" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 01:24:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,226,1654585200"; d="scan'208";a="601738890" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga007.jf.intel.com with ESMTP; 10 Aug 2022 01:24:29 -0700 Date: Wed, 10 Aug 2022 16:19:43 +0800 From: Chao Peng To: Isaku Yamahata Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Subject: Re: [PATCH v7 07/14] KVM: Use gfn instead of hva for mmu_notifier_retry Message-ID: <20220810081943.GB862421@chaop.bj.intel.com> Reply-To: Chao Peng References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-8-chao.p.peng@linux.intel.com> <20220804071044.GA4091749@ls.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220804071044.GA4091749@ls.amr.corp.intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660119881; a=rsa-sha256; cv=none; b=v9LJzMixJ/aMStashCjq8YdhJlHxvVgGcPVQ0ZldCkS6VKF/CidJ8RZCchJoCpmzuQ4OnN p0GUK2oUV8dyUkvMCmskrJTE3nJHRMpOAyWQ+8cKlpj96gviNxGQTkDa8ugPdmCxq2m+X2 cAGWqwSOgA6fJZsaffIhS8ndnT+HZwk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Pu64oNjq; spf=none (imf23.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660119881; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cz8m6chbASf47lgrqtg1rj6jowVhGwx8x4pxZppOQJo=; b=zeyPFlvpt2SnzKdhbumYIJJCo6uFWKhKHm9CL9Ucw5okdTLYVkk33J+CzjMlrryxzNBrdQ YVHmWPSKg2V/vDbFAehVv+Rwk1SBV43/MqtImql33au5Bdr9PCswp2MpcNrFB/cGwET6A0 ftOuMLWIzgSPj7Dff147gJGGOTq8KSk= X-Rspamd-Queue-Id: 17F86140162 Authentication-Results: imf23.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Pu64oNjq; spf=none (imf23.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 75w74sgiz1taesa35wki77xnr36zu8gg X-HE-Tag: 1660119880-561396 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 04, 2022 at 12:10:44AM -0700, Isaku Yamahata wrote: > On Wed, Jul 06, 2022 at 04:20:09PM +0800, > Chao Peng wrote: > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 0bdb6044e316..e9153b54e2a4 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -1362,10 +1362,8 @@ void kvm_mmu_free_memory_cache(struct kvm_mmu_memory_cache *mc); > > void *kvm_mmu_memory_cache_alloc(struct kvm_mmu_memory_cache *mc); > > #endif > > > > -void kvm_inc_notifier_count(struct kvm *kvm, unsigned long start, > > - unsigned long end); > > -void kvm_dec_notifier_count(struct kvm *kvm, unsigned long start, > > - unsigned long end); > > +void kvm_inc_notifier_count(struct kvm *kvm, gfn_t start, gfn_t end); > > +void kvm_dec_notifier_count(struct kvm *kvm, gfn_t start, gfn_t end); > > > > long kvm_arch_dev_ioctl(struct file *filp, > > unsigned int ioctl, unsigned long arg); > > The corresponding changes in kvm_main.c are missing. Exactly! Actually it's in the next patch while it should indeed in this patch. Chao > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index b2c79bef61bd..0184e327f6f5 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -711,8 +711,7 @@ static void kvm_mmu_notifier_change_pte(struct mmu_notifier *mn, > kvm_handle_hva_range(mn, address, address + 1, pte, kvm_set_spte_gfn); > } > > -void kvm_inc_notifier_count(struct kvm *kvm, unsigned long start, > - unsigned long end) > +void kvm_inc_notifier_count(struct kvm *kvm, gfn_t start, gfn_t end) > { > /* > * The count increase must become visible at unlock time as no > @@ -786,8 +785,7 @@ static int kvm_mmu_notifier_invalidate_range_start(struct mmu_notifier *mn, > return 0; > } > > -void kvm_dec_notifier_count(struct kvm *kvm, unsigned long start, > - unsigned long end) > +void kvm_dec_notifier_count(struct kvm *kvm, gfn_t start, gfn_t end) > { > /* > * This sequence increase will notify the kvm page fault that > > > -- > Isaku Yamahata