From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C490C38145 for ; Fri, 2 Sep 2022 12:30:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77E39800D2; Fri, 2 Sep 2022 08:30:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7064E8D001B; Fri, 2 Sep 2022 08:30:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57FE5800D2; Fri, 2 Sep 2022 08:30:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 451CD8D001B for ; Fri, 2 Sep 2022 08:30:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 100531201FB for ; Fri, 2 Sep 2022 12:30:26 +0000 (UTC) X-FDA: 79867078452.25.9568508 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf12.hostedemail.com (Postfix) with ESMTP id 33B3240067 for ; Fri, 2 Sep 2022 12:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662121825; x=1693657825; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fDpXS+mwMN4S7KTgnVwvjs5feZwWXlXraJAIEBzDX2M=; b=T/FSaECFwNLo/PLZf5m0tTCCHQ8Epo8nVIaptmk+rRrumD2pQCxFPydj l94DIlWBpJTaTMxwHFd3NPllBKhFs5rgw1bts8FI5gasVpc3QbT8PnOCy Z45HWX3XtvPkkg5AgcX8Ur51fFtty8cYZJ0zb15LjhfLEAFZD0I7SORov soQB6IpnnBRlS0KW64gO8Fgnuf83l973P81qRHrqWUedsE5hxYedTyW0J GMwSqpWIBW3NpPx684vBzeEQGYXFnVFwqseenTlFiWJH6qU+gihlJuK24 Ys2X4L6WwNAYRekHNsSOBS7Q9aXn4HpMJBPENx9H4gDsFa866GxR2H3iR w==; X-IronPort-AV: E=McAfee;i="6500,9779,10457"; a="282955861" X-IronPort-AV: E=Sophos;i="5.93,283,1654585200"; d="scan'208";a="282955861" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 05:30:23 -0700 X-IronPort-AV: E=Sophos;i="5.93,283,1654585200"; d="scan'208";a="674338766" Received: from azmijews-mobl2.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.45.129]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 05:30:12 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 5AC6D10484B; Fri, 2 Sep 2022 15:30:10 +0300 (+03) Date: Fri, 2 Sep 2022 15:30:10 +0300 From: "Kirill A . Shutemov" To: Chao Peng Cc: Hugh Dickins , "Kirill A. Shutemov" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song , "Gupta, Pankaj" , Elena Reshetova Subject: Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory Message-ID: <20220902123010.zfyv6apmo3v67a2i@box.shutemov.name> References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220818132421.6xmjqduempmxnnu2@box> <20220820002700.6yflrxklmpsavdzi@box.shutemov.name> <20220831142439.65q2gi4g2d2z4ofh@box.shutemov.name> <20220902102757.GB1712673@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220902102757.GB1712673@chaop.bj.intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662121825; a=rsa-sha256; cv=none; b=BC14jWUJWoUiKQ5hu0XxiBSXJW3ax+vtUFRM6PCvWMlTrB8XzSbD2fNywxK4xeRtWA55O8 NEFB7XNVkVP7rpnZlz5IJ3KLWVaszKZh+MC/WjXocYA3jyrk69MLhHx2R2sBs8LJvp1eSv WjzpkKmPGQTU9v4YOx1EX1ZEDkb+S/w= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="T/FSaECF"; spf=none (imf12.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662121825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nBjVXmSlczMt63tNmrVY6UrEbVKjwZkzdcEg/HWlM8w=; b=q7FD+Us3VE33HtYfrBhUD4K8eyUX+Y1OGM+i2yMSzXLZayBXRmyhwM6UU0zQBujVchjPW6 xYP4YS616Y7ms3f8Ly+K7p8pgmAv3zK7qrT32izDhsU52MG9qGLuosADQrVG0WHn2SlI9s VooDlifI0I2o8RvQA5j/uYIgD3YtsWs= X-Stat-Signature: ftpp4btxfent8kq8k3nhcgyund8ai8oh X-Rspam-User: X-Rspamd-Queue-Id: 33B3240067 X-Rspamd-Server: rspam07 Authentication-Results: imf12.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="T/FSaECF"; spf=none (imf12.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-HE-Tag: 1662121824-461004 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 02, 2022 at 06:27:57PM +0800, Chao Peng wrote: > > + if (flags & MFD_INACCESSIBLE) { > > + struct file *inaccessible_file; > > + > > + inaccessible_file = memfd_mkinaccessible(file); > > + if (IS_ERR(inaccessible_file)) { > > + error = PTR_ERR(inaccessible_file); > > + goto err_file; > > + } > > The new file should alse be marked as O_LARGEFILE otherwise setting the > initial size greater than 2^31 on the fd will be refused by ftruncate(). > > + inaccessible_file->f_flags |= O_LARGEFILE; > + Good catch. Thanks. I will modify memfd_mkinaccessible() to do this. -- Kiryl Shutsemau / Kirill A. Shutemov