From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01BDAC352A1 for ; Wed, 7 Dec 2022 06:34:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 244CF8E0003; Wed, 7 Dec 2022 01:34:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CC888E0001; Wed, 7 Dec 2022 01:34:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 045D48E0003; Wed, 7 Dec 2022 01:34:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E489C8E0001 for ; Wed, 7 Dec 2022 01:34:15 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B8FEF409F8 for ; Wed, 7 Dec 2022 06:34:15 +0000 (UTC) X-FDA: 80214545670.04.A4B5317 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 66FF040003 for ; Wed, 7 Dec 2022 06:34:15 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="CKqZ/l9P"; spf=pass (imf27.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670394855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C15cHp35UgTVcGwyWVF0FgqoGcE+bZVU/5tK1HiVhGg=; b=HDwXRACb5vX9JCasWh7tSl9OHpIJ6nK8WcLDzL3Bl3XMXVG48sMCLAwtYZHf8bJmf/OvM+ DcJAjryoXeb5j5hgP6ddr4VFoxjm5hpnXQdM0QxYTzcJ0+synB78oJnO/EDk2vK92HZ6IG oBzjMgNZhAUwDFCVuw3isSxJldvVy+0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="CKqZ/l9P"; spf=pass (imf27.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670394855; a=rsa-sha256; cv=none; b=zJPqCXjTR4+ee7SJIqXtSWqcXnoVKJIuNM69ORA+4Z0eL2siL4v+L/WBjVx3mcRIeT63d3 kraGwDGuX/gA/GP5WZS3w9WQgOzl3B+iTBUUgEfSjxKtiur/KC9VHw9Up9wX7MrAK7CQZh nSjvBZXUdtMfoW/pb7kKu2EKwwPJh/Q= Received: by mail-pl1-f173.google.com with SMTP id jl24so16155730plb.8 for ; Tue, 06 Dec 2022 22:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C15cHp35UgTVcGwyWVF0FgqoGcE+bZVU/5tK1HiVhGg=; b=CKqZ/l9PnwBZEtXNtp4aPBttpJeA89ZaQxsLN+jKw3eUVeg9N70IqMgdpBhfmoMdRN wnNcjMkoLzHDq6uSVjjvzsYnerZjG1HIAwRJ1o5QS5Yp8oNstErg28aAus8PdaoLeqx3 f2++jCdgHb8lDQ6ETyzyDMSqpkHcnxdDTU7zRBcFo3QBH9uNzewTIfvJ1efH8a1UHYv+ dz6o9xbAOwTWr7xaQjDIg+nKseYPUY71PlOmzpnNJTkqlzgQvjmD1yQTL6sJfRdqQoUC XKpDVo69w4cJKZZVhcBHWOWsfC+8Xh7NT3VFznBfTVfB1ab0ptONygi3M5nMJitgBbY6 fyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C15cHp35UgTVcGwyWVF0FgqoGcE+bZVU/5tK1HiVhGg=; b=j5n3569EwsaUun7CTHihDZoLimBCDi7VDLMPHkL1j/i8RsQY9ax5d7kdiPc2+zBIJe hIqtsj6jr/J5qCDdRRk4YRgwbio9r0Z0XKwXlT/3kvrvjmzQt01BNpt8kLF1wvZLbUIl Zxhllho9AuEBWGQlSvXUYm1CC4wLvc2yb5Q8lVh0NWqfA2fd+pq35ZKswrUOvJST3ne3 Rjo+20n1wqRPVvqvleQUMxrCBBWbWXjRNIUZWRX2AUcpHL8/PhHFYaHyjgkf/8a3+R3+ ADZIwnZ4Kfmrlmx5M+4oDghhPr++terHiTpeOqSq2/w7atTJuR4E6AxtmybEqViIsPTC Nadw== X-Gm-Message-State: ANoB5pm0Vna++swon6/ktjGqcnrPUqcIDBr8ZwhD3jP2SfAgaeEF9SDn fBICsoBljkAmmHwoh1nzGRw= X-Google-Smtp-Source: AA0mqf7ST4xuwmjyV+Fg/LkYpzDRbEp/+IDjSth6MZo3us+POloNmlOnA05Cq/8ntpMh4DvZF8JHuw== X-Received: by 2002:a17:90a:9313:b0:213:2168:1c78 with SMTP id p19-20020a17090a931300b0021321681c78mr99342910pjo.72.1670394853895; Tue, 06 Dec 2022 22:34:13 -0800 (PST) Received: from localhost ([192.55.54.55]) by smtp.gmail.com with ESMTPSA id x6-20020a623106000000b005745eb7eccasm12686643pfx.112.2022.12.06.22.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 22:34:12 -0800 (PST) Date: Tue, 6 Dec 2022 22:34:11 -0800 From: Isaku Yamahata To: Chao Peng Cc: Fuad Tabba , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, wei.w.wang@intel.com, isaku.yamahata@gmail.com Subject: Re: [PATCH v10 5/9] KVM: Use gfn instead of hva for mmu_notifier_retry Message-ID: <20221207063411.GB3632095@ls.amr.corp.intel.com> References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-6-chao.p.peng@linux.intel.com> <20221206115623.GB1216605@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221206115623.GB1216605@chaop.bj.intel.com> X-Stat-Signature: 44oyazupguzo1gzuh1dkgsfybg5euoeo X-Rspam-User: X-Spamd-Result: default: False [2.61 / 9.00]; SORBS_IRL_BL(3.00)[209.85.214.173:from]; BAYES_HAM(-2.99)[91.66%]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_GT_50(0.00)[50]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; TAGGED_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_COUNT_THREE(0.00)[3]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; TAGGED_RCPT(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 66FF040003 X-Rspamd-Server: rspam06 X-HE-Tag: 1670394855-829980 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 06, 2022 at 07:56:23PM +0800, Chao Peng wrote: > > > - if (unlikely(kvm->mmu_invalidate_in_progress) && > > > - hva >= kvm->mmu_invalidate_range_start && > > > - hva < kvm->mmu_invalidate_range_end) > > > - return 1; > > > + if (unlikely(kvm->mmu_invalidate_in_progress)) { > > > + /* > > > + * Dropping mmu_lock after bumping mmu_invalidate_in_progress > > > + * but before updating the range is a KVM bug. > > > + */ > > > + if (WARN_ON_ONCE(kvm->mmu_invalidate_range_start == INVALID_GPA || > > > + kvm->mmu_invalidate_range_end == INVALID_GPA)) > > > > INVALID_GPA is an x86-specific define in > > arch/x86/include/asm/kvm_host.h, so this doesn't build on other > > architectures. The obvious fix is to move it to > > include/linux/kvm_host.h. > > Hmm, INVALID_GPA is defined as ZERO for x86, not 100% confident this is > correct choice for other architectures, but after search it has not been > used for other architectures, so should be safe to make it common. INVALID_GPA is defined as all bit 1. Please notice "~" (tilde). #define INVALID_GPA (~(gpa_t)0) -- Isaku Yamahata