From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B62C4708E for ; Wed, 7 Dec 2022 15:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 686168E0005; Wed, 7 Dec 2022 10:19:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 635F08E0001; Wed, 7 Dec 2022 10:19:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7018E0005; Wed, 7 Dec 2022 10:19:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3F2CF8E0001 for ; Wed, 7 Dec 2022 10:19:10 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E9CA8160A33 for ; Wed, 7 Dec 2022 15:19:09 +0000 (UTC) X-FDA: 80215868418.29.14491C0 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf15.hostedemail.com (Postfix) with ESMTP id 2968CA0002 for ; Wed, 7 Dec 2022 15:19:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fZZyXLVY; spf=none (imf15.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670426349; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mNFmn9tV1wS1dhLKrTRMxzFcEnRphcHuzHYZmp+kJN4=; b=6Vso02XZOrGney1uUiVDA67tnF41diyUa0H0cuWpsB4T4vleP4xP7Ix8gY11Rwz5ok+biQ 7IhnKtHsBeowH1gJNV8KINMjPSfUsmJ9yMyQThVgXNIB7V8FS/WPynjI5jzMqozK/qRsYA VyqkXiP67Q3Ek/Mx0Ru32EgpCy4UoyY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fZZyXLVY; spf=none (imf15.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670426349; a=rsa-sha256; cv=none; b=5hUi96yOyj95/cVDGl+tYqMsCZvJc/jnAYiJv3ZhtGPyFZrsyvkcAtitvVGu5OVrc+JOVW wk3iZdenUBU7e6WDwQSN/fuHLZ3p4tsr/SDj8TS4n/2/LRVXOOLQnvOL8ERjKvD4TFp2j2 QHgJ9+1zciIAKWC2fhDOfKOQ0gt4Axw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670426349; x=1701962349; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=jSuyaBC+CEdahrEMqj1EGdbe+9W/yLc3hrTCB1EDaSs=; b=fZZyXLVY13VF4BLkLl1sHroDxQwU1arr8A4+bdGC1hBRcsuU5h5aEjD/ 1XHFgHuvFGbAxybidIRPxa/F9XkPV7xtSEyB5rA8gTMvYkQRBeoCMeoIt 5EX62ZgjHOkAyy+Yqe1cxnCFx+TyFRPX/VKZ2rYBwfhHidKMPGr8wHInf 9MUhWbJu8VA/AqukO2hRnyysG7941qJ/coVZPWXuIxb3WX7dKMPBFlBWl z8KMPi8ZryzOARCqhvZQbuki1qxFXa3r2YbLgEu62N6NM9SPXOh7c9H8C T/zvPgYg12OYjkBRW/8xoN3eLqI4/yHfxSNFTUb8aSQmJeFhNi/8/ifvw w==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="343948398" X-IronPort-AV: E=Sophos;i="5.96,225,1665471600"; d="scan'208";a="343948398" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2022 07:19:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="710096874" X-IronPort-AV: E=Sophos;i="5.96,225,1665471600"; d="scan'208";a="710096874" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by fmsmga008.fm.intel.com with ESMTP; 07 Dec 2022 07:18:57 -0800 Date: Wed, 7 Dec 2022 23:14:37 +0800 From: Chao Peng To: Isaku Yamahata Cc: Fuad Tabba , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 5/9] KVM: Use gfn instead of hva for mmu_notifier_retry Message-ID: <20221207151437.GF1275553@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-6-chao.p.peng@linux.intel.com> <20221206115623.GB1216605@chaop.bj.intel.com> <20221207063411.GB3632095@ls.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207063411.GB3632095@ls.amr.corp.intel.com> X-Stat-Signature: o1r3sc8uy8ejc59aqogn7pbmma8msbiq X-Rspam-User: X-Spamd-Result: default: False [-3.48 / 9.00]; BAYES_HAM(-5.28)[98.41%]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[intel.com,none]; R_DKIM_ALLOW(-0.20)[intel.com:s=Intel]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWELVE(0.00)[49]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[intel.com:+]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_SOME(0.00)[]; TAGGED_RCPT(0.00)[]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[chao.p.peng@linux.intel.com] X-Rspamd-Queue-Id: 2968CA0002 X-Rspamd-Server: rspam06 X-HE-Tag: 1670426348-39360 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 06, 2022 at 10:34:11PM -0800, Isaku Yamahata wrote: > On Tue, Dec 06, 2022 at 07:56:23PM +0800, > Chao Peng wrote: > > > > > - if (unlikely(kvm->mmu_invalidate_in_progress) && > > > > - hva >= kvm->mmu_invalidate_range_start && > > > > - hva < kvm->mmu_invalidate_range_end) > > > > - return 1; > > > > + if (unlikely(kvm->mmu_invalidate_in_progress)) { > > > > + /* > > > > + * Dropping mmu_lock after bumping mmu_invalidate_in_progress > > > > + * but before updating the range is a KVM bug. > > > > + */ > > > > + if (WARN_ON_ONCE(kvm->mmu_invalidate_range_start == INVALID_GPA || > > > > + kvm->mmu_invalidate_range_end == INVALID_GPA)) > > > > > > INVALID_GPA is an x86-specific define in > > > arch/x86/include/asm/kvm_host.h, so this doesn't build on other > > > architectures. The obvious fix is to move it to > > > include/linux/kvm_host.h. > > > > Hmm, INVALID_GPA is defined as ZERO for x86, not 100% confident this is > > correct choice for other architectures, but after search it has not been > > used for other architectures, so should be safe to make it common. > > INVALID_GPA is defined as all bit 1. Please notice "~" (tilde). > > #define INVALID_GPA (~(gpa_t)0) Thanks for mention. Still looks right moving it to include/linux/kvm_host.h. Chao > -- > Isaku Yamahata