From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B387C4332F for ; Fri, 9 Dec 2022 06:29:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7924E8E0003; Fri, 9 Dec 2022 01:29:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 741528E0001; Fri, 9 Dec 2022 01:29:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 630338E0003; Fri, 9 Dec 2022 01:29:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 534228E0001 for ; Fri, 9 Dec 2022 01:29:08 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0D6A581084 for ; Fri, 9 Dec 2022 06:29:08 +0000 (UTC) X-FDA: 80221790376.24.07CD439 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf05.hostedemail.com (Postfix) with ESMTP id DE711100005 for ; Fri, 9 Dec 2022 06:29:04 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jWF6W82W; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf05.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=chao.p.peng@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670567345; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UDQGjURzpCjyP5tm/3ngkpMvYhuhoMbOM7jc7MXgYoE=; b=1ZLiIC2X2owjYjaDmUXuQoUFIFkQkvsI9TXCkXrsd2HQHwACaBZu65BoafY1X1Q/cTqBVR fxn6hovcOeEjYG/DXrqcgtE+PL9HIc+QNJBFPNFoh8Yp3vQlZJrtmsxN79E2OhfloCj9Rc fqZQ4oIoexN5Lc2sDV2kOQ5Mw850CU4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jWF6W82W; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf05.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=chao.p.peng@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670567345; a=rsa-sha256; cv=none; b=cMm1MxOBe/D7E7BMC693qhE9onayr1gLJ/iOx+O3FZOeh0aLhBMrxzUMDAeqr/rBh7i67e LO1osAMUTBtenlzatEohy3Me+9ha3WpRgZJgECRdnQ3D4s3VBDgZ3w3Oi0h/fn1HoB+QlS 8tL/0J1e5fkzIaIVQLSq3xGv0d7C5mM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670567345; x=1702103345; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=Tlu8CMGwsT7F5T0zdAfMh3PoUym3LStYGuVUhIigsRU=; b=jWF6W82WYVo1ybB2c3kLTufMp4wvPyJtd7MCJybwsOTMWp2Ba2X7IeNV gO5bghtXGlN5kRS0DjncZ5wMcH7xbp9q1rfy5E1MVy+TAnNPz9EPHiCkn DtIVB4qDHTIVmbG7IEI4/g2WCqB4Hy0oj3lkr6VB1KZY0Wdxb/C6nqmCw gH+IxQ0eG53+ZGrRDOq1L4vf/TLrLk6EnPenlbqgSvRdv6bs27rFb1owW B3br8nIGV8jourwaA256+1MWVTG8timmLrqUx9sT8c/xLCEBFlh3xFEVR i/O1IMnWvMbvnYrgZ/IaymAZtK6cvkOpyJf6kQas0bSuMnsKisUMHyW7H w==; X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="403646392" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="403646392" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 22:29:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="640921316" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="640921316" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga007.jf.intel.com with ESMTP; 08 Dec 2022 22:28:50 -0800 Date: Fri, 9 Dec 2022 14:24:31 +0800 From: Chao Peng To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 5/9] KVM: Use gfn instead of hva for mmu_notifier_retry Message-ID: <20221209062431.GA1342934@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-6-chao.p.peng@linux.intel.com> <20221206115623.GB1216605@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DE711100005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: tm71ng1dp9ycnco7h4wt44h7tjz4imns X-HE-Tag: 1670567344-309154 X-HE-Meta: U2FsdGVkX18Irk/ixa5kgvsspA+trcNARcAUVo8U4t+5zJkyeim07+cLDgCrcypDGU7yIdG+c2OX+83ASFdTeiyLF+zkcNcjWZBdSLzbi53gHMenR1uofjwoxg2Rgbqe7263sGI89xW0SkYp1sprLS9PPcCzcwEul1mxLlEFROwshRkqdbx2yQpSTzqHYqKbgBerkBH8g76JUh//Koq8c07pyR+AskIvpZd35USEX/JoYgvP8UPz+yCI31NUTGxTXQKgaeH9JSX6F0tv/sHtfPXfTIZtvVIZQv0QYruiiWPnKaOHaZlz0E79NsVaA5l+AjziV0/ILwdes8fFd5CfqcAFjvdeMeRt0mxTNno4VjrGyBGRtQorWt57GPUhGS3L6fs+KJXSrsK3X0XU7GQuS7VfJSIyWz/cjfjT7lHIyEuNvITphpW4d6uWlOHupHUW3959kdZsSgFao3cBLI1HaqQyyDB4VaxLubef0UUpYCp5KqUKf0eHoXM5N1EjAxQjTc90FyXlhTYxbvr0BnEJSLiz/enrRYXdu0ph5U2iZ/V+2VodISOdYvT3youyuuI0RbgJR1lKVdoDmw1jq7qEVZXhWflaUg/sh3e9RoItNBpjxeJu/Yoba2vDO0D+tpoJjNAAzzEV2Z/cVeHQb/dOUim4tHSjGEBn1xFYer2P3vndoxZLNhoaZzCF0OGM4rcbK6iXiLgj37f4/waov5o3xeY4fhAeUZLfAns1rhwMaGxCDh0xZkSfAmgPT0C9dJpDSC6oR9PH4qlalQlleiW+D/pH8LiuJkOb/0vuz5nZA17UK3U94dM+HewvrylFARli/yfZPHhfgw3WOxJoijUClAYJ8PcAQOdmoe38anJvHGLV828R1YbeFQGR+mWhLHgvvFR9wpAqy2UM7kGGNnDoczc2L05mKeDXDwqBiJOFLU86Wx38ZRbtRhddbQ9prvu0p04qMGKKOtbklwmmqc9 9bXAGpZH Go2nv9R+s/mVV9skPLq7wvh9dzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 06, 2022 at 03:48:50PM +0000, Fuad Tabba wrote: ... > > > > > > */ > > > > - if (unlikely(kvm->mmu_invalidate_in_progress) && > > > > - hva >= kvm->mmu_invalidate_range_start && > > > > - hva < kvm->mmu_invalidate_range_end) > > > > - return 1; > > > > + if (unlikely(kvm->mmu_invalidate_in_progress)) { > > > > + /* > > > > + * Dropping mmu_lock after bumping mmu_invalidate_in_progress > > > > + * but before updating the range is a KVM bug. > > > > + */ > > > > + if (WARN_ON_ONCE(kvm->mmu_invalidate_range_start == INVALID_GPA || > > > > + kvm->mmu_invalidate_range_end == INVALID_GPA)) > > > > > > INVALID_GPA is an x86-specific define in > > > arch/x86/include/asm/kvm_host.h, so this doesn't build on other > > > architectures. The obvious fix is to move it to > > > include/linux/kvm_host.h. > > > > Hmm, INVALID_GPA is defined as ZERO for x86, not 100% confident this is > > correct choice for other architectures, but after search it has not been > > used for other architectures, so should be safe to make it common. As Yu posted a patch: https://lore.kernel.org/all/20221209023622.274715-1-yu.c.zhang@linux.intel.com/ There is a GPA_INVALID in include/linux/kvm_types.h and I see ARM has already been using it so sounds that is exactly what I need. Chao > > With this fixed, > > Reviewed-by: Fuad Tabba > And the necessary work to port to arm64 (on qemu/arm64): > Tested-by: Fuad Tabba > > Cheers, > /fuad