From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EADC4332F for ; Mon, 19 Dec 2022 08:01:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7875E8E0003; Mon, 19 Dec 2022 03:01:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7376D8E0001; Mon, 19 Dec 2022 03:01:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1A08E0003; Mon, 19 Dec 2022 03:01:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 48AF68E0001 for ; Mon, 19 Dec 2022 03:01:24 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 244A91A09FF for ; Mon, 19 Dec 2022 08:01:24 +0000 (UTC) X-FDA: 80258310888.22.5698847 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf10.hostedemail.com (Postfix) with ESMTP id 17CD6C0021 for ; Mon, 19 Dec 2022 08:01:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CWkHmVR1; spf=none (imf10.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671436882; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h80cLHTaDZD4NJt4TpTdy4lHb4ybeJ3PLdOi0ku45+4=; b=AfrThLGtfUe4vM6wAhsRE/tmz5bQ/M7i51BxRHGltvZQZ+rcsILwdwinmiKQY6mngHlqo4 VIqM5Qm1ACaAQXQBs2vBHaKdNAZVhixa7Vzhg/fEV4ZKo4+/qZ1GgCKlgY0/mTthgvA7nD WUzY5ogMBT0iXjPxEUEoekmKMS3fUV8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CWkHmVR1; spf=none (imf10.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671436882; a=rsa-sha256; cv=none; b=do7kpTqFGLC0f/00yOxBY5YXkYdq5EGZOraiVMCHJOIfXW3c0ClsVYsMSxueRPmOaTHv5y gFnpq+eeadn5DoRUVFGGITNtU3VJOcNDzUfAk1qsXiGibw6M4RNEN7hOfyU8ngUjwgLABr H2mRn3HWmDDDYmsgyOixfHYjUSEirOI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671436882; x=1702972882; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=OfZ8wFDJ+6nAyql1Nd8OAfYvfKbri9zQQ6twPOrF8GY=; b=CWkHmVR1E5hufSqUPkXwVGB1FwTM0GaJSjggh1YZk62mzluqyJNUn4Yk 0EKthgVHH/1PLY4LGQ8Je8EukLITLRRmcHJ+AuCIwtbMgsgT6PHFYMpcn ulBJ2mRCmwGRrxZauL3kd6Mjf4gJLAe9lOYxJqeGh2x3Z1KQdVwwipQ6T TOkhCNcjoubGNio8sbZDl7wrX2it7s+tcBQDtsmIMAJlv6RtYbg+uZsEW QSHYLJaGI/00wyuFKIZ/r5vzlgAVRwcHJuxfT/ZrHVCo8RKPwQqK/79fD c02ikwZtMJMseAvdnYhvXa9Rldhzd5vVPE7DKaOsxY7pYTXGxmCESheP0 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="302716676" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="302716676" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 23:58:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="824757705" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="824757705" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga005.jf.intel.com with ESMTP; 18 Dec 2022 23:54:49 -0800 Date: Mon, 19 Dec 2022 15:50:32 +0800 From: Chao Peng To: Xiaoyao Li Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 3/9] KVM: Extend the memslot to support fd-based private memory Message-ID: <20221219075032.GA1691829@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-4-chao.p.peng@linux.intel.com> <20221208113003.GE1304936@chaop.bj.intel.com> <4d736cc0-f249-6531-c0af-7093c2c2537f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d736cc0-f249-6531-c0af-7093c2c2537f@intel.com> X-Rspamd-Queue-Id: 17CD6C0021 X-Stat-Signature: as53kdnfdkknubrihxbjn38djh3x4ynt X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671436881-777954 X-HE-Meta: U2FsdGVkX18ow30eCwabp2Aa2s4JRjT0koJaVj9XG3HYjfQdDl0m4NvdYTSTyq+0zG6m9kcNIz19HXSXtLxfZiBz3JjUy0WenfgZZh1xdqoztvyzIBJZ2hfVSk9PKatHmmB4EsxvlZZ7rkgoii1oqIBFk31bGAqIoPnv6vIYcb83d+TkzA/waNudb4q9899bUb08OxiI/9rG9J4QK/3xfBIQRfcKTBXRSm+U4FTMROCE8Kpv6WzLOyTPpSc/xL++PacGdPinV1YoSZubSIUyOTVT2KKjBvIs2OedcEamkq76+bNbL3/BlmSe8fea9ya7omoz5DHOoyVTaeUdvCYDr6Cb3KcmyCDAWSggUKgooH9k6ZTjf/EeGDPxOolmBIjdMC2strN9cUND+KduYTeEON2l8QwbnEJOAT3e6B+TV55Cs6Pi0NHlfRjkzASE38Piywgtyi4LGpCwCNlW+WS01Bb15z6SaKnyCeGFIIAkc1dMUZ1nwX3RRZB8c1tIykBw/RQAt5rkTukF8A/hlK/y/t8h2DMSBsDhP0TNTerS2dMMW/pe4fPTnuIGNn5TW8JsjZtvvdQ6DS39ENp99iNjb85tHxoBcV3/giIPXTV8i3X3ilxgpLOEhp5ZVTItZSQ4HVnw4NVTniSfSNieh+NhijYn982TyFqGmllHZuNy/J1clxRnKKLli1wfjjuviqJCOYTp0uKIw9SoHP/PnbDU98wP1PGFcKKjjc2aipUoGTTpK5eEMaVZvO1QOMdglunyx37YHbqcoCZUny0MBFIdCtNYmrJqTU3qNSVoiXcPZvy+66Uit8trPgayBTn/LG2sTZx3WN5zhN5uRs3viLk7dGxdyrSdqRVP/bxyE0uW7o9ZZzyFT9JVfP+n8dlwWX0omCss/+M69NJaMFPqngCHWRP5Du6t7cq5fJOd7nBpf0ozMAk0/UzMh2CwNEK9Sc/FRkVms3I2Ngg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 13, 2022 at 08:04:14PM +0800, Xiaoyao Li wrote: > On 12/8/2022 7:30 PM, Chao Peng wrote: > > On Thu, Dec 08, 2022 at 04:37:03PM +0800, Xiaoyao Li wrote: > > > On 12/2/2022 2:13 PM, Chao Peng wrote: > > > > > > .. > > > > > > > Together with the change, a new config HAVE_KVM_RESTRICTED_MEM is added > > > > and right now it is selected on X86_64 only. > > > > > > > > > > From the patch implementation, I have no idea why HAVE_KVM_RESTRICTED_MEM is > > > needed. > > > > The reason is we want KVM further controls the feature enabling. An > > opt-in CONFIG_RESTRICTEDMEM can cause problem if user sets that for > > unsupported architectures. > > HAVE_KVM_RESTRICTED_MEM is not used in this patch. It's better to introduce > it in the patch that actually uses it. It's being 'used' in this patch by reverse selecting RESTRICTEDMEM in arch/x86/kvm/Kconfig, this gives people a sense where restrictedmem_notifier comes from. Introducing the config with other private/restricted memslot stuff together can also help future supporting architectures better identify what they need do. But those are trivial and moving to patch 08 sounds also good to me. Thanks, Chao > > > Here is the original discussion: > > https://lore.kernel.org/all/YkJLFu98hZOvTSrL@google.com/ > > > > Thanks, > > Chao