From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE23C3DA7C for ; Wed, 21 Dec 2022 13:47:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1E8D8E0002; Wed, 21 Dec 2022 08:47:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA85B8E0001; Wed, 21 Dec 2022 08:47:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A48448E0002; Wed, 21 Dec 2022 08:47:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9133B8E0001 for ; Wed, 21 Dec 2022 08:47:18 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 705F540253 for ; Wed, 21 Dec 2022 13:47:18 +0000 (UTC) X-FDA: 80266440156.18.72FCFEE Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf05.hostedemail.com (Postfix) with ESMTP id 56D2310001F for ; Wed, 21 Dec 2022 13:47:16 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IMFsZTl1; spf=none (imf05.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671630436; a=rsa-sha256; cv=none; b=6NFfzNOZoU7D2enPXGAZQ9Amij0nndwXIOuoiZuuFmaZOlQEpnm3xuuOS//4NvhZuzFm8T 0m/x57ORyoNbBoZ+22mX0UX+wXA6IEwvOCY677Hiywo8BjgNfoySDDmeIVtSc5DnUeDJ4u 2iRXbundXi9bJFuTY2C7XwmTLGnL6F0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IMFsZTl1; spf=none (imf05.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671630436; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zBUceTxpT7H9MNXVSFHGjKQn56UCY/sFM7g1gUite6w=; b=8qpLwiTf9pPJfyJdrZFjgFZ87PEURCcAiPKeDoxfW6FTcP4honnpa3WJ4Jzm0wqHy8b/pt 40+4mAxuAWr691QWaPyrBtpO3l/avbYrkG6np9YNcqg4znanIdp5vdzfCY4W57LWv304s8 PK3bRqHI1EEHymnQ0ykhcQ9Av/3x3+k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671630436; x=1703166436; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=Ey/uI44qPCpd4ueyxtxDLkQhSghq6Fbj8dB2OhBP0No=; b=IMFsZTl1jM8q5Vepef2Mx53Z1OydbQ0FksDeTh6kfVhgVf4drWgFO0i+ m325odoy/XGNAWWDha9ZYvPY3KA+lqpPqEhD5WMe8oVGx1FnCdvlDzZMx Ebt0IqozKQ493fzuLF1ccfSCHpF9jGmrnqURP4aHYfp85FtaYTi0dlLoa Fd6mx+lqQ8KuHLZbTip9F6hLcybqIP/tXGC4sDVYep5F5sybo/cYIWXy3 O17nj6SdnXre3l8TGO0E5zyYFe834QJYgDDJV3Dtk4nRcoOaqYwftQi+N SK4nsxCMHzSbJicR2B0bUG4kQtFtqDqXok0nLr8odgpHuTiKQu88yuSk0 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="318568474" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="318568474" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 05:47:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="651402272" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="651402272" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga002.jf.intel.com with ESMTP; 21 Dec 2022 05:47:03 -0800 Date: Wed, 21 Dec 2022 21:42:46 +0800 From: Chao Peng To: Borislav Petkov Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 3/9] KVM: Extend the memslot to support fd-based private memory Message-ID: <20221221134246.GB1766136@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-4-chao.p.peng@linux.intel.com> <20221220074318.GC1724933@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 56D2310001F X-Rspamd-Server: rspam01 X-Stat-Signature: bpqgf3k3bximz5wywe1u53rsb66m1zx4 X-HE-Tag: 1671630436-102801 X-HE-Meta: U2FsdGVkX1+DPQFuHF/EHMCHP4JaYD5V4Zlj2oz5Uw1x1IMh5+q6WrgevUSnG1wbBPZ8BwgEbVe6X6lncjfAVXD6+LS2xiEp+v8G+FMS3GfTtgdLSSG8gK445rUnQC7wvOp5ypmbUE9yRIhqbqr+Im7oAnj1u8pWsPETiKCBorNhFpGdQafuG5OmHl/qt0QqMAAeQGmvRJYgD9pK42Q9A35gd7+Tmg7GSKomQ60XWc47a2MzUOrMkepmLgNZk2u7XfZHY9FsVqgfNJt34JYVfyu/dXBdw8vtib7pD7nBKBjOg2mqL+OfmWEGjQoxkr9FzR/UV21EFbQzI/m6KPO7hdcycmcPRjdXe5GVeDWSSwwYVKtUYiKytExgdAnowT7MAH66/wI6kUReczKjmfQ8XKW98bCj1hNWA4GKTRXyHw+nSrkWZvBaFKRDGTiJn3SdP528ke9wyLF0KYxIlMm7Vte8ZIvLurC5+erU//npGLzwVV1aTgU4LYCRmdSApkkxhExy7wbvpKDdU2jFhv966fB3KPuTljhgMA3xmKCx6jhYlrDF1Nt6w9ThsmqJ9xneS0IJkcqxgXjSPMU1f52DnFLn2EJQAfbz43ZXiNc0kVlRXnEUhgms7MeChwAO6BHj8K6iqqDbDxnnlfNTzrRgVLyEOAhdULUo+nWYifpDt971a16uZfbYKOHbpWx+feqmWm9mkyDNd4BuQty04/WRnc2G+PTck43RqQXhiA4iuOI7RfTYJqTAhuT7V9Zp0nsr20gywgwPJmrUNFpIIYi4LbuEloC4F219WoKdmkYkGKcFlluekVdPJNJjD/rrRqCGCgHxzgkTT20OI025SVWTpdfE+YsKSw1MUQSOAo4v+dY2Qdww5CZ0LFUhGLarrF96LkIZf/n74tRAI8P+tf5ugbeXGLBfzJDLXrNYFgOIa8EvVH1iJcFyRSwyBOr5eWIO7NCr/2pPjUM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 10:55:44AM +0100, Borislav Petkov wrote: > On Tue, Dec 20, 2022 at 03:43:18PM +0800, Chao Peng wrote: > > RESTRICTEDMEM is needed by TDX_HOST, not TDX_GUEST. > > Which basically means that RESTRICTEDMEM should simply depend on KVM. > Because you can't know upfront whether KVM will run a TDX guest or a SNP > guest and so on. > > Which then means that RESTRICTEDMEM will practically end up always > enabled in KVM HV configs. That's right, CONFIG_RESTRICTEDMEM is always selected for supported KVM architectures (currently x86_64). > > > The only reason to add another HAVE_KVM_RESTRICTED_MEM is some code only > > works for 64bit[*] and CONFIG_RESTRICTEDMEM is not sufficient to enforce > > that. > > This is what I mean with "we have too many Kconfig items". :-\ Yes I agree. One way to remove this is probably additionally checking CONFIG_64BIT instead. Thanks, Chao > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette