From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9C77C5479D for ; Fri, 6 Jan 2023 09:44:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E238E0002; Fri, 6 Jan 2023 04:44:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CD0C8E0001; Fri, 6 Jan 2023 04:44:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 295898E0002; Fri, 6 Jan 2023 04:44:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 197E18E0001 for ; Fri, 6 Jan 2023 04:44:30 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0863C07B6 for ; Fri, 6 Jan 2023 09:44:29 +0000 (UTC) X-FDA: 80323889058.09.43BE839 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf13.hostedemail.com (Postfix) with ESMTP id 8A6B220008 for ; Fri, 6 Jan 2023 09:44:27 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=niVO44gc; spf=none (imf13.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672998267; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eXVsVcFB5IcwowdBS01rBrglplhr+nGiuEnrWvUqrFQ=; b=8fEqTkkGXJoka3me/OlIn6399RKEbnJhYj7i/MsAU2kObiVyT6kx4QCT1SBMRpzK+mZ31u +Mc+f6NnPdtf6F5rNXTlFnIq5rrL3D2v5rfLEAmXU7KtYjPER17qo9+I0uDXtV0PgPjJVA pK3Fa7q/zYSlz9p4U4OXq5vds0wx4uo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=niVO44gc; spf=none (imf13.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672998267; a=rsa-sha256; cv=none; b=Ks2cBDA+mCwJWqIxasoyJYsna0+LtJs29m32LVKo2TSkhWULU8d01M3iT6g/twMfvajX1G nFJ4w8Dgv17WogUIFRLbEsxwspxj2pA/eNiK6ssP9Mx+RSDn6q5p5i5lJesIV/ihqQ4rIl PLEC+ugoYrL1RLJSJrpKg0WKo3DvBhU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672998267; x=1704534267; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=fhXY6C/6U5im9JnhiBqmPE5GvqslI6HKlZc88plC8HU=; b=niVO44gcHD3eFifb2gb+lW3Uf96X/JlCSj2+NvrElj3llBjBqOIB5RJt 4rJcDRfMTUc2iv8Ia2AMx4TYDZqSFszKXZLTkx3Vs5h9focBxaq+4+/TF /TF+X0F+guBwTu0Im0bGe7VZ5ktslo+66fOE/ezvxrqV9xLEgv9oLPhEP VxwgsciDRxHBrIRYvQheaGAhpHZfkCWLfZb+nfUrAhloECP/Eo6N9c/rr 8yFArfOy4AYFHTw5oqh5ocyr1aHh4EfjWlk7B0CwUC2cSj1IQt8yfEjXI VbVB9AModt5dNNUrnmkUq6f19p9TsQe5PNAF39jEDhVe7GCNSIoOlvX34 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="320148925" X-IronPort-AV: E=Sophos;i="5.96,304,1665471600"; d="scan'208";a="320148925" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 01:44:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="901237278" X-IronPort-AV: E=Sophos;i="5.96,304,1665471600"; d="scan'208";a="901237278" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by fmsmga006.fm.intel.com with ESMTP; 06 Jan 2023 01:44:12 -0800 Date: Fri, 6 Jan 2023 17:40:00 +0800 From: Chao Peng To: Jarkko Sakkinen Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 3/9] KVM: Extend the memslot to support fd-based private memory Message-ID: <20230106094000.GA2297836@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-4-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 8A6B220008 X-Stat-Signature: ka5hbyhr1eoqmktsbqaj9qxrozmoftu7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672998267-854796 X-HE-Meta: U2FsdGVkX18dfOCCLZasycQRKDRmOrWOnJTnZ1HkgXBDYL0Zyq6PMJeFWmtvan2BXjSyZqB30erkxDo17eSeISEyBFHHwunochFK3fNDwSj6XYLAZiPd6ULEbTPp8JHrz3MeSWv04iLwDmqp2eF96zrh2UJ3pi7cN89H8Jf7KTD32yO1nawzm+MgRk7N2rBw0aw4MplEdy0T39Kg+3xOo8nxIoz6w7a46iq9Uz/VSm+Q1H/+ign44aK4Qf8VZxACvOzz7bu/M/qDVcKuNQcBmo5vGob4QGbpc/ZfKIRR5BWMs5BTy1dyCOblkU80G//kIQT/kfjYJTOhKNNqYZTmtF1FxV1BqfNBPkZ8pobycGP37yJOqmz5nUEg1YBHgDEtooT+Ad+YA2iwW1LcERlrF+z8AlPDRc5HTMzBxgRPY2OMDru2/ouXgO/RCdwCv8yy8f5tvnGQv1ICjgUmJMOd7AI3ZPaHerONrVYswitwkqTKGjv5PNZ4BOjeSGtla4GB86TrI8U1WPpjhnlFJ4kV2SzTADiIJw/XpsPeIYDvEPkHTOoaByVzWH47gB4ovHyHPZmRxVnJ1F5SyhV5PiIEmUlI5UBpsor2E6qT0EHFCoVqIRq08k6U70Nkv2W82jhynOFzPHZRNF5EeKEyPKsEDDOOUOytOvdKIgIOsud+XPDLq3GY0DfTiCTO2OIc5NX6IQMJQZWutgq2sgJcvcFvquJ66LEwx7wYmuf6tTP64HbIHc6BcyDr4smaT9pzLu1/v5X3D21SAhOk2+ETQEu2ixIa7xPMMUOre7uSFAG9E0qNn2L3htuEp7Ld2i13FRDbMDOtmbcrPh7bfcmRaAE5Y0YI5UsIjQZ0lGsTNbOXeL8cKtVzqW1007pYf0t6JXySbV/ByhUi00gRqxuAq6lsDVaZr+TypA8FXc5+vVUVP9qhA1bQcLqXiLhXGI9NhEtyzzUmTKOvOJo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 11:23:01AM +0000, Jarkko Sakkinen wrote: > On Fri, Dec 02, 2022 at 02:13:41PM +0800, Chao Peng wrote: > > In memory encryption usage, guest memory may be encrypted with special > > key and can be accessed only by the guest itself. We call such memory > > private memory. It's valueless and sometimes can cause problem to allow > > userspace to access guest private memory. This new KVM memslot extension > > allows guest private memory being provided through a restrictedmem > > backed file descriptor(fd) and userspace is restricted to access the > > bookmarked memory in the fd. > > > > This new extension, indicated by the new flag KVM_MEM_PRIVATE, adds two > > additional KVM memslot fields restricted_fd/restricted_offset to allow > > userspace to instruct KVM to provide guest memory through restricted_fd. > > 'guest_phys_addr' is mapped at the restricted_offset of restricted_fd > > and the size is 'memory_size'. > > > > The extended memslot can still have the userspace_addr(hva). When use, a > > single memslot can maintain both private memory through restricted_fd > > and shared memory through userspace_addr. Whether the private or shared > > part is visible to guest is maintained by other KVM code. > > > > A restrictedmem_notifier field is also added to the memslot structure to > > allow the restricted_fd's backing store to notify KVM the memory change, > > KVM then can invalidate its page table entries or handle memory errors. > > > > Together with the change, a new config HAVE_KVM_RESTRICTED_MEM is added > > and right now it is selected on X86_64 only. > > > > To make future maintenance easy, internally use a binary compatible > > alias struct kvm_user_mem_region to handle both the normal and the > > '_ext' variants. > > Feels bit hacky IMHO, and more like a completely new feature than > an extension. > > Why not just add a new ioctl? The commit message does not address > the most essential design here. Yes, people can always choose to add a new ioctl for this kind of change and the balance point here is we want to also avoid 'too many ioctls' if the functionalities are similar. The '_ext' variant reuses all the existing fields in the 'normal' variant and most importantly KVM internally can reuse most of the code. I certainly can add some words in the commit message to explain this design choice. Thanks, Chao > > BR, Jarkko